From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3F4EB64DC for ; Thu, 20 Jul 2023 05:38:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 851902800B1; Thu, 20 Jul 2023 01:38:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8012C28004C; Thu, 20 Jul 2023 01:38:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CA562800B1; Thu, 20 Jul 2023 01:38:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5907D28004C for ; Thu, 20 Jul 2023 01:38:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 28F291A0139 for ; Thu, 20 Jul 2023 05:38:03 +0000 (UTC) X-FDA: 81030884046.21.A2552C4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 6D4E080004 for ; Thu, 20 Jul 2023 05:38:01 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I5vaqIQN; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689831481; a=rsa-sha256; cv=none; b=c1lZhqsfNsQ+Z/IzJGyk0jIw6+7et4iAOBcsNFT0y+cVeI3B2nNBNvI36wFjktm7OsAwr8 zM3Yy4YQ/LNwlj3bs73GeA+WlmrM/rEikv99iRYnxYxl2h8cNB/Nl84Qdp5nqxqkiGIq7y SbB/A9kyimsJE/cjUp8O9S9ddM4Vnrw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I5vaqIQN; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689831481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jgWiN22Mnb/nC2w5gkEsLaGkwy7cWm1hXC6utgC/ULg=; b=l3XDYgk7tjFoocTsFMxg93TDL92hbw9AgeD7rA6kgn5eKaq32bbj/W5aoarpYdF3VbmpFW gHLXU+WfOXl5kLkSAAB8yMJzhLU/0zetLZKobZkeBgfykP64yfwkxvdIACvdC3JF9Mow4n obYjXf1zmkSVUNNDosaSipWEv1Y7QB8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 65D1C617BF; Thu, 20 Jul 2023 05:38:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EC4CC433C8; Thu, 20 Jul 2023 05:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689831479; bh=a4gK1D97qFOeqsvBd2dHAlBTxcjDDuDOYGdbrbAW3bg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I5vaqIQNSWRtNNeV0sxBPgE6Nu23tFiqCWrelX/PN3qtlgs7brOuJPbOPLbRpg6L4 aaU0eF0YcHxLe0LdaU/Bbc2qECE3LLOf/b4s2rTDpoTX63hjrM51DrD98nj17ES2FQ MWe9XaWwkqWmiiokl5CPdiTIOVFKF4yyaqUbCjqw9iOUZEevTMc0ooZrj+a4GDFct+ yexyxWdKjtCTYOLwI3WG3MvoKKmkYymqbL+tjkqgMbh1TEh9MQKqxIf7eFCgBwXxQD HzEYRLUe5T5TezlqlmW/ULE7+hRDYsYovGkAuvFyrfQ0GdW/lSuG59J3zrQ9o7+hYN MgyxXV8w3fW4Q== Date: Thu, 20 Jul 2023 08:37:36 +0300 From: Mike Rapoport To: Kemeng Shi Cc: akpm@linux-foundation.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] add page_ext_data to get client data in page_ext Message-ID: <20230720053736.GM1901145@kernel.org> References: <20230718145812.1991717-1-shikemeng@huaweicloud.com> <20230719094421.GI1901145@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6D4E080004 X-Stat-Signature: meog3ncmaszhabu4c9re5suiptsykh3p X-Rspam-User: X-HE-Tag: 1689831481-329743 X-HE-Meta: U2FsdGVkX1/o9v2B5ga9AyflM7fuN71hACXSm1cvwSHotU7xULnO+3ZLlkqKRFzdKqQypt/5OtPKVS5xA/zyojeYgY4CFg6HHfr87g/Jj1DkNxEM/Jm/yFjoXmgGTUdYQAsYPVgLd8uK28Ur75BSpB8aS3qXVWyEPyG8drq0I6LM1Kmg16qCm+Qqqj7Gwh8rOksYPoFlR4TIBwK2dKBxT38nzUjI9F4VtSgTOzoENR8pWxHlaAT491j7xzzmA5d7eabD1tThyrujyUONKC7/lcjqdDDmoDAxmzObmmp6thBhNygqvlEsNlY9NH7oO3SnzZsqWTSxtCY1zMyUBAApWDB6mhi8Qyhoz9+rxrmRY6AKGYUWL6yYgphOzMj0UclbDR29CYXqWqC+5cNDal60OvS8cYmbT7zVpgXecTYpE3G2qy247iuFpOloAg3CyzP2pN2Knv/hnGEVyHFwVNpGs+bFgUR2Y7ECpWI15LKWaFtapdpfmiFPNlgitCDMfUl0sTA6xNjRxfHhrQTCwAvnfjiDxoMJxTfgzmypWpW3LjXONb9NmyyWFWrPW/cq9q3KpeAy9RqFke1QItPJ0DjHNnl20bdpfvIW4Eq/oT55c7XTTCO4pS4pzDmpeIGk4DJphZaGr9QoIbds7DgzIWC8kdngA4JBeWo6evBoTqbqoMPDRhIRzg1fMqBy9wJI6LXR94/NLkLQ80sy/pVHoCZhlkA7MwajlKvHlW+opfBO/zPChZwRdfl+kOBuTtkq3i8/dRyV01cLNdWUALCL/GrG83cntiCaKasKOoddfTLmIyynzxo8Pp6V54P3CYm1t5Pc4DDKpB15e5gYCSdGnAC09Y++7Os9k+T+66EuQtYmUirQ5dbXDC32gdlBreqkkkVc7XpkY8vaoV84AkHWi6KxLEC2qEx41vwK/NZLRloltLA4TeTnhJSjpVR1/29jdW7VVJPYjVTVS+ofH/Uuqbd Yemx08N4 A41QQ43RhQChSK3NSAJ3esCV23CCW05qhgkVe9gkEiLDSquLOaG2JtMfzABpOaoPGdjyKnjpFZdxVAtJ0uCCtYhWUTanbrbBtp7s12Yhv5dT1J0No6Ycvl2AKFUfMkKUqtWXabCsdeFzXy8oiKXK+v50L6IY2gmhf3C1WB/P5XD2egD+1o09uh0pf8gANu+XTSbdJWX5L20Zm/QmD8BxUwzjJatJENsLrZl28f4HEp/rv66jWomotQ7rPfFUUT2CI38Pt2nBPvt0Bz8P0fhr40wyPcJCvoNhq4MXaIqjPY12DwP4txA266L2me5+fj70qlZ1tGrnPyCzf3RquYE8dIlONzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Thu, Jul 20, 2023 at 10:38:39AM +0800, Kemeng Shi wrote: > > on 7/19/2023 5:44 PM, Mike Rapoport wrote: > > On Tue, Jul 18, 2023 at 10:58:09PM +0800, Kemeng Shi wrote: > >> Current client get data from page_ext by adding offset which is auto > >> generated in page_ext core and expose the data layout design insdie > >> page_ext core. This series adds a page_ext_data to hide offset from > >> client. Thanks! > > > > Implementers of page_ext_operations are anyway intimately related to > > page_ext, so I'm not convinced this has any value. > > > Hi Mike, thanks for reply. I thinks page_ext_operations can be futher splited > into public part which used by client to simply register and private part which > only page_ext core cares and should not be accessed by client directly > to reduce decoupling. It would be easier to justify changes in this series if they were a part of the refactoring you describe here. > This series makes offset to be private which client > doesn't really care to hide data layout inside page_ext core from client. > There are some concrete gains I can list for now: > 1. Future client cound call page_ext_data directly instead of define a > new function like get_page_owner to get it's data. > 2. No change to client if layout of page_ext data change. These should be a part of the changelog. > I hope this could be more convincing to you now. > Thanks! > > -- > Best wishes > Kemeng Shi > -- Sincerely yours, Mike.