From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5332AEB64DA for ; Thu, 20 Jul 2023 07:18:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A01842800C8; Thu, 20 Jul 2023 03:18:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98A3428004C; Thu, 20 Jul 2023 03:18:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 804792800C8; Thu, 20 Jul 2023 03:18:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6D0EC28004C for ; Thu, 20 Jul 2023 03:18:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 415491401A8 for ; Thu, 20 Jul 2023 07:18:34 +0000 (UTC) X-FDA: 81031137348.23.11A72F9 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf09.hostedemail.com (Postfix) with ESMTP id 67CCC140013 for ; Thu, 20 Jul 2023 07:18:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EKtxTElX; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689837512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j9GN3HyftBoKSOmVAm+Fkdt+TXRyhURYP74WueJdYkM=; b=2dJx0kihfACLosuzZm1539UPrBD3a75R8nDeZYAWBeRBd09nTCnBHgxOyREyeu8xnMubRo VOVTYyanU/MaNE2Br+tCUy7YDGT+efT3FHDr5R50FUuag64hgAC6bJiMlFUHTwRYHuDPFE FDlivpZKDLVQVgBnvXjy2eykKpmrJWM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=EKtxTElX; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689837512; a=rsa-sha256; cv=none; b=4cUNPfSAREQnXcKFIhet4nkTojqxx/3GxVadeFVvdCpW1wrboUDSNxxpNFOem2pmWdYO5F 4ltObGG1kQfQOWUnkhttFA5d8Mwmj3Q+2XasfxNTlBWAhTDur4JirV5t7tLjGe36v6ndGX V61XA7iAP8iqyZrOTGvSnNq6B1eKwNk= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1bb119be881so3289615ad.3 for ; Thu, 20 Jul 2023 00:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689837511; x=1690442311; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j9GN3HyftBoKSOmVAm+Fkdt+TXRyhURYP74WueJdYkM=; b=EKtxTElXQnD+NjS1xmtvsURoPkam7yZWt0UiQSlGyx6eFpFjZTHxNDUHMKWNGRPvkD yfdfHIy9HvWS4HQZlH5yjir1JAr2tXphEeGfelSVPKeQSpOZuwlg+ubowqZhljoKyPF/ wct7IeputY2hV0GT9i83fiMcnNoyUWXmZZIlo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689837511; x=1690442311; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j9GN3HyftBoKSOmVAm+Fkdt+TXRyhURYP74WueJdYkM=; b=Zx0BFTXhkIv2Y2XblcvT+ipGGS7DdQ0nFbEIa58oQw1jfUXTYQUgiSuWKpGDQui9eo hBlDTggcuyDEjzgVFsUE1N6rzmu4NblcJXbIPVUjeW6cc3hZVrCIbMlwPj8pyiDQaudY 8rXddP5samxhLweFVuKd1EAOn+rKe1RhlCJmB7b3BKysQVJdznlNRDw5TX7wUII6h9bm usktcSueqt5uSNlfu+2MPXkmeNkunqDtsZtvDHIrHUu0DQsFHDKMvdbg/t520zp9ZwiL OnPkRBsnhtKk6I0C0LKsmitbj+GLt7Aeq1oPoTVOvUWpgFpBv/qnNPRJCjkAyb6lsodM bYLQ== X-Gm-Message-State: ABy/qLarPOen9YRVRnOBQKEmhb+ckKEPHbgJ5ia8f7ATO9GFLGAokTiH 8CVHe8c5LDCsev55Zl1Uo+t5Cg== X-Google-Smtp-Source: APBJJlHyFmZzX8iCbjVkSdMc+qY+0UhLZLbLGj1qifn2QYea//eu23FJGgw1q4e6QSAfQPTOW1B2ew== X-Received: by 2002:a17:902:ea94:b0:1b8:903d:8dd0 with SMTP id x20-20020a170902ea9400b001b8903d8dd0mr1472952plb.32.1689837511198; Thu, 20 Jul 2023 00:18:31 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:648f:4ec7:23d9:d855]) by smtp.gmail.com with ESMTPSA id ba9-20020a170902720900b001b890009634sm509533plb.139.2023.07.20.00.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 00:18:30 -0700 (PDT) Date: Thu, 20 Jul 2023 16:18:26 +0900 From: Sergey Senozhatsky To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Mike Rapoport Subject: Re: [RFC PATCH v2 00/21] mm/zsmalloc: Split zsdesc from struct page Message-ID: <20230720071826.GE955071@google.com> References: <20230713042037.980211-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230713042037.980211-1-42.hyeyoo@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 67CCC140013 X-Stat-Signature: hxrhyt55hymqkg5frugnq9kkiohtnyc8 X-HE-Tag: 1689837512-703665 X-HE-Meta: U2FsdGVkX1/3QdYjm6yZzzXbWfUo1IU/yJ+06/klZls3BinnvzgffO5p7mimZ+AA8DI5yqJC0XUMfzwHAZq8Dx8xly+x2fyIccUOrABz5Ry/uCCyw/9EXXUnSolUg8nQV211s4pjW9kGZGjRB6wy768ClRXDKbqfc/4vb+NfkA/CyyVSOXcRBTi4hTh4mDPL2iwmemTMLRzvLCrw0zToLi1NNqMIqsY3JlmyuW+1Mw3tHsd2FgPnKKLiSL8KFdNj7UGWy/eUqazzuW7Yy2y5KSAck3S/PTPQEXvmXAUorgMmscIUGuEUQSxUZuNmQUfCXt7hera+mye5lUc4COytdwxi4pEHuu7tsMDBGhcvUfQA8Fz+iBmM2i1nFLMAZW+He2mdOKclhhRXyQ1lU6cBWXOruzHomn8sOVKXd2PllHiVAzdF5aWm79W1G60VcCqIojabYI9jK1dHm1lOL+1efFcBvie0LB9+/IBWCM8MAEIQZZrUA5RofLfMvWkDgeG5sO2Wi22zv1KVI7ILO7SBndDKDkxp3Lx8NHil9J06+kADvqgb8Q7n3d3UkyZE8EtfmMPG4uqOiffhAtdX6cx/GBdLJ/3XQhVrPGmkjaflV8b8NOzYiVdATEB82JOnHaBUbhOFnnBac+9E4yI1k6/LF0FjobSMMdCUhGJVOAvn/Ookh+5kaz+FjtqXuGBx1+g2ZRHAoWI6R1lxHRgWqKxTRok3WiT8BUsIzHM6rWaoj1mK6DMvCtpbRZz/tGQxZHq06yVJ1P+GCV44ei7eqictHy9L57Z1zBAqt+09E3eaj/N10Bbb3v8AAnkx0Q7WQKb5AZmc26K8ZUPMM6+PiOvBt1+I90W8KvhE1bk/6QOYjDC7nib1r617ogxma85402532rV3nFFJoNysFS+4jVd60hN8q/wScvfdgxc3vdUGCuSNEtY6ySFbiZ4ZqZCEkvLKS+X5qWz29lqRfReLEm0 pt+FZc74 e1j7qtCazENfpwYl1fv2pc/xUoYj1jv7ZqRlv0VEAAxJCs2OV6sRel6m1fsWYDKWI4f0NsRse+3/13ssr4IJcKcQnsY4dIQz84/+xxBzxGq/yqRkojIYgLnhoyBo15lkNhaSXhv7UVhbtLyknAxe43kjZ0BiGk/auUF0G7mBAZ9YPLtmPtUWz0Zo2u7xP2TIhhndry3rsn/gROXM4AVvz3NyR9PPDJN/HCddK0wnw9dQrodTB5TNnUKLZsy8WHxFxpI35UsjNzZ4QXXEEUAUW6lvVC9UjMr4DWcFFPePfCtad/qxJ/DF9qwrD89v/Qy2/hwDuAvcYOLEHko768pnhlgIGdCFAUGws6X75 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/07/13 13:20), Hyeonggon Yoo wrote: > The purpose of this series is to define own memory descriptor for zsmalloc, > instead of re-using various fields of struct page. This is a part of the > effort to reduce the size of struct page to unsigned long and enable > dynamic allocation of memory descriptors. > > While [1] outlines this ultimate objective, the current use of struct page > is highly dependent on its definition, making it challenging to separately > allocate memory descriptors. I glanced through the series and it all looks pretty straight forward to me. I'll have a closer look. And we definitely need Minchan to ACK it. > Therefore, this series introduces new descriptor for zsmalloc, called > zsdesc. It overlays struct page for now, but will eventually be allocated > independently in the future. So I don't expect zsmalloc memory usage increase. On one hand for each physical page that zspage consists of we will allocate zsdesc (extra bytes), but at the same time struct page gets slimmer. So we should be even, or am I wrong?