From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5C7EB64DA for ; Thu, 20 Jul 2023 07:47:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A92A62800CB; Thu, 20 Jul 2023 03:47:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1BE228004C; Thu, 20 Jul 2023 03:47:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896F32800CB; Thu, 20 Jul 2023 03:47:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 75B1228004C for ; Thu, 20 Jul 2023 03:47:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3519FC01A1 for ; Thu, 20 Jul 2023 07:47:35 +0000 (UTC) X-FDA: 81031210470.18.2A70015 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 883F2A0018 for ; Thu, 20 Jul 2023 07:47:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Dp+qHW/n"; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689839252; a=rsa-sha256; cv=none; b=V2CHlW8grkslTzaTdPkgk1KhMXCQvOss/1twbfVozHhs/AedJ0tvRQccT4XeZJmI3Bh+Pg sW33TpkIK0e/FgsAYhByZgjfd6S9U9+pSh60Qi/yWQ5DNZmzhWJiYoH/uAH+g6M4XtcljC aw2BjKsB2PteVxTe68TMlXUoIhbYm1M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Dp+qHW/n"; spf=pass (imf25.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.172 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689839252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x57XYhU3kN/IVUYoEulD/81klEAIktkHi596Zb0HL4w=; b=tl7icwQZxa9/PHc3grp9EcTXhJQFlerzcNgRb5ZT8hFSQtMiCXSC7G/e4KpXun5uFhUyl4 UwcB8YFK6UYEaBqfmVRvs6UHi1C7VFykZ+R3prOjcS/tOoutPEKnWpsIpnUrXAaEyiISCp Ii4GCFKazQXD2me/MhQgVv4rwN0lYk4= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-66f3fc56ef4so1146920b3a.0 for ; Thu, 20 Jul 2023 00:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689839251; x=1690444051; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=x57XYhU3kN/IVUYoEulD/81klEAIktkHi596Zb0HL4w=; b=Dp+qHW/nR6UCyhAZiGmDV/jQFfcnch4ZFcmudCUX1GQQipGCSa3yHQRF9+bDdLBOpR lnGq/jOwqQ5etszI0WueigyK937e3TjBX+9CNEMs/ffg5YH463p4JtnpJwEATwVAtxOz 4ZhiSFw3R3//gXJvwcYzHrjiU4ntZVia03/nY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689839251; x=1690444051; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x57XYhU3kN/IVUYoEulD/81klEAIktkHi596Zb0HL4w=; b=W9rNv7x+fMOzrFZPkUaD4QrlKz2JivWZU2Sh4qYQYvSaTNVYHuVQAqAUgMiWzIhCVE Dh7lT9zSh/9t2tUnuWxc5WqOTw9yeycFPzuQKn5aTmc9g8ZsYKtFqbWu1xTuyOS6LYra Vt/DxICoic+7xGSQK7QVyuudNFMJTnHyYq2NQzA/3Mta2QIl1yuy6zhbY5KpGQiNxxho N31wJX7tegJandLGFck/TrB8RFj0hGDQZc3pVCRiQc5l/ou/VFNxaX+ditt77Ws3cw6v EFbezIl8oJOCwJP6mX2WYIn4xRl3++1Fv4Zwn9NDZLKWwSwOBXZKGOhX02z4VAo/l8Tw 8HdA== X-Gm-Message-State: ABy/qLbC4FM0VO6fGmYDwdBSRA141TLPJfeHMUBo6uk4BpTGYp+xZbvG FrhA9O9thC9llzVZBb0AUAY5dQ== X-Google-Smtp-Source: APBJJlHEeCR/suWmud/i2PuYaTRpd4qLu3qy+qEXnULQ8doYLNXChb7SNJEq/Gsdf1q9XrGYY1uxWg== X-Received: by 2002:a05:6a20:3943:b0:12f:d350:8a12 with SMTP id r3-20020a056a20394300b0012fd3508a12mr6583141pzg.21.1689839251288; Thu, 20 Jul 2023 00:47:31 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:648f:4ec7:23d9:d855]) by smtp.gmail.com with ESMTPSA id n5-20020a62e505000000b0065da94fe921sm511229pff.50.2023.07.20.00.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 00:47:30 -0700 (PDT) Date: Thu, 20 Jul 2023 16:47:26 +0900 From: Sergey Senozhatsky To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Mike Rapoport Subject: Re: [RFC PATCH v2 01/21] mm/zsmalloc: create new struct zsdesc Message-ID: <20230720074726.GF955071@google.com> References: <20230713042037.980211-1-42.hyeyoo@gmail.com> <20230713042037.980211-2-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230713042037.980211-2-42.hyeyoo@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 883F2A0018 X-Stat-Signature: tj6asj6kb1o1ikp8g7p5nfziauizkfxj X-Rspam-User: X-HE-Tag: 1689839252-584514 X-HE-Meta: U2FsdGVkX1+cg7xDAQo7ZPhYNcZacdk3QlojURiraBaJGznI/hl6IM9Je5WunS3I0YdRfKMJylvQBgPrX8+OZ7qlusxhFRNaKWQUHn8zIhaj62J4Ei5PltS+d6gKhpJjpo5Is2xndxfSRmU5rFFCLMGB4eK68sEQqUm26XW4c+phxAJjjDmuye+nyz/HSG/Krb3b34AEKQo2x2y9tiIbFp3MWFubcyd4vbgf/Tc8I21Ub9NqaVjvjyNbwVRJ670KuujwKEUw9wTCs6IkfgB9sTEnA+4rpG947kOavc7M8K/PWFFb9M3n8xBVmDY7WmyOamsUkfIA9IeqJm+hkgmfSDjki28zMLULrYLPHtUBADVtYcS60ZskRBz/gdnInpZiyFi+PgU0Y0LPFq4M+qQs2duxcbpNc5047BVUWK7s3EGImsLLCxcZF2JAqacb1+pJG36FtnK89D9W/hjQwob+pfpB4azI1whc5zxtir9okEDCsX+4KUP8tPKAXnRN1cT8j94uQIBuvook8E2GHmPuZlH/1NHVM+i3ENH1dkk6SkDzulgo47+wX+pdoSh1KlpJlIOiLm6j5oqYY9gHpQyn0jJiwLzjN6W+O1fbtcFLsMlJH+kFouBfSjCIP9hPIVabJenfVP3TaGrgN90i2DrYQohPKackcJwgJrqntbsIbdaK6u2KK2wsFtJvW743NzgzjGC/YF+DuZmPpf/xVz/h7jLlqYL4wS6/7W95MmHy/ASp7l0pU0LMhKcoJx7FmN3SuD7pd5MWUkfBelPfPGDygKQaGWkLov/eEz0X1pi5/aQTsz1rgyWN+sF9APF2qlRxCIVMXWmJuRiEH44/Qp603pJMrlZJYUoMb+he14Wu/YK0X7LDiy1YXkrEyzDrq+FFGXWySa7eX8FFRhA4yeWkmt3OmQfMJlN0bG5eKtYtfSgBd0csm/AxuhUT1OuCoKVlbewLYxnrPiSSQ9GYPSr FZ1Xyncu h+xlDYwn0aMkzQMwcmFwoT/ulsPpwJfscZgOPICDmBL/xuVsVeS7Bn88W12gtMDnQ/y7nfAvP/0oCg7S/abPRAnLPwCXu7FANeYJIeTex+3LePozfNjq5PoX/Ls93x1JBNHcZ0jTIn8uUbpsahX0WzOOLY8XHCZAzIKzdEpyVgZOENtZpkbd1THnvJAbe+3DbkbyBb4iL7fMe9/wLfKWeepbtRslB2X9qFpdfgRSmRakND8CpcqfdCegjMoI5rY9Okr8FvVAC/3G/mUGUYqo2amdIroqegAjtUzPz04qfcDcBfce6vRRHCqe+wFabbwA63mznCMlZb/oCMMQCZMhDOlNb5NX6WfjtU6qMHwzOi5RY99fenNDaBBRCFXPsyzAT1v/feR2YZvMInx0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/07/13 13:20), Hyeonggon Yoo wrote: > /* > @@ -264,6 +247,52 @@ struct mapping_area { > enum zs_mapmode vm_mm; /* mapping mode */ > }; > struct zspage already has a zsdesc member at this point, so I'd prefer to move struct zsdesc definition before struct zspage. > +/* > + * struct zsdesc - memory descriptor for zsmalloc memory > + * > + * This struct overlays struct page for now. Do not modify without a > + * good understanding of the issues. > + * > + * Usage of struct page flags on zsdesc: > + * PG_private: identifies the first component zsdesc > + */ > +struct zsdesc { > + unsigned long flags; > + > + /* > + * Although not used by zsmalloc, this field is used by non-LRU page migration > + * code. Leave it unused. > + */ > + struct list_head lru; > + > + /* Always points to zsmalloc_mops with PAGE_MAPPING_MOVABLE set */ > + struct movable_operations *mops; > + > + union { > + /* linked list of all zsdescs in a zspage */ > + struct zsdesc *next; > + /* for huge zspages */ > + unsigned long handle; > + }; > + struct zspage *zspage; > + unsigned int first_obj_offset; > + unsigned int _refcount; > +}; > + > +#define ZSDESC_MATCH(pg, zs) \ > + static_assert(offsetof(struct page, pg) == offsetof(struct zsdesc, zs)) > + > +ZSDESC_MATCH(flags, flags); > +ZSDESC_MATCH(lru, lru); > +ZSDESC_MATCH(mapping, mops); > +ZSDESC_MATCH(index, next); > +ZSDESC_MATCH(index, handle); > +ZSDESC_MATCH(private, zspage); > +ZSDESC_MATCH(page_type, first_obj_offset); > +ZSDESC_MATCH(_refcount, _refcount); > +#undef ZSDESC_MATCH > +static_assert(sizeof(struct zsdesc) <= sizeof(struct page)); > + > /* huge object: pages_per_zspage == 1 && maxobj_per_zspage == 1 */ > static void SetZsHugePage(struct zspage *zspage) > { > -- > 2.41.0 >