From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3F7EB64DD for ; Mon, 24 Jul 2023 21:42:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DD306B0071; Mon, 24 Jul 2023 17:42:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58E138E0001; Mon, 24 Jul 2023 17:42:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47C4C6B0075; Mon, 24 Jul 2023 17:42:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 374416B0071 for ; Mon, 24 Jul 2023 17:42:55 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 02B1F1C9993 for ; Mon, 24 Jul 2023 21:42:54 +0000 (UTC) X-FDA: 81047830710.20.BC04B33 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 54CC2140014 for ; Mon, 24 Jul 2023 21:42:53 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H+wLCg95; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690234973; a=rsa-sha256; cv=none; b=hFFsksJRJU5MnmLdRtBrz4aIQkdnVkVhOChYLaqpfOyfzUccy4CInby1Q84S0aNeNqg6Ac z1lvVv85iREmlyEo4HAVmtYu3JIAxbORwDjaBVAIF2ZwW4jwVp+m7iV6mgndCJLiKg2hT4 I3Xlhrjgg2N6xq6yBKID6XxWLXgbvTs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H+wLCg95; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690234973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R545p/QNHiPaP9cA7w7ppOaKR7Hstbm+AnXUgvAxHLo=; b=3Iw7r8f63Tj15P0b4rTn8WaaXAfMfWLHxmEzpyVQfb1iyKCN1cV1VNPlYltSYycO86jZQo 8211JztIYcwJTwH0zHMbCFOMTvXnMwrU9Kxgc7eWlJV/mCNwqq9Hzd7lY3JaM8yi0wGgM+ YzupyV8tQafkyj7UkYTsge6X6zto7mc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 44EB861426; Mon, 24 Jul 2023 21:42:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA461C433CA; Mon, 24 Jul 2023 21:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690234972; bh=+GmntWw2wj4TAgoks2s8GydM/ic6gHJYyYw6iUJJN68=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H+wLCg95ppWbEdS/gfrkBlRJL8GSzxc5pnGAfcOUfCqEN0jcAhWlrIkNXkEC3eP9V 4RA9E4lO3ZGF+hOfMegtSn23YCDhyojHCyNgkVXqFYk9eu+baxpHppJoOkrTr52jLn ez+LUhhfunIyHZUIiw3NHW9jcuuqLDCACBzZCNJGtXGGY9z2S2sHMDkfPMfqRZw4LG UHv0q4Dj0l+J20fH9caBNk9dZUPoclp8h7oqB/Iub1OtT9bbdKVnZY7de9Sj59rdqI FJQRaJNZbicCz7Av3AIqmtyi+z9NHYB3g3pAXC07xvRXolW4cs3fNElExHqHWlZ568 g0B3u7NtW3weA== Date: Mon, 24 Jul 2023 14:42:50 -0700 From: Jakub Kicinski To: Matthew Wilcox Cc: Jann Horn , Suren Baghdasaryan , linux-mm@kvack.org, Arjun Roy , Eric Dumazet , linux-fsdevel@vger.kernel.org, Punit Agrawal , "David S. Miller" , Paolo Abeni , netdev@vger.kernel.org Subject: Re: [PATCH v2 1/9] Revert "tcp: Use per-vma locking for receive zerocopy" Message-ID: <20230724144250.4cef3f4e@kernel.org> In-Reply-To: References: <20230711202047.3818697-1-willy@infradead.org> <20230711202047.3818697-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 54CC2140014 X-Stat-Signature: wugqpysbrxnwfg84mtdekxpapng5fpmw X-HE-Tag: 1690234973-948007 X-HE-Meta: U2FsdGVkX1+3Q1Ix4MbIxzVizT/ScbNJgG6fNZfJeKH1wG4MrD/6ZOBIIS+9DkZkgRN7jKjZDG2boeaSIJx21va1H+HcyETWNHY7h3uHjI4E+UT/3nuCHllOBhajms7AYjWFj/wKx2NO4YBYxpPdEzaVdbE1EHQtL19SnLEcZgejSLUSn/1DOiWKd1sEdzy+N5GNRYvgguKbbOTtDR3uJ+IacWVp30+zvWVyt1Dx6FGTgX7FCdP8eXoROgiYUq9wkbxqvibPzh9GJCD7Bi9KECb6+dCoZCZqGo9Q9wrBegxiYxMDzM9FOqefAtTf20cSZmXr2AjF7yQEp139d87gXsY3iw1g9GhtDHT/8R2YiG7tcXwkfbJ9kkpc9Y8Me9yni2YSYhrjK+1YRxD0+F6K+/Xfc6ChTSbUBAQq21r/I42yraR+P25DNEJpOX8Hs3VKhAUmBHHDIhDlKdQVVyW5QDvTqbdTf/kh9kyHz7SUIz+xXC98dvGvTPU7ODsIu1Aad3zeOCFAOJJjxJAp8J/PaJ6r6Zufd47B/pBmUCHZ6Uo4a+FlH0rg1xegGM/+T7b9TO7icv5xk4LBCPIxlCv7KvOOTlZjhmBNUhHi8QhIva25yQToaqYG5UJrfx1dP0y22Q2SAYuxdMpMlGvg/qZR8iU1bZI9yIZnFKUQwOGuXzgZNozT5V6XiIByj2pVmFFGRx7a0BbkOkh9f1wCZgFrMRFYaU8nOa1WWI/5qGO//uztP5Y8SpCVqWNl0ZAvMprHVjtwQnUYPD7/MVMDtB17wXfhHGueAVcC6/tDWKbBOyUWd+tJHTADIp2/nQNSEJkgnZ2S2olPzX0+NRtY75lTLo4ny/1IwZ0Vi8I5terk1JsQqBj88MrcQfVkz5ZVylcyWONctt3vPbUapL3ZHg+SxMydA+75gzsuLOzAY5lmOC0T1E5D/NR9KwKAtg3idjVv8RgbzveHFEiJz2v6IQM QWf215Tk ikypkoh+f2UBC2y+bsoAEttGWE0Sb3D7lHWxd9kHZdr0cN07L99XJpL7Ou6zbQNq/SxcNVsM8xDdMGH9REgK2aNKP5Bdt3ZqPUp4OPKnS0yYD/abuIHFcnFi9OFYfmy1B9x57Ut+v1ix0230pmVzhvh3te7Bvvy5hsSx0c3Zhe/dDZfZjnVDX6V6EUIjNXgHEGMJEtoPeUlAq49poyWQH1jUkV1+0RT3JjM9h8rc15N3uMcp0xNh4oqZiKWPdKkdYwnsutrgskfjGes6t48ufvZqxmIB7fPxzq4x3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 24 Jul 2023 16:06:00 +0100 Matthew Wilcox wrote: > > Are you saying you want them to revert it before it reaches mainline? > > That commit landed in v6.5-rc1. > > ... what? It was posted on June 16th. How does it end up in rc1 on > July 9th? 6.4 was June 25th. 9 days is long enough for something > that's not an urgent fix to land in rc1? Networking doesn't close > development at rc5/6 like most subsystem trees? We don't, and yeah this one was a bit risky. We close for the merge window (the two weeks), we could definitely push back on risky changes starting a week or two before the window... but we don't know how long the release will last :( if we stop taking large changes at rc6 and release goes until rc8 that's 5 out of 11 weeks of the cycle when we can't apply substantial patches. It's way too long. The weeks after the merge window are already super stressful, if we shut down for longer it'll only get worse. I'm typing all this because I was hoping we can bring up making the release schedule even more predictable with Linus, I'm curious if others feel the same way. On the matter at hand - I thought the patches were just conflicting with your upcoming work. Are they already broken in v6.5? No problem with queuing the revert for v6.5 here if they are.