From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56BBC0015E for ; Wed, 26 Jul 2023 00:30:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BFF86B0071; Tue, 25 Jul 2023 20:30:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 622B36B0074; Tue, 25 Jul 2023 20:30:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C3E26B0075; Tue, 25 Jul 2023 20:30:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 349836B0071 for ; Tue, 25 Jul 2023 20:30:42 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0C2A380F33 for ; Wed, 26 Jul 2023 00:30:42 +0000 (UTC) X-FDA: 81051882324.14.949ED3E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 352A080018 for ; Wed, 26 Jul 2023 00:30:40 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="O/Ew3KvC"; spf=pass (imf02.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690331440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rD7rmrcfXznSunxka8xTcv+lxE9AgRyqjifQeEbmXHA=; b=ApNP1AlpMcJ8+xKtyqIfp/mduitQYe3j/GHkj068YpXGckmIh5YamDJ8+foSPjrhJTDStB lBlUtC7UTUibar0N1EoYU2aJgHwM6q8Z1hz4zUD/WZBg2NciX1VuxgQCsE8oBeFzYvVB3p QIW2l22ggQIOyVmygq8S70PK3dfoGKk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690331440; a=rsa-sha256; cv=none; b=kNRd5B6KEVGDYe7ySfZw2KSZauWutEg3cA3LjZzPn3P4f3Kx7cbgK5QAlV19jvhlJStu3p p/z0saFdAe+nmBccufY+vwnwsb0/JHGwSatjV1P1q+0V/loR7Wq+T7SB+oKEuAd/JgRNOi yIDfifaZvusTvuET0PzDVZ6mXdWQ85I= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="O/Ew3KvC"; spf=pass (imf02.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EBB1619E4; Wed, 26 Jul 2023 00:30:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17D78C433C8; Wed, 26 Jul 2023 00:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690331438; bh=HwRJf2zxAV2y30LZeuhROoAoaYKeWsk0jz6e4I2TDSc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O/Ew3KvC2OYxWejrYo1gr0rQQ3g5uQPthHMWNklJWVnh5zoMPVe9NzCIdZwAQXmLf +1A+Di9DS6TD36yOmgISCSfAjdrPLh2TO7Gbf1llPGWTo3i3KCDRMNpz0eJEW06PkR PILqC53xtrFUkEZcCYmGEATmmHWo2vsJnwIEiJQWQZ8e39JEEtVOjgEdF788hEV7y6 LbY+o2nfE+LCSAt0m1hkH+uxNWGQuJzg87s9AuaxvDlkX5mUpfPQUchBaBrAbCjAd9 vjYoJAQjDlA/IbWCElcdUES1bgjq+sK/7YXbIMhgjI05BqtIe16+S+ZTjck/dNyHVE 3UZ8A2gLfr8dw== Date: Tue, 25 Jul 2023 17:30:36 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: David Howells , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() Message-ID: <20230725173036.442ba8ba@kernel.org> In-Reply-To: References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> <20230630102143.7deffc30@kernel.org> <20230705091914.5bee12f8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: toj3nmjekjak98xmwjrjzw9bxpb6bnsw X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 352A080018 X-Rspam-User: X-HE-Tag: 1690331440-715376 X-HE-Meta: U2FsdGVkX18jJdvO3eTQp3sms8Yi9UqUqi0YTdgw4e/RYIbMGQQc09Pmzjips//A8dRI4othiEJRHtqhC90TXnmM30BU3mDVeHouPnjrQpNOff17ZcEK0jKMtZsxpMiGfPJrQ8rI7Nqu3HNiZ1SdFYGeM+taW7OL77PWKtgmvdg9yCh6GXDcZ/lrWwWT9zZe9/0hrrVO8QhNIC3qaK/N4wlfqNHDsPBO7L6CwHKiKoqNMSkbDDlz2p9om2ncT+QIFaYmbOmBo1dG7HnljBA4CBG8fIBS65ULF/H/8ispWTwYWVncyqcVnIc+mlCjHh3pVKXix+2q/L1Mj6x9jgnJ8XY1ZzAFju1PX3npv+RiFiyRlUpY4i9tpIeh2FpBvX7nMXwvwHRu8FNI0xxWtc/kgTgwiD8ixK2gphUSBHw22nvDR0VeuB+SWDB82bDFOIw+acU972Hd/DU2DKvdJFY0BlXH47H9cc0KQXNR9noaXgxcUnLj8JGYG/BuSc9/xPzOksRgyb5Ylepr63Ku56TDkDeP2MerUb1eVBom33GGM+VN14UvXyvCjTSd6q/bK75v2fzrDtTqAHtf32glIAj64MzWuJMJyBlOut0UTApN4mMtAdy0kdhc3v1gUJezX7+/gJ1rzu6wSX6jaU/EcPE2bUYDq98kA6NfGO53olRoM0KcAFggOVvTaldvEi2hpRn/Dj/Ffg+ELoDbe6AW/G5Sw1uy4TtUYpXLlNTQB7MmnlTlexDGNDKtO+fF0KUvVtKj0/3CgbOYUfl+Rk3PYhL4fGBvTURKTvFk4qIlMAycvqeEXxtOeoO5z/vvABhc4SJZ7shCMNA1PQyqfk4WW3cZ5MHRcs0/OgkfdAfELxBRFvNBbLZkMQ17XwQQccg4Qi//MQSGAntChdZtu3TJpEoSlmx4c21fcR0svfEdsaQsVdDkIWzFczGciBd2Bwr//NkQEmx4OlRtEdhK/W6Zs5w VZ9VhnfR wsYRihtuL7ZmEy+6+veubfdAw+fqMiIj+aiUPqItDC+0O64AIoy41nCZz6jaZl3xSU6D+ULa5NCgxEevzCEUJH1+jb6D8w5Fvbl3oXUiOobavuelziYicYnMPH6TYugUiwx8i8qCsJkfjNSMIHd6QqISi9V19oAAt5nlKBuiRQwUVsetjZDA+rwjmuuI8ax+VHjqY3pG8BCBJ0Kdn8WmuMmPSA/tzu7dJEQ98tp68D6xCyqphY0O5UmpIld2q2sQC1kQygRC0YHvzd224DpZ8RRbQjLvA+wWhu+x4+g01usS+jhOLK3uUlEh9M9N/pxbN3zS+8UUxeUPUZ4RA5xlASOk97w1EVeXKK51ManyHpM+yOm7KcE9/MaVaukY/Qhj2PhI9oHtjuuqIKWUiMHeX7o/Ne33TqccF9zo2aX0V2HGdYjd+dASR/I+jCNbDRUcS4ASynE/GGs252MfVvSqk7PtzXPLZub2SRCWfhR4D2SV5TNMYVmxwB5fItLxoRGW70INwBshxt957Wfkxd+1uuzt6W/BJy1k1ZHAQexPFhTzlACVan2DnjE2ySEPi6oFFgpqUxx/HM1c+HM4ILQweP0nY0x+rMFs6zcZh6hb+3jLvh06QV/HUjgzfW8EdBorX6YNE0b4QpeDmosaK/6lYfDtzCCqH2dK7s+vvRz6CquNnCXk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 23 Jul 2023 09:35:56 +0300 Tariq Toukan wrote: > Hi Jakub, David, > > We repro the issue on the server side using this client command: > $ wrk -b2.2.2.2 -t4 -c1000 -d5 --timeout 5s > https://2.2.2.3:20443/256000b.img > > Port 20443 is configured with: > ssl_ciphers ECDHE-RSA-AES128-GCM-SHA256; > sendfile off; > > > Important: > 1. Couldn't repro with files smaller than 40KB. > 2. Couldn't repro with "sendfile on;" > > In addition, we collected the vmcore (forced by panic_on_warn), it can > be downloaded from here: > https://drive.google.com/file/d/1Fi2dzgq6k2hb2L_kwyntRjfLF6_RmbxB/view?usp=sharing This has no symbols :( There is a small bug in this commit, we should always set SPLICE. But I don't see how that'd cause the warning you're seeing. Does your build have CONFIG_DEBUG_VM enabled? -->8------------------------- From: Jakub Kicinski Date: Tue, 25 Jul 2023 17:03:25 -0700 Subject: net: tls: set MSG_SPLICE_PAGES consistently We used to change the flags for the last segment, because non-last segments had the MSG_SENDPAGE_NOTLAST flag set. That flag is no longer a thing so remove the setting. Since flags most likely don't have MSG_SPLICE_PAGES set this avoids passing parts of the sg as splice and parts as non-splice. ... tags ... Signed-off-by: Jakub Kicinski --- net/tls/tls_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c index b6896126bb92..4a8ee2f6badb 100644 --- a/net/tls/tls_main.c +++ b/net/tls/tls_main.c @@ -139,9 +139,6 @@ int tls_push_sg(struct sock *sk, ctx->splicing_pages = true; while (1) { - if (sg_is_last(sg)) - msg.msg_flags = flags; - /* is sending application-limited? */ tcp_rate_check_app_limited(sk); p = sg_page(sg); -- 2.41.0