From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8529CC001DE for ; Wed, 26 Jul 2023 11:01:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D3918D0001; Wed, 26 Jul 2023 07:01:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05CAF6B0075; Wed, 26 Jul 2023 07:01:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3E368D0001; Wed, 26 Jul 2023 07:01:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D05A06B0071 for ; Wed, 26 Jul 2023 07:01:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CA52A1A0E04 for ; Wed, 26 Jul 2023 11:01:54 +0000 (UTC) X-FDA: 81053472948.14.FBFC289 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 571EDC0010 for ; Wed, 26 Jul 2023 11:01:49 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cHN9Tt5r; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690369310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TkpEnQnFcgjsxV7Mb9Y830heirxfbxtFP87CIwaZAt0=; b=WXYaCu6mBJi0DImPlyC9YxFGFpRI4tKBGOtfGzw7a3OErx7StWQ20PWPbnZa/y0W5JBazy Ts9JylnTRaaVaiHN7PsZ8uNvDlt1/VMvSkDxxzH5WlD2+I3TlT+xZIgN+s5gEJ2acJxwGV BgkjtjfLXaQAX/183IfLH+G1mXPYJZk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cHN9Tt5r; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690369310; a=rsa-sha256; cv=none; b=Kgetv8t5b/USnWqylPU7h9zCZYd/5R1LUzmymWgLD/tX4YWta/h/DsUn1BbYoHUsVj+2Xy yrFzL6ZwjxoTiSiXptBGEGL1LeZ74gbp2zd13IXlIYL2fqJOjsHndgWRZm1LKGgiokZloh vRZ2fT0i+tO32lGNqvlZOviYPOV1hW0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E35F261A6A; Wed, 26 Jul 2023 11:01:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E195C433C7; Wed, 26 Jul 2023 11:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690369308; bh=E9Nptia/LKz60/XHD5d/zhhnmMiksgZ3DAeI9Q4oeaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHN9Tt5r+ufFlJiEtRTftRJM4y3eXwbo4n8rhYaootGrDHqyk/IqAQBJkXRdMhy+D qTLii4YgzJFefLZfLuWR/NdTpSZR1lMjy8KcSm4L/2TWx6yd5A6Ab8vdG7W9P+Jn0b Msw0zEnXTTXFQ34UfegBqoa+fqxL3A9Cw94S/nnmuN9JT2PsGuKB+GdPmtHO2JC82L FTBQmVPYjXxoSK0r8QnBiwnd9RBiQLXLPsfbxafQu8zkqMSAxEABQDRyJWGNlU+zMU g9juIJUkV42hO4VvCYh8/q3ly25barX0HmBImE1S5sNcf+2H4QWV+ujgX826Ymg0mZ yYP61TSRVid4Q== Date: Wed, 26 Jul 2023 14:01:13 +0300 From: Mike Rapoport To: Usama Arif Cc: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, linux-kernel@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com, simon.evans@bytedance.com, punit.agrawal@bytedance.com Subject: Re: [RFC 2/4] mm/memblock: Add hugepage_size member to struct memblock_region Message-ID: <20230726110113.GT1901145@kernel.org> References: <20230724134644.1299963-1-usama.arif@bytedance.com> <20230724134644.1299963-3-usama.arif@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230724134644.1299963-3-usama.arif@bytedance.com> X-Rspamd-Queue-Id: 571EDC0010 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: cdrdqmsi8cpq1sp9cj6ysa4881qawhy6 X-HE-Tag: 1690369309-399048 X-HE-Meta: U2FsdGVkX18FCWfN43xGE8Io2jtFv71+Qe+8eABS2tnvb1YkAtSH4AtIgGF1u/0fmQx922MJd6zuzFg7UqQdHBLwG87P7oA405/k9/LCNjZ/+2DmijshtqRP5ggCQkN55wUgdwKaHTaF5/qCvRVggeJYHGWCDhHvFQb0Ent8IzjMl5K9qOpRkt4QkNWv89W2Mt/kiwuBupzbnYkX6M5sBFENparOwZufH/kWyCOrWU1fTkXEXSGjCPFDt49J7YcV6Myykih4DED+lpyj2uJm3yWiny0HtruaBL9jzfI0PUQDcXmXyK9wvYYEKxrT+TRZDuaDjefyav4OfOHZbeLbukpTp4NAUEBrPbdxQkZJfU5VSKUzheXUnsrmd2auQqGhYebTKVMW9j5UW7Gz8+myPmEwTLCxb8kdNX1+wZDLIrzztBa6dm+v93mFLSAPZIBwgmkW7FS0G+zO6SZQgmnAoB9Fia9saGPsW96sRp9cEX5LNES65XO8sIepDbiYqk3RFflGDCOWbVEkDSN9Ou8ngTdh69vVSNGoHo2OvndKu/DrcmjYCyh6FT3Ts9VqLuEkUjdFPtKSaNYBUgvQ2w2h4CjV7AQE5/gVp3sPo8TMmnMWJNODi7ydhIReAgDCMlz4OPDEkR1Jt2W7xy0k1igmXZK32AdQjFL+729p9a7rZ4sQy3GclnxXWxtAbCl3LpHQX+gcFaCNkl35MQ9xc76nQi+YGzBxoKVRPrhAG7kXxXAUDp4TJVOtIWdFzb2/Q9V5RX3TEVyKk/zg/ItbH5e+atC+1h0Oy3uKHpVbggaZpcXGww0PBS2GmB4ovEjRMs8xYRwsQl14O1ptlYDRggaoPqKCbHA1jmxYAINutuKYtSNuwJ/GggcfUM+cK+JwjgM2YGFlKHXF2CWjf12usOgZtfZmfU3svf0ZA/07CxBWEO2KMkpLXxa8AjKQdS5pl2WFmRsR0BvxVs2puauBuhC QHvY/F1T +i30kVh6E6pl9R8HUZZnEUiNW9g1y90Hj31LABrZLt8BY7HQH2DHmVLo/qhM0zBJ3Ev1jQjcFJ0ifwPulLuwiWGcjLkdAiPkRUVrGnv3A0LII+By2bfIGkCYTiW07MOkqMj2pbrOTBlP6mlQBGjuNMBhqUFugIHX25RI7p2nkwSejT/JrvKa3hGcFFqAyaHRX43fCGt6lsBZC4Gx38c6/vTxB61zAX50lQEvG4ZSZr93eZr2yIfYG77WOd3wN7MW981RUKU0GEehBSZt03dbhPJPlf26KPcRuAgmO0xPb4gf1BWANZgxNdHcpuGrcsrwGVQJruyOJpTStCwyuEYnQ16K2uTVq3MV6z3aFgSCNdI56El0EHho3uR7JRRdscC63xGBIqU60S1Z5xe0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 24, 2023 at 02:46:42PM +0100, Usama Arif wrote: > This propagates the hugepage size from the memblock APIs > (memblock_alloc_try_nid_raw and memblock_alloc_range_nid) > so that it can be stored in struct memblock region. This does not > introduce any functional change and hugepage_size is not used in > this commit. It is just a setup for the next commit where huge_pagesize > is used to skip initialization of struct pages that will be freed later > when HVO is enabled. > > Signed-off-by: Usama Arif > --- > arch/arm64/mm/kasan_init.c | 2 +- > arch/powerpc/platforms/pasemi/iommu.c | 2 +- > arch/powerpc/platforms/pseries/setup.c | 4 +- > arch/powerpc/sysdev/dart_iommu.c | 2 +- > include/linux/memblock.h | 8 ++- > mm/cma.c | 4 +- > mm/hugetlb.c | 6 +- > mm/memblock.c | 60 ++++++++++++-------- > mm/mm_init.c | 2 +- > mm/sparse-vmemmap.c | 2 +- > tools/testing/memblock/tests/alloc_nid_api.c | 2 +- > 11 files changed, 56 insertions(+), 38 deletions(-) > [ snip ] > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f71ff9f0ec81..bb8019540d73 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -63,6 +63,7 @@ struct memblock_region { > #ifdef CONFIG_NUMA > int nid; > #endif > + phys_addr_t hugepage_size; > }; > > /** > @@ -400,7 +401,8 @@ phys_addr_t memblock_phys_alloc_range(phys_addr_t size, phys_addr_t align, > phys_addr_t start, phys_addr_t end); > phys_addr_t memblock_alloc_range_nid(phys_addr_t size, > phys_addr_t align, phys_addr_t start, > - phys_addr_t end, int nid, bool exact_nid); > + phys_addr_t end, int nid, bool exact_nid, > + phys_addr_t hugepage_size); Rather than adding yet another parameter to memblock_phys_alloc_range() we can have an API that sets a flag on the reserved regions. With this the hugetlb reservation code can set a flag when HVO is enabled and memmap_init_reserved_pages() will skip regions with this flag set. > phys_addr_t memblock_phys_alloc_try_nid(phys_addr_t size, phys_addr_t align, int nid); > > static __always_inline phys_addr_t memblock_phys_alloc(phys_addr_t size, > @@ -415,7 +417,7 @@ void *memblock_alloc_exact_nid_raw(phys_addr_t size, phys_addr_t align, > int nid); > void *memblock_alloc_try_nid_raw(phys_addr_t size, phys_addr_t align, > phys_addr_t min_addr, phys_addr_t max_addr, > - int nid); > + int nid, phys_addr_t hugepage_size); > void *memblock_alloc_try_nid(phys_addr_t size, phys_addr_t align, > phys_addr_t min_addr, phys_addr_t max_addr, > int nid); > @@ -431,7 +433,7 @@ static inline void *memblock_alloc_raw(phys_addr_t size, > { > return memblock_alloc_try_nid_raw(size, align, MEMBLOCK_LOW_LIMIT, > MEMBLOCK_ALLOC_ACCESSIBLE, > - NUMA_NO_NODE); > + NUMA_NO_NODE, 0); > } > > static inline void *memblock_alloc_from(phys_addr_t size, -- Sincerely yours, Mike.