From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4AEDC001E0 for ; Wed, 26 Jul 2023 20:08:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15BF26B0071; Wed, 26 Jul 2023 16:08:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 116E18D0001; Wed, 26 Jul 2023 16:08:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F16346B0074; Wed, 26 Jul 2023 16:08:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E27026B0071 for ; Wed, 26 Jul 2023 16:08:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AB68EC02E2 for ; Wed, 26 Jul 2023 20:08:24 +0000 (UTC) X-FDA: 81054850128.01.A514A56 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 0701A120029 for ; Wed, 26 Jul 2023 20:08:22 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TSpMUIur; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690402103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CT/Wqurjfb8oNcirx3GnfFJTTZVmhBDsd7W79f7cnKk=; b=UJJf5oOjcph6S+toOwk+HJA7KeKyojgKttxZNgu0EijFRDfap93LQXL1AQ5vacw5abZOMT R1PYo5MjZU74onJkSMRH9jL6F/1dvBuSagL3stRzg1R1hiZDWJ15Zr1O/3/XVSzQTJG4td B5UwNDqKvv/PjFzvUjoysbwM59hmSDY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TSpMUIur; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690402103; a=rsa-sha256; cv=none; b=3uMebcwv4urWMM9AP2kGoSpT8NEfpGktvQG3Qcovjv/NoGLUANacujafeVhCOl6VIpx0fZ jW/TYgytyXfnr0XQC9zyJK/Cs7jQU2cMC288GhpSF8bFM+3UmSgtGCW6EMmoTVUi47lZ1K 4POCGUMgRxUKogq0B+yBaok3bnJSD4M= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3034661C0A; Wed, 26 Jul 2023 20:08:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0861C433C7; Wed, 26 Jul 2023 20:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690402101; bh=tkm5m6riRK6JiPDBJ3xtHiTEA7gBu5th4OS3XdarM5c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TSpMUIurbr1bdPa/0B6DOsiuTbVYbYdn1w3Y7xsqo/U8GbwvNsc+J4PEbd+BSWgDg DfIrSvjcMk6VubAyi5DhS3kIVk1nU/Re2CFRBWg4ziggvxwJAHngCA9FozCAef+xCe 8VeOB00p7A3EdAdVg8o3k6pTY+Y6zKOkQyFMykrCcZkz4jbdWQjwa3FAlWRdpCvOzR vhJ4gkmZ1/ILwHRkxBH9i+ENvEDsISTlBVGM0+iSpMkRzVyYuewU+GapzRblvcE79/ le+jGJbme2f1E5tR6UmraYRRWhqLC/ZkZi+LF0UnsNew5Ryjz9Eq3FKcLq9Jmcj0Ou tkfw6LwxZKPNg== Date: Wed, 26 Jul 2023 13:08:19 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: David Howells , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() Message-ID: <20230726130819.6cc6aa0c@kernel.org> In-Reply-To: References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> <20230630102143.7deffc30@kernel.org> <20230705091914.5bee12f8@kernel.org> <20230725173036.442ba8ba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0701A120029 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: przurb85kqspc4w41fxusst7fdq73pdt X-HE-Tag: 1690402102-86407 X-HE-Meta: U2FsdGVkX1+gnJb4ZGVTHPjTVBlSiPYGYi0L2olk4+MdYbKangs4FC2aETpwlx6jpJP4T2ucWRG2uPQpCHgRUHDR8C0LvYAKXARpDbI9rrP4cxDdxENlqdJW3KZkq2EAxLJvp0WNBjZHYdKWMY2pkHzrKXgHlcOw66GwtFEtccV2vx/ceaEPD7kX8HE9YJsVghtyt1bzGGxkJCLujxT/hRaY+NZc5XuS0qKIf0wuyH55VV2KlXi4sNjxjJ4MvdMIzkWynz6phzHpnJp9M88lCkpmHe+p2NkGSUTvG6yA6xMBHjbegVm+4bebMHvELWr7Y4v99xt5rhSX6J8MmJJIC9Hy9oAiw9mJqbcycTjQVNz3pBdN7JG90mkMQbtD9lPAc53v61PNXvDc7oUFyq/N7qxVWvxMIMgqiY6yElgTh0aeqXR9WF9aZQ1tNhRqVwrot6Xidvnyw64Jw/TSrdG2F45lvPfFQvgVxvYEdfgN3k+xGmmVnVC4eowCOppO5BiBDwsHTsMe2TWinxPCR5tvrTuXq4kWRNl8OwubsVwgGDZQJNx0ywe1GVgtKyktiUHHncplsb3PiQACNabxgDg/F0vmL8V1tKL9C4WWqf2lepxF5KW8OdwflYgWvzdyBUhgaYdqK3OUYDWFEq+g7zNH02i/5VGZDESaUIjlHmPmRwcDh6i2B6aPprrQ3iIyO+1qbm/jYeXCUPa3mQjwZUwb8tTYwXa4/0UVEoQwfHb24muphk8b3BC2flWGMHK+DziJvV1oQGjZ4XKp6NFMZEs8mopnNKP2rkEFAi4JvDkd1sanHMylbiHw/tUZJckUZgs5HvUf1aTWRxd5Jj2BE54EiPbxZuQrAJP3MyWBox7xJlodf4iu3tztw4BE2Lwj2ZF5eKlIEIL6GzX9cnp+vpCRqjEDdDRWYdI1zr6MRbT3FOHc5jsI/WLfMEkJtPmmtS1j9NiIMkMcy+Qi4hkS7Gj vc4Zrwv1 HZW8nzT2G+bLTrusvj+760e1VXFy7ypGRAErw5ijI3WEKreeXiFk9hi4Qfv5FozyA/2O7xagxu7vEkzz+9cTYOwx3lDR7GrItiD9IHx6wu8qd8jH4LXVX1XCtYFCDyjnu1cGBIpwFvPn8QIpUweG+wvU/5wBXz7G0eFsshRrgvXwqXKfR5Y/+x8qgfo2fXoXcN0ZeP8OJp4fNuTe7DUSd4d/uHUe5wdnOO0hHYxblDqRKBYx7voqCfdlxTdZR5tFZPmTcy+1laT+tzKPhbAPiTUe8vUDzujsMwjRsNYyq73lfA6hyd4kYQspMslOiCLnqr0thWwnMpsglFmBPB6rSF8MzuudcVpU5HU8zs0USX0f+ixojwwbH0M7Mo9XadedUqyJor3B134pk7TR5YyUYD10irBn+6Q+e8af761caGB9kH3iSWppH78HJ3Kw/s5K8gdTKsNpsY14RZmM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 26 Jul 2023 22:20:42 +0300 Tariq Toukan wrote: > > There is a small bug in this commit, we should always set SPLICE. > > But I don't see how that'd cause the warning you're seeing. > > Does your build have CONFIG_DEBUG_VM enabled? > > No. > > # CONFIG_DEBUG_VM is not set > # CONFIG_DEBUG_VM_PGTABLE is not set Try testing v6.3 with DEBUG_VM enabled or just remove the IS_ENABLED() from: https://github.com/torvalds/linux/blob/v6.4/net/ipv4/tcp.c#L1051