From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B26C001DE for ; Fri, 28 Jul 2023 03:53:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D3036B0072; Thu, 27 Jul 2023 23:53:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B2656B0074; Thu, 27 Jul 2023 23:53:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 470806B0075; Thu, 27 Jul 2023 23:53:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3B82E6B0072 for ; Thu, 27 Jul 2023 23:53:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0BFBD140693 for ; Fri, 28 Jul 2023 03:53:45 +0000 (UTC) X-FDA: 81059651610.20.7C0DFEE Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf03.hostedemail.com (Postfix) with ESMTP id 321482000A for ; Fri, 28 Jul 2023 03:53:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UJJSmsvK; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690516423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=He4/7ZjAaJYV3oY1Q5qsfXRQN2c+aw/i3Z8upeCFxZY=; b=z+90V9g3bm7o/Y9FTlUjhlpW+ZW/j4zqTHXq6O0PgepLjhV+oLJtSrAABLnaNf7Gb5BubD slNbYBPhpvjSR/dTbeswK91otCMsT0ujAOwXyShc/taHzqYgkJwDdOG2Aaj0tbdhv3fshJ 9llT9pq9J2ltiM8TpoeFaaKUpXicBvg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UJJSmsvK; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.169 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690516423; a=rsa-sha256; cv=none; b=hEZCzE9+nl5wR8J31dD3jl6xl8ECChD4WrUEpr0SzOk7pMbMgQumH0FPNSqBCYsCCUm6U8 d2l6PboPXGLzscMHJ/bWYVO3WyrZFeVwshu198KMeb2UFPY0DRBJwE01tdN8nQTkwkGmjb iBMOKXbRDGy+Q84dtqWxCmb169V9pCo= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-686efb9ee3cso1598476b3a.3 for ; Thu, 27 Jul 2023 20:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1690516422; x=1691121222; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=He4/7ZjAaJYV3oY1Q5qsfXRQN2c+aw/i3Z8upeCFxZY=; b=UJJSmsvKuA+7vHlEK5zqxwvD8B6Yt8XfXuAItoiHvAj3OoqGrALOYkCYQccCqOBd5Z tmtMhmnK6zN87HaVH9ygwQIQdC4SZMGydBwDwFW+ZmxwVd+Yinpn/4wGAvXFE++zJAos O2FXcKEu9fLVqrGMsoLKFn9LRJ/AlJZ69+Cpw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690516422; x=1691121222; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=He4/7ZjAaJYV3oY1Q5qsfXRQN2c+aw/i3Z8upeCFxZY=; b=ac3Z8U3gG86bJ8PDjf3rYQXTd0q6BQAo2TgVt8edXxjRumolZcRm/9ezTB/0COlmth TOD1/vL/JpuPHOfesTbRfS4ITprOylyGk3pc/Ldaq2O/z33GOSxHw3OwRXIrKDTyPFa9 ymxgXgusUwaeJDjgv8wwMAXzmOrZ5WS1enEb9rnZzNwhYcTF3WNmgR2Mw8vu2AhfGvIL 7a4LYau4xZVIjOzybMLk6JuZ7lok2doZgJNHcW6j3uce1Hx4AH5JmQ6EvQpKp45Sy8b4 TaIXsVwmggbsZ9A5acCB5ukyupSl/pXBMGngvmsQE46i+Bfb24F/wymG4dIesuaN8RPc DsFg== X-Gm-Message-State: ABy/qLYAIlO1gwMICvpd+An4dHc6Y7XXwVKr4EaFQj/GJviXMaqwK5SU 19Eg+46345ifqcidvSNiuOYrAw== X-Google-Smtp-Source: APBJJlGsTHxAEzSXpONNRDxyKgcp4KNYdrSE+s2zmuMCZXMTXa7hKLkFVzAtadS71u0jqoE5bCgxyA== X-Received: by 2002:a05:6a00:194f:b0:680:2b80:8479 with SMTP id s15-20020a056a00194f00b006802b808479mr868615pfk.19.1690516421816; Thu, 27 Jul 2023 20:53:41 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:9314:7aae:8542:aa2d]) by smtp.gmail.com with ESMTPSA id d26-20020aa78e5a000000b006870ff20242sm212301pfr.186.2023.07.27.20.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 20:53:41 -0700 (PDT) Date: Fri, 28 Jul 2023 12:53:36 +0900 From: Sergey Senozhatsky To: Andrew Yang Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno , Sebastian Andrzej Siewior , wsd_upstream@mediatek.com, casper.li@mediatek.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] zsmalloc: Fix races between modifications of fullness and isolated Message-ID: <20230728035336.GL955071@google.com> References: <20230727062910.6337-1-andrew.yang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727062910.6337-1-andrew.yang@mediatek.com> X-Rspamd-Queue-Id: 321482000A X-Rspam-User: X-Stat-Signature: r3kw3dpssutjaw5616435m476n3t5jyo X-Rspamd-Server: rspam01 X-HE-Tag: 1690516422-512659 X-HE-Meta: U2FsdGVkX1+Yppo8nzirWNpPn0NN1WgkfPs4/WDMwg8jW3cNij1cTW5RxYF2gBH68EqRj6IbleRq5znM96kGFk4cqFobpqQFiHZ3fNsjUxBk21iV+kSqetXHIYCwlWK1CuoDoyMfOeNCfRnF83ye5dg6cC2jOasUZsCjEDwpwwVfYH0jFazyoFL20HTGW+zwQDe/R/jZWEx1B06g4c06fFPM6nwYalX7RFWF1RAHcUmBQUGK7TAhqxIqYe3XWyAZ66MZHdn2SKD+x6GZVU6T2+fj7u953ZKcWhosVp99/P9dW8bgctP7+W0w2puUnFnYt6d+0fwSXz3qzRvJc4z3TTPUv91B8yt20O4dnpMeoR19YH2CrGRCM1Hj2lHKS/+iPokC7EHOO+Gw6Cs/0jkh2GLiXNNz2Lb5ikvXVeiuJtAyZ9aXSYJCLTCBi/XRQB/0JsxAGGTsznBKwzorSLJtshzxn8Dw2JLcvG/0fwQWHHRgmEzJz+w9PCAwejAhOPvYdz1o6PeP6Mm0itM8z8wCkDHbJLPKgeQb2InD2yLa51rK+p+yhrqDWxBxZqDZClG8sgtTgiDShWipA7YhqX65zJn0uJrBXznn1jrJt9SstXNXCgGEgjbuC1glsBiDPMK4xpIGGDYQxPRFrjue0M5pybTri43wdTtk3ipCRyyTGqhz5lKlhvM036+APOjtuGrQWIw7+isGTFELlpl6zZ86IagwDqjd99PZu9iyz3++mcHRqBwJKAyeTQmdFVkoiFiBCkcXosXfFrrn9cU9fTWaby2dAu5a0Chv0Ay8dCXEEu6+xbYkC2eH0xImsGrFM9nB2YI3AEDDce6x490gm1tcDG5l/nr2GH1fQ2y3dKJi65oX2LPndZSX/vPphnNFgReX0k17k3XcgYeGjBF/nOlogU8/5xEumzYEYcwjYGYuz4307KVvllGv0EglY5sUkzo5wGhZltBG6cXp8EYt0hL aRoDDrVo 73r3sin+PG1kH411GaSpo18CAEET7J+rfD8hsTCgE+dBXYK8Qwyjw6Rmghwg8Wm3EF77MgBo7pmCzM9JcDQceQ+IQclYJm73WrlTguSdiWkVhJmvR7kQYFrWcXHAdK6bKC07sp/gAyuKCgSeKUKV7ZxUG/YVmEfdZgGA+iSpKGLOTRbCYTQlT4bjgFbhwqSyc9UI7Q4/dhytY9nxZWTVGP6FuXaUbVf05dbUttneqqRR9rMITiGGR+F46CGi/zcQGR8ZXV1PRgv062eXH4HwUayrJthMDKmyyORNnrF6Z2vTREjfzLlS8kNo+Efb5sIBldOeEmkN2Y7HIMVSFP4yJxQyBUQoIZRW6OvS7fBPzaY0ToQ2M9o5GS0VY958wwjTfSd2XBaEm87k1eV6soni9B4v+9XjRpqLHK/N//rYboJAG3pKubL4QxUL7DRBwM3iRVZuxqJ7Yh573Mq9mCgC61jwQvKpqAXAgoIciVp1HRUaroHXh5p4auYIrcqYus5gpdB85 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001805, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/07/27 14:29), Andrew Yang wrote: > > Since fullness and isolated share the same unsigned int, > modifications of them should be protected by the same lock. > > Signed-off-by: Andrew Yang > Fixes: c4549b871102 ("zsmalloc: remove zspage isolation for migration") Reviewed-by: Sergey Senozhatsky