From: Kemeng Shi <shikemeng@huaweicloud.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com,
mgorman@techsingularity.net, willy@infradead.org,
david@redhat.com
Cc: shikemeng@huaweicloud.com
Subject: [PATCH 2/8] mm/compaction: correct last_migrated_pfn update in compact_zone
Date: Sat, 29 Jul 2023 01:10:31 +0800 [thread overview]
Message-ID: <20230728171037.2219226-3-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230728171037.2219226-1-shikemeng@huaweicloud.com>
We record start pfn of last isolated page block with last_migrated_pfn. And
then:
1. We check if we mark the page block skip for exclusive access in
isolate_migratepages_block by test if next migrate pfn is still in last
isolated page block. If so, we will set finish_pageblock to do the rescan.
2. We check if a full cc->order block is scanned by test if last scan range
passes the cc->order block boundary. If so, we flush the pages were freed.
We treat cc->migrate_pfn before isolate_migratepages as the start pfn of
last isolated page range. However, we always align migrate_pfn to page block
or move to another page block in fast_find_migrateblock or in linearly scan
forward in isolate_migratepages before do page isolation in
isolate_migratepages_block.
Update last_migrated_pfn with pageblock_start_pfn(cc->migrate_pfn - 1)
after scan to correctly set start pfn of last isolated page range.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/compaction.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index ce7841363b12..fb250c6b2b6e 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2482,7 +2482,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc)
goto check_drain;
case ISOLATE_SUCCESS:
update_cached = false;
- last_migrated_pfn = iteration_start_pfn;
+ last_migrated_pfn = max(cc->zone->zone_start_pfn,
+ pageblock_start_pfn(cc->migrate_pfn - 1));
}
err = migrate_pages(&cc->migratepages, compaction_alloc,
--
2.30.0
next prev parent reply other threads:[~2023-07-28 9:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 17:10 [PATCH 0/8] Fixes and cleanups to compaction Kemeng Shi
[not found] ` <20230728171037.2219226-8-shikemeng@huaweicloud.com>
2023-07-28 10:30 ` [PATCH 7/8] mm/compaction: remove unnecessary return for void function David Hildenbrand
2023-08-01 2:53 ` Baolin Wang
[not found] ` <20230728171037.2219226-2-shikemeng@huaweicloud.com>
2023-07-28 10:41 ` [PATCH 1/8] mm/compaction: avoid missing last page block in section after skip offline sections David Hildenbrand
2023-07-29 2:23 ` Kemeng Shi
2023-07-31 12:01 ` Baolin Wang
2023-08-01 2:18 ` Kemeng Shi
2023-08-01 2:36 ` Kemeng Shi
2023-08-01 3:53 ` Baolin Wang
2023-08-01 6:08 ` Kemeng Shi
2023-08-01 8:01 ` Baolin Wang
2023-08-01 8:42 ` Kemeng Shi
2023-08-01 9:32 ` Baolin Wang
2023-08-01 12:33 ` Kemeng Shi
2023-08-02 1:11 ` Baolin Wang
2023-08-02 1:26 ` Kemeng Shi
2023-07-28 17:10 ` Kemeng Shi [this message]
2023-08-01 2:09 ` [PATCH 2/8] mm/compaction: correct last_migrated_pfn update in compact_zone Baolin Wang
2023-08-01 2:19 ` Kemeng Shi
2023-07-28 17:10 ` [PATCH 4/8] mm/compaction: remove stale fast_find_block flag in isolate_migratepages Kemeng Shi
2023-08-01 2:42 ` Baolin Wang
2023-08-01 3:24 ` Kemeng Shi
2023-08-01 3:34 ` Baolin Wang
2023-08-01 3:48 ` Kemeng Shi
2023-08-01 8:15 ` Baolin Wang
2023-07-28 17:10 ` [PATCH 5/8] mm/compaction: corret comment of cached migrate pfn update Kemeng Shi
2023-07-28 10:35 ` David Hildenbrand
2023-08-01 2:45 ` Baolin Wang
2023-07-28 17:10 ` [PATCH 6/8] mm/compaction: correct comment to complete migration failure Kemeng Shi
2023-07-28 17:10 ` [PATCH 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false Kemeng Shi
2023-07-28 10:33 ` David Hildenbrand
2023-08-01 3:02 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728171037.2219226-3-shikemeng@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).