From: Kemeng Shi <shikemeng@huaweicloud.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com,
mgorman@techsingularity.net, willy@infradead.org,
david@redhat.com
Cc: shikemeng@huaweicloud.com
Subject: [PATCH 4/8] mm/compaction: remove stale fast_find_block flag in isolate_migratepages
Date: Sat, 29 Jul 2023 01:10:33 +0800 [thread overview]
Message-ID: <20230728171037.2219226-5-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230728171037.2219226-1-shikemeng@huaweicloud.com>
In old code, we set skip to found page block in fast_find_migrateblock. So
we use fast_find_block to avoid skip found page block from
fast_find_migrateblock.
In 90ed667c03fe5 ("Revert "Revert "mm/compaction: fix set skip in
fast_find_migrateblock"""), we remove skip set in fast_find_migrateblock,
then fast_find_block is useless.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/compaction.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index ad535f880c70..09c36251c613 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1949,7 +1949,6 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc)
const isolate_mode_t isolate_mode =
(sysctl_compact_unevictable_allowed ? ISOLATE_UNEVICTABLE : 0) |
(cc->mode != MIGRATE_SYNC ? ISOLATE_ASYNC_MIGRATE : 0);
- bool fast_find_block;
/*
* Start at where we last stopped, or beginning of the zone as
@@ -1961,13 +1960,6 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc)
if (block_start_pfn < cc->zone->zone_start_pfn)
block_start_pfn = cc->zone->zone_start_pfn;
- /*
- * fast_find_migrateblock marks a pageblock skipped so to avoid
- * the isolation_suitable check below, check whether the fast
- * search was successful.
- */
- fast_find_block = low_pfn != cc->migrate_pfn && !cc->fast_search_fail;
-
/* Only scan within a pageblock boundary */
block_end_pfn = pageblock_end_pfn(low_pfn);
@@ -1976,7 +1968,6 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc)
* Do not cross the free scanner.
*/
for (; block_end_pfn <= cc->free_pfn;
- fast_find_block = false,
cc->migrate_pfn = low_pfn = block_end_pfn,
block_start_pfn = block_end_pfn,
block_end_pfn += pageblock_nr_pages) {
@@ -2007,8 +1998,7 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc)
* before making it "skip" so other compaction instances do
* not scan the same block.
*/
- if (pageblock_aligned(low_pfn) &&
- !fast_find_block && !isolation_suitable(cc, page))
+ if (pageblock_aligned(low_pfn) && !isolation_suitable(cc, page))
continue;
/*
--
2.30.0
next prev parent reply other threads:[~2023-07-28 9:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 17:10 [PATCH 0/8] Fixes and cleanups to compaction Kemeng Shi
[not found] ` <20230728171037.2219226-8-shikemeng@huaweicloud.com>
2023-07-28 10:30 ` [PATCH 7/8] mm/compaction: remove unnecessary return for void function David Hildenbrand
2023-08-01 2:53 ` Baolin Wang
2023-07-28 17:10 ` [PATCH 2/8] mm/compaction: correct last_migrated_pfn update in compact_zone Kemeng Shi
2023-08-01 2:09 ` Baolin Wang
2023-08-01 2:19 ` Kemeng Shi
2023-07-28 17:10 ` Kemeng Shi [this message]
2023-08-01 2:42 ` [PATCH 4/8] mm/compaction: remove stale fast_find_block flag in isolate_migratepages Baolin Wang
2023-08-01 3:24 ` Kemeng Shi
2023-08-01 3:34 ` Baolin Wang
2023-08-01 3:48 ` Kemeng Shi
2023-08-01 8:15 ` Baolin Wang
2023-07-28 17:10 ` [PATCH 5/8] mm/compaction: corret comment of cached migrate pfn update Kemeng Shi
2023-07-28 10:35 ` David Hildenbrand
2023-08-01 2:45 ` Baolin Wang
2023-07-28 17:10 ` [PATCH 6/8] mm/compaction: correct comment to complete migration failure Kemeng Shi
2023-07-28 17:10 ` [PATCH 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false Kemeng Shi
2023-07-28 10:33 ` David Hildenbrand
2023-08-01 3:02 ` Baolin Wang
[not found] ` <20230728171037.2219226-2-shikemeng@huaweicloud.com>
2023-07-28 10:41 ` [PATCH 1/8] mm/compaction: avoid missing last page block in section after skip offline sections David Hildenbrand
2023-07-29 2:23 ` Kemeng Shi
2023-07-31 12:01 ` Baolin Wang
2023-08-01 2:18 ` Kemeng Shi
2023-08-01 2:36 ` Kemeng Shi
2023-08-01 3:53 ` Baolin Wang
2023-08-01 6:08 ` Kemeng Shi
2023-08-01 8:01 ` Baolin Wang
2023-08-01 8:42 ` Kemeng Shi
2023-08-01 9:32 ` Baolin Wang
2023-08-01 12:33 ` Kemeng Shi
2023-08-02 1:11 ` Baolin Wang
2023-08-02 1:26 ` Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728171037.2219226-5-shikemeng@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).