From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACEAC001DC for ; Sat, 29 Jul 2023 20:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E8918D0005; Sat, 29 Jul 2023 16:37:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 897228D0001; Sat, 29 Jul 2023 16:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 710EB8D0005; Sat, 29 Jul 2023 16:37:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 630D68D0001 for ; Sat, 29 Jul 2023 16:37:42 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2C204140684 for ; Sat, 29 Jul 2023 20:37:42 +0000 (UTC) X-FDA: 81065810364.02.84B4B05 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 7D6DB2001B for ; Sat, 29 Jul 2023 20:37:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UyYSf2rL; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690663060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LNXZOYVbCHsualccFqzRqzpRLiqhfT1W4JZoiRNqVK8=; b=lpv3qrm/pdbMrZCNZmqJJ+Bqkc+zfBQwdv8mvXNBuK5FYXlAudCAoKknrwRJxiqOlib2ib ophtNdXWstMRkqj2CQ0laJgRUbKDR3/m3rvqR98Qcx5ozHL3xPtnPaHwnZNGW+bp0Y/NUb AwdYDJc8vo5uXadtyyIJXpB0YkVlqig= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690663060; a=rsa-sha256; cv=none; b=vqDdHGWszsAFN8kmV78xcpXpo8fpdmTv1dirEa7UaZFBpmGrW9f0FNvImTgl/g8r6AQ8/0 OVf/zHOJ3QhbTUJpoivSF9qpyXAe94JOkYe+uLb0GmZ7loCecXIDAbN1cjh+QdiGs6AUnF hPZmmDIYRql/sJkh7r/yRmiygiFd6TM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UyYSf2rL; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A998560AD7; Sat, 29 Jul 2023 20:37:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76B03C433C8; Sat, 29 Jul 2023 20:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690663059; bh=YPgSpddY9t4io6ikXCAUlDHPpj8ulBukto96IBJDPnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UyYSf2rL2uLdPSrcPn4/N9GQkTxV2zBIT8nd/j+Pzf7IOWlL0PseartNH8Cn0JhVZ COd+atrvWOy+pR5Xj10r0PicBAH309HUuAWue8TI+VqsKvXlV/1j5hjW/IJwfzhjsJ wV/VG0X1OD3dUfsEC1DHpVRHoKSAsqBmBBZUq2c6b55yGCMYY7xgXL8VF9fvAcRam+ RdZEJzlrf/XHTZGqM8gvZZPBzuogVfCrwuWJPElLFGLb5X+WwtAd2KwiZfAL/lRcp3 f1eCVHWjTgJVP6BQ/P/aJT8bfaoszMfOqWxMO0UQDiVLvKEaeMfWs9vucDczB2xF5O wJb9IiQv4jIZQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Brendan Higgins , damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] mm/damon/core-test: add a test for damos_new_filter() Date: Sat, 29 Jul 2023 20:37:33 +0000 Message-Id: <20230729203733.38949-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230729203733.38949-1-sj@kernel.org> References: <20230729203733.38949-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 7if6r34oqxt6mqp1wuayz5kc1ud3taa4 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7D6DB2001B X-Rspam-User: X-HE-Tag: 1690663060-883448 X-HE-Meta: U2FsdGVkX19sy2Vf9UPCVr2xY21XKxLjoVwpgFJ07VGbzfUUmUwlQlguJsi7qb5yQbv8tjGX4CoofGT0vwNxB/y1/9SsgjRW8Nt9ST/V7bqikQrvBptLNHfOiFv2JOJFzR6etWnkKZVo7wfWVIZ4OrYhklJ4AUIJ/86dVWPRDZDZvn5z8Y8GovUoFJxLRRWbeOkmQ+QEljz+8nV6RcKNVrnteF2LPL7KCjA9m4AYQogxvrbqxyHokDFoX+EWEGdBdCwg0K5RUg4N7CdQgcR1ws4h6WgF0JxqJ072bJAaMf80TlodlKQlyo3z+wDI93KEg6Eyu0r9pyJ5fCLopTg2F8Gjby36QIpzvE9UEuSX9ps+HcaTvB1v4lur/xALUlnWkViL/oDV5h/wmVHmiWY5dZ7ZHKF4wlSTL5NJkn73w1U4bkjMoMhHlpAlPNddv0tMWWudHsG6yivlnUjL3sFfb2P3uHexNOwWPs93LrKCSB1i07kpaMZwVzMePNE1Xl9/qvp/DksqEEHjlqgpOeo4NPV9TEYsDAfh/x1fZEBCkuTXfUt3o3CaB4WNCeIwmSpnwABiGZDKgL7ortv0jP6ftNH1mgWda/wvt1iIKYmSaeCHMtVdCqertRhu4SeUBkcqDfSI4b/PoeLjWEO0W+Aw17nTGPALKBTILlOcBVMq/quGjMKTrH3Z+s/YtrkyxWVaxwnhMdIYoSy+nC+/vKZRQCWYsM0B+OWrTNCLF0sFK6Gcrz/oUpgynAE6un6IvvURh2E2Cgz80pLgq0Rp/QUX5RcCPA6pxgUTSS8UiMRRMheES4Wute37nc+azb+lUYUT3A9JtXGvlJ6V7wWHyWHj2g1u+Hp1qbkZ0jdvqMNggAxrPTgOriuPcOJT4SNgAUzrFQYTbis5LFibly/72BvDTPkSegLXvnofyxUJXURyv7C0LCpNQ1PGWUPDr86u8w0392H+KkyCohTQlyWU89c RyH8Mswr lAWBbCA3dY0DFFfeV1puj6TXCkxHurfi0Tf9JR0QxuPNQXs/R25CJXh95MOFillLMJU2SraclGWdvOBhveTWyxSBRvCify5Gy8axZ1EHfMn9gNj0sa7FNkElLqL+CZEmysLpoRzJq2Yjve+vIujsEGs71d7EZVaxhTtfYD1m2NoOraNtKfHVO4xFPe6oWK3R9jdRL/WrUD2O+9Loc7hpoRnarSxNFm9hq2o3kTGRRhbkxcSjIaAkfGh032Jdk0TFb51dLlYAG2IHCQW3ZyfEoQuZU3UCSvPfagJAMcIqZRxQCtEWh7LTSSa+cRjHcBOk20SrJVZ4zLbfz9G1ERQAZ1Iq9RRID3DLDlaYDEcUQiEYi7C5kqx1yQTM71MyJJL/fQnqP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: damos_new_filter() was having a bug that not initializing ->list field of the returning damos_filter struct, which results in access to uninitialized memory. Add a unit test for the function. Cc: stable@vger.kernel.org # 6.3.x- Signed-off-by: SeongJae Park --- mm/damon/core-test.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h index bb07721909e1..4bddbfe243c3 100644 --- a/mm/damon/core-test.h +++ b/mm/damon/core-test.h @@ -341,6 +341,18 @@ static void damon_test_set_attrs(struct kunit *test) KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL); } +static void damos_test_new_filter(struct kunit *test) +{ + struct damos_filter *filter; + + filter = damos_new_filter(DAMOS_FILTER_TYPE_ANON, true); + KUNIT_EXPECT_EQ(test, filter->type, DAMOS_FILTER_TYPE_ANON); + KUNIT_EXPECT_EQ(test, filter->matching, true); + KUNIT_EXPECT_PTR_EQ(test, filter->list.prev, &filter->list); + KUNIT_EXPECT_PTR_EQ(test, filter->list.next, &filter->list); + damos_destroy_filter(filter); +} + static struct kunit_case damon_test_cases[] = { KUNIT_CASE(damon_test_target), KUNIT_CASE(damon_test_regions), @@ -353,6 +365,7 @@ static struct kunit_case damon_test_cases[] = { KUNIT_CASE(damon_test_set_regions), KUNIT_CASE(damon_test_update_monitoring_result), KUNIT_CASE(damon_test_set_attrs), + KUNIT_CASE(damos_test_new_filter), {}, }; -- 2.25.1