From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F59BC001DF for ; Tue, 1 Aug 2023 12:48:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CA6D940011; Tue, 1 Aug 2023 08:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 979BC940010; Tue, 1 Aug 2023 08:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86830940011; Tue, 1 Aug 2023 08:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 76338940010 for ; Tue, 1 Aug 2023 08:48:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 490241C9066 for ; Tue, 1 Aug 2023 12:48:58 +0000 (UTC) X-FDA: 81075515556.06.4C64A96 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 7AABF18000B for ; Tue, 1 Aug 2023 12:48:55 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W3mkAxeZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690894135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=RHFvfXcP0yrcIaYOdQEvaIRqqVbMZney2Vh1PcaD7Io=; b=E+TZJv5D8uWd4GeNy3px6GXMZyJGVYEeoU+HMExESMaNxS/F0bbK5HYqun9bz7HwTkH+bX 5qfZBe/oP7ijrrCHldwX5D+vk4MJfZ72Llg4kzqGDKSrRNFFI5/t+ThGOAfoj+vfeJRN+y WZI1lUlbL2KV4JL6/x7yy/Fzw1INI7E= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W3mkAxeZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690894135; a=rsa-sha256; cv=none; b=bobwA7VHKt4qT3WgBpLhORKuNXY6r6Du8SIaLgFIjZRkJZ5kwg5rQkH+YuIYFlsonXDthG fKp0aAoIzNg5amGpilQgjcpODIyZIxXOuHzL1N8z+BDd7ifyuuUsqRDFo14ZKaETpw9LBr C9RMqePyYtSf1JxrizeMDHRjcDnA5ms= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690894134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=RHFvfXcP0yrcIaYOdQEvaIRqqVbMZney2Vh1PcaD7Io=; b=W3mkAxeZWOeZ3UlklGmbIDgoiXzjwmb9GKjN3dkT/bMUROwk//mtdNSoP6gWsLGd9Vk8qj GFbcFAPyv1ypl+UFJI1qMxZmzz/AFHJ5fhyorjGh4HzS1O4QFCOJk9HUVc10ZrmKNkqM4L 9XRWd/ony4A37gsX7IL7Kpxu/0oIEO0= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-46-92PRgIToNqSHCN5sbvkKmg-1; Tue, 01 Aug 2023 08:48:50 -0400 X-MC-Unique: 92PRgIToNqSHCN5sbvkKmg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8876C3C14AA4; Tue, 1 Aug 2023 12:48:49 +0000 (UTC) Received: from t14s.fritz.box (unknown [10.39.193.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id B7B1EC585A0; Tue, 1 Aug 2023 12:48:45 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, David Hildenbrand , Andrew Morton , Linus Torvalds , liubo , Peter Xu , Matthew Wilcox , Hugh Dickins , Jason Gunthorpe , John Hubbard , Mel Gorman , Shuah Khan , Paolo Bonzini Subject: [PATCH v2 0/8] smaps / mm/gup: fix gup_can_follow_protnone fallout Date: Tue, 1 Aug 2023 14:48:36 +0200 Message-ID: <20230801124844.278698-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Queue-Id: 7AABF18000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 5xqoo11i5tkh56nsnthowcaosa7e4aph X-HE-Tag: 1690894135-301229 X-HE-Meta: U2FsdGVkX1/0gr4p4GPCN9hIkE50nyDcSsL8laQEySydVjb27ngzrZOZ0iCDYXCAPu8LdmxVgFwZ9qk4gLCfBwVjgylnPot/qfXyCQjeBkZf2l1v/Id0AvynCEun5iT2JOTGYekDrj1XF7yAvtaIDPn/zW06LGfOSa5t/45IFBQGoIyBbFwCYhDpA1V81fONowpmLY5t7XPpotCGI47acN4seFzqZUHvsxDxH3U5h7CzqE4POcf+7ApEGQFabWTqNUr8Kf+CVrBV/OssTizkAmXMMx4UMqJDHjWZbsTqfDCDd/UgKqljs5Ba8wrN28kQ37DffzvvWnj48VoMSQ34KqEEp9LrscHtw65IshQ9wJHGc3BACw7HeC6KAkL7DrCsD0l0EbPCwurp+Aju/bTR4t3VMNVhd0G/gCM7H//IrfawA+Tlm3PrdHO7sTeblj3w8Yx0W83B+/TYaNEmcvpwM9jsJ0VTNtieE/jMCPNUDBZkwzBGXTOOQ2EpUONfi2b9xoGFVgkt2AJ/9CvvuJmxRY7JVLymLOLJ4SL+HKj1vbKEFlGqc3eMvOL8nmeZh/YHIWL39HEH/Oq9nG3JeJXRbdXEepMJ/mgsQetPIOvQTMK32oOuPomQOxeL29izvdUhWTh/iiLTauFDUPKpSNUGMs+6WPXMgl9YekLv9zZcszc9CAtd1iP1/LMDLrtflFscRKN/kRMHni8zcXI5kJ6k717TVBv/a1qs5uq/8DRwXyu9YRgKi+MCiOj0MZIIp5srBhlfyRYMBoL6WudaFjf6fvd6YAJzJnZXmUSsLwoCXGlbB9+CCiBAmr18ELl31KIrsXY+2iifdm4eZnWre+wPs0Q7dVTqvw2xSekrZaOUQbQseo/T0fOWzPsQqWtSZHDY2VuOpJTGZNQjGz5XTBmqOXSxYCmWVG9Ff9EOC92CyNr8FaN7ATANOPkwIrMsTFNaCA2ZlnStSGtGboqUJBV BfttHwOV qqCFkS/cjDVUkDMPEFckyb4bNO8ofSwdc4d8rjKEpU/l1Esl9eHhlbwpa5csHW5zUyeEm+h3w8sB7lugRd9YKeXbcktmHmI1TGoVVUHgz9REinY0Ug5Mip94ZeejMlJjDaOfU280Cc+HUbyuBnfln1DhAupL9GqFfhl4GTlePlP7LB0ZGgx56ut3Ybcv5vWsDzcHahBSNsxhq66EdctK73dNr1t+KK4Aspjt4FtuNiQvM50hUpIcHnow2wVnMoWZIZz4cdvAK3SeyhMeaBnOJeTf2NxbcGEizDITM3H8RTVEH0wlAMGGd7ijesq8hu2k/sK0OZ8xr0h+0reDnwjxbL9dMw9RO88owEyLPc1u8/sG0erBKQNOP47+zS904U+/ISOkPq5hPxgrCvz/kPJrZREqi3rn2Ei2AK+lYlcNT2Z381NXg9uuf9KmmW11xRVQbrnHhoWLJP/sCTQ5dgcP9CnRupObMskj0hB5Qx1zux0w8suRDR6aJsRMAb1ja3n1b+hZw1tjPlR1R9WViVaPXWHuJQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is agains mm/mm-unstable, but everything except patch #7 and #8 should apply on current master. Especially patch #1 and #2 should go upstream first, so we can let the other stuff mature a bit longer. Next attempt to handle the fallout of 474098edac26 ("mm/gup: replace FOLL_NUMA by gup_can_follow_protnone()") where I accidentially missed that follow_page() and smaps implicitly kept the FOLL_NUMA flag clear by not setting it if FOLL_FORCE is absent, to not trigger faults on PROT_NONE-mapped PTEs. Patch #1 fixes the known issues by reintroducing FOLL_NUMA as FOLL_HONOR_NUMA_FAULT and decoupling it from FOLL_FORCE. Patch #2 is a cleanup that I think actually fixes some corner cases, so I added a Fixes: tag. Patch #3 makes KVM explicitly set FOLL_HONOR_NUMA_FAULT in the single case where it is required, and documents the situation. Patch #4 then stops implicitly setting FOLL_HONOR_NUMA_FAULT. But note that for FOLL_WRITE we always implicitly honor NUMA hinting faults. Patch #5 and patch #6 cleanup some comments. Patch #7 improves the KVM functional tests such that patch #8 can actually check for one of the known issues: KSM no longer working on PROT_NONE mappings on x86-64 with CONFIG_NUMA_BALANCING. Cc: Andrew Morton Cc: Linus Torvalds Cc: liubo Cc: Peter Xu Cc: Matthew Wilcox Cc: Hugh Dickins Cc: Jason Gunthorpe Cc: John Hubbard Cc: Mel Gorman Cc: Shuah Khan Cc: Paolo Bonzini David Hildenbrand (8): mm/gup: reintroduce FOLL_NUMA as FOLL_HONOR_NUMA_FAULT smaps: use vm_normal_page_pmd() instead of follow_trans_huge_pmd() kvm: explicitly set FOLL_HONOR_NUMA_FAULT in hva_to_pfn_slow() mm/gup: don't implicitly set FOLL_HONOR_NUMA_FAULT pgtable: improve pte_protnone() comment mm/huge_memory: remove stale NUMA hinting comment from follow_trans_huge_pmd() selftest/mm: ksm_functional_tests: test in mmap_and_merge_range() if anything got merged selftest/mm: ksm_functional_tests: Add PROT_NONE test fs/proc/task_mmu.c | 3 +- include/linux/mm.h | 21 +++- include/linux/mm_types.h | 9 ++ include/linux/pgtable.h | 16 ++- mm/gup.c | 23 +++- mm/huge_memory.c | 3 +- .../selftests/mm/ksm_functional_tests.c | 106 ++++++++++++++++-- virt/kvm/kvm_main.c | 13 ++- 8 files changed, 164 insertions(+), 30 deletions(-) -- 2.41.0