From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E099C0015E for ; Tue, 1 Aug 2023 17:19:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 931DC940031; Tue, 1 Aug 2023 13:19:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E28F940010; Tue, 1 Aug 2023 13:19:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AA6A940031; Tue, 1 Aug 2023 13:19:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 68B68940010 for ; Tue, 1 Aug 2023 13:19:42 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 18E3B160960 for ; Tue, 1 Aug 2023 17:19:42 +0000 (UTC) X-FDA: 81076197804.08.C42AB3E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 12B94C07FC for ; Tue, 1 Aug 2023 16:54:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BIFlmOCq; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690908845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GF51qDy3GiWR/nYZI9t++wsOCQB+tJwaD717HhTgEtg=; b=R3MD6lgxBHOcFKz9/bpVLkQaOx3t8weJlCo/XHKCyPkH7hEJKhW2feLisdsOL7pbv9jtQG JpGWtgy9c/A35gpGw94Y2MD0VwOZ1idcHIDZOo7+4guqJSmCRbC0JUlkin8WNU6m32McWZ zYsp85ZnPZP2+gAvia8GWVpuGp5mo5M= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BIFlmOCq; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690908845; a=rsa-sha256; cv=none; b=lmjHuKFRuzw1dN0DIBBTi/wavprWigfXSM5ej9tIrpj2+8sgFJEvpz9PZ6YfE2tXIMqzIX uToCVgnxvqQ8DpRzY7lCtHR+GKAwxgDdS2uslru1MSZx6uPcd+kRKg8UXnzjtTomGHiNJn wnSnNPl/SGMLA9oT/+vmDBE/lD2LVKk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2756E61638; Tue, 1 Aug 2023 16:54:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE3C1C433C7; Tue, 1 Aug 2023 16:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690908843; bh=liMpSScDu0h+PrjpmqiYb+Q+6aHOwyISw4j8BFIcGVw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BIFlmOCqJS8iQcXvk8oNZxNGz4QNLszdREetAXo8Uo+jxPN2dAxboF2ywOt+r6sF4 1Ce2+7VJBYSGs32seKXUp9myi6IuJy6hA4JORLtRMmgg1V/NnkE6s5/mCkx/yY5eSx hJeilqNSHkRQUd3TgjbR5C3RqdbDv1v8l8q/HRJ5d4R42KAnIGAb5tXRn9g5WJ8qqo mDEv5+Zw5cXJgVkudwVKqN6SYARTjqDZCN6holglfEyaqBXFe9dSofXvT6coPEOgpA xj+s68tMRVaVcMe1Q2cVhtEHL+1/z/BwX05ZAZfo29BBJ2ZA0XJP5VyrA4HxSuC/Yz troFt3trmDEBw== Date: Tue, 1 Aug 2023 19:53:12 +0300 From: Mike Rapoport To: Mark Brown Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 10/36] mm: Define VM_SHADOW_STACK for arm64 when we support GCS Message-ID: <20230801165312.GB2607694@kernel.org> References: <20230731-arm64-gcs-v3-0-cddf9f980d98@kernel.org> <20230731-arm64-gcs-v3-10-cddf9f980d98@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731-arm64-gcs-v3-10-cddf9f980d98@kernel.org> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 12B94C07FC X-Stat-Signature: bsdqxjqeddi483ah59fwd8r3c4drje8n X-Rspam-User: X-HE-Tag: 1690908844-991707 X-HE-Meta: U2FsdGVkX1/OKJxU//pgPSf6meb1qyYb3VzlmHz1Fwf/4XSI0tfrdi2ZAGnR9ovMkkoWY4zT8rUyOFYMKRAfaZA00y8E47BFP3hX8IJ7o0XeW5MOk9vpE2WtKyT4KU226ZrI1nm1nd2TC2rbikcaNItq/nxEiLbPRYUH2f3lFFa9epP34ym/U4Cq2IN78gaB6XbGGvYbX3/jLPNiRaBUTJVH/BMqrKqaqx4R9vECANu866kvb1mIPuv+6APcjT6HrMXDzHd0YaTdhxy06KH521J2Mr+vyHG0jDejcNdJ6XdJo/iEd1KZKy8wOXYKB9t1kPuFcqqtKi/dao8BC7dzNlUNUfej3FUD1YUtnZXXDWNXpTu/Ogg3bBqUM45kbA7mAkjrWSXGc+YJ407k3biB8NpNdq5tYiTlUEI8ZvokyCB1SuABsZ/bGLetttJSFbN1HymregjqR7/S8Tu5D9v0nGPwC97Q4HqNh7jgZq/tkyFbHtMhe4bsBjqQn5nY+bWROVaebU3OaUB7j23MaW3paoRL/97xOGRmZQomZlqW5D5wqDolW8UOAn1n6cbj9KkCHIJsdIBhMVFDrukwvlTPuYJwxg+1c8I78d1fTmswy975TG2fB0YWLPt4yZ1KaHsjdUMc/Q4ch0diPPMJDmUsSPySMHGR32jROey4hn5JT77EfsNVxQVf80wQLHOpIJL2+kYfOobvaSWEgwmWBrwnYQ88Rbq8H7R2RMsUy5wJVac+6B/Xrz/IkpJVOneKb67EgD6NUf+NeMbaj6zMSoAZSYczsQuxoMDcketumG4mSUzMWIlUaReNQgdmP8FJ8uNYmK3IF4pws86tCkPOwNd/gRZPL/2v8Cf0QFTQIL61j84F8rsyv38ZCZJl34y+YD8HzypuZnKy59a8cdcZroBpeP0seJjpAK/oL6F3GwrlHNHNRCn2m4w5n1VrWh06EFsjZFtODwaTQQYYvIm9nfS KMEAHUUx 75Z6tYXjREBKyDqC2WlkgTSY1zfPVer5iwJyoc6juR2u0CK/gk7w0G75J/elXM7wT37Ixac9cQUoAuPDUtcAtKZjquWly6GOji/dgZ8PrALzvxSRT6bN9oIdXw7FRQ+qbpPvZENnF9jmFb0o8S4j/CemN7Q+64Vi+kayrazNiuRKZ3O6Ap/3BSvngzryl8yKPuSILHG31VdBnRd2l9gqeWZl0VF9/YYsUeCVlr38CBstYv4oF6x/5Ov38s/bZ3mWJxUhDh6rBJjiByVfWnWAr0XSkDAuAGTwWw4qO47DH/KPnNyHoNMZrtH5IUNrxyqOIhsk2y947+6WNDCEsSjvkd5Mb4i+GZFmzl0tVLlLKbGqrhA1t+deZsgP8cjLsuUCTx+KRa/JVIEPverHb8rdvegZyATEeTUexSkDly+YI8QRyo/oWNbBqXoKoeBlgD6Ppk6TOg/J8Ux1QpmwqOxCCGQ1H+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 31, 2023 at 02:43:19PM +0100, Mark Brown wrote: > Use VM_HIGH_ARCH_5 for guarded control stack pages. > > Signed-off-by: Mark Brown > --- > Documentation/filesystems/proc.rst | 2 +- > fs/proc/task_mmu.c | 3 +++ > include/linux/mm.h | 12 +++++++++++- > 3 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 6ccb57089a06..086a0408a4d7 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -566,7 +566,7 @@ encoded manner. The codes are the following: > mt arm64 MTE allocation tags are enabled > um userfaultfd missing tracking > uw userfaultfd wr-protect tracking > - ss shadow stack page > + ss shadow/guarded control stack page I've missed this in Rick's patches, but it's not a page but area. > == ======================================= > > Note that there is no guarantee that every flag and associated mnemonic will > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index cfab855fe7e9..e8c50848bb16 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -711,6 +711,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) > #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ > #ifdef CONFIG_X86_USER_SHADOW_STACK > [ilog2(VM_SHADOW_STACK)] = "ss", > +#endif > +#ifdef CONFIG_ARM64_GCS > + [ilog2(VM_SHADOW_STACK)] = "ss", > #endif > }; > size_t i; > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 43fe625b85aa..3f939ae212e5 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -372,7 +372,17 @@ extern unsigned int kobjsize(const void *objp); > * having a PAGE_SIZE guard gap. > */ > # define VM_SHADOW_STACK VM_HIGH_ARCH_5 > -#else > +#endif > + > +#if defined(CONFIG_ARM64_GCS) > +/* > + * arm64's Guarded Control Stack implements similar functionality and > + * has similar constraints to shadow stacks. > + */ > +# define VM_SHADOW_STACK VM_HIGH_ARCH_5 > +#endif > + > +#ifndef VM_SHADOW_STACK > # define VM_SHADOW_STACK VM_NONE > #endif > > > -- > 2.30.2 > > -- Sincerely yours, Mike.