From: Christoph Hellwig <hch@lst.de>
To: Pintu Agarwal <pintu.ping@gmail.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Pintu Kumar" <quic_pintu@quicinc.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-mm@kvack.org, m.szyprowski@samsung.com,
robin.murphy@arm.com, iommu@lists.linux.dev,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Liam Mark" <lmark@codeaurora.org>,
"Laura Abbott" <labbott@redhat.com>,
"Brian Starkey" <Brian.Starkey@arm.com>,
"John Stultz" <jstultz@google.com>,
"Christian König" <christian.koenig@amd.com>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v2] dma-contiguous: define proper name for global cma region
Date: Tue, 1 Aug 2023 19:18:38 +0200 [thread overview]
Message-ID: <20230801171838.GA14599@lst.de> (raw)
In-Reply-To: <CAOuPNLjnfq1JefngtNrg0Q+JdMTSRz+eEqxGQJFfx9+af+k9WA@mail.gmail.com>
On Tue, Aug 01, 2023 at 10:42:42PM +0530, Pintu Agarwal wrote:
> > I agree that reserved is not a very useful name. Unfortuately the
> > name of the region leaks to userspace through cma_heap.
> >
> > So I think we need prep patches to hardcode "reserved" in
> > add_default_cma_heap first, and then remove the cma_get_name
> > first.
>
> Sorry, but I could not fully understand your comments.
> Can you please elaborate a little more what changes are required in
> cma_heap if we change "reserved" to "global-cma-region" ?
Step 1:
Instead of setting exp_info.name to cma_get_name(cma);
in __add_cma_heap just set it to "reserved", probably by passing a name
argument. You can also remove the unused data argument to __add_cma_heap
and/or just fold that function into the only caller while you're at it.
Step 2:
Remove cma_get_name, as it is unused now.
Step 3:
The patch your previously sent.
> You mean to say there are userspace tools that rely on this "reserved"
> naming for global cma ?
Yes.
next prev parent reply other threads:[~2023-08-01 17:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 18:08 [PATCH] dma-contiguous: define proper name for global cma region Pintu Kumar
2023-07-29 2:35 ` [PATCH v2] " Pintu Kumar
2023-07-31 11:21 ` Christoph Hellwig
2023-08-01 17:12 ` Pintu Agarwal
2023-08-01 17:18 ` Christoph Hellwig [this message]
2023-08-02 5:39 ` John Stultz
2023-08-02 9:47 ` Christoph Hellwig
2023-08-03 17:34 ` Pintu Agarwal
2023-08-09 15:04 ` Pintu Agarwal
2023-08-10 0:57 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801171838.GA14599@lst.de \
--to=hch@lst.de \
--cc=Brian.Starkey@arm.com \
--cc=akpm@linux-foundation.org \
--cc=benjamin.gaignard@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=jstultz@google.com \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lmark@codeaurora.org \
--cc=m.szyprowski@samsung.com \
--cc=pintu.ping@gmail.com \
--cc=quic_pintu@quicinc.com \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).