From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 288B8C001DF for ; Tue, 1 Aug 2023 17:29:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B849494003A; Tue, 1 Aug 2023 13:29:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0DFE940010; Tue, 1 Aug 2023 13:29:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B0FF94003A; Tue, 1 Aug 2023 13:29:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8C460940010 for ; Tue, 1 Aug 2023 13:29:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D4947140587 for ; Tue, 1 Aug 2023 17:29:42 +0000 (UTC) X-FDA: 81076223004.22.0DF63AC Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf19.hostedemail.com (Postfix) with ESMTP id C658D1A174D for ; Tue, 1 Aug 2023 17:18:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=none (imf19.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690910324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C57z3+ALmVghC6KE2CxzaDK6hyEsOy6F2VQhKKi7K4Y=; b=VDmPxw7b8KP2yPjCI2SBwo7np6nNLuU81Arj2yHvvOHH3y1xfoo3/nBzly26B2i/NVM/FR v+5ju3ZxydX4lHmgONqzhIlfwANvKZE4A62O5+2W/DWu+yMhhesZ8fSvozXBt99qgm7poq PugfdWXO8OWodGFNLgaMYLmDxLWoiz4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=none (imf19.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690910324; a=rsa-sha256; cv=none; b=zOhV5HiV5D7C/VvOsHn2kz255IyOL5haTexClHh0OLeZ9k8uB2sOqqZ2iwSbnba4Uc6o9v ajSEiq8Vj5co5wdApQpr+ZP6qyCcxVTaU4MkcBkdfdTYupdqGMMXD4Qs6xEQg+8mLxtGEA 1YApzykcoyLzx64qK2uwZLNkh8CwaWo= Received: by verein.lst.de (Postfix, from userid 2407) id AF5E46732D; Tue, 1 Aug 2023 19:18:38 +0200 (CEST) Date: Tue, 1 Aug 2023 19:18:38 +0200 From: Christoph Hellwig To: Pintu Agarwal Cc: Christoph Hellwig , Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, m.szyprowski@samsung.com, robin.murphy@arm.com, iommu@lists.linux.dev, Sumit Semwal , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , John Stultz , Christian =?iso-8859-1?Q?K=F6nig?= , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH v2] dma-contiguous: define proper name for global cma region Message-ID: <20230801171838.GA14599@lst.de> References: <1690598115-26287-1-git-send-email-quic_pintu@quicinc.com> <20230731112155.GA3662@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: C658D1A174D X-Rspam-User: X-Stat-Signature: y4hnkmjh6j9pn34iat59ega8umtye349 X-Rspamd-Server: rspam01 X-HE-Tag: 1690910323-146009 X-HE-Meta: U2FsdGVkX1+Rbt1EhR1YwwR5M0c2XGDg2S0D9RPhSmokLD4uzbj7+dkNYPnr8mS7K3K/n9q0GroJO9stkYcgp6u4/gGhw9p244GYhl13YWCBjJ1Gg9utFePcCjm+b8raCrrqLt49E+xJ/AjDZdd6o0FK6duIX4j2I7SrWCMkUkh3j54bfGLof17Pr2WJvmYt8W0VM6ipCLmzJoC0GDoR0AYtKNIT2ohy4shk0sVNWpA2Rml+RRBvHIcqaicdG3TAL5pzPF3zdD7TyxyokSNBQB7AueM+siG7tnlb3SMoDUKz42flnHVPsMkxsINucju7axno6zjuqfCnBm9M/I/fAxBF2jvpU4Sk3xnl+HwRQHd8asX4R8gM5iaMWrn1R7RW0LmAIx1CwtLIVDuLkZ9nR8pRzMahtEuGzzGauDrJxTQ9Az6UNypYgbrfC5kVmUuj9rBk5IvZ22SFFGsCwyEj8iI9PvsGcl4fiqyxpkWA1tBOQSSQSCNDADcT3UnYkl7yN9XjQzELAoyQhBbYE2H4RNYLYV1j9KLGJBqf2B8QZT0mUkkAtGrosTPcxgmor6PHrdApNo5ZfHZZcw3G7cbdKey0Tl1BKS3QHjY+1PY3sE3rB8UZSGCTYr87y8C09iUXn2s1VVY79GXx6bXgOhnELNmY7nrKs6SMxNGGzLXKid5XpBILi9kRi31Dcm7zDrQ18jXH1Bmb4/w7EHr1/zsxAVrORcX8vHfeNQe6cy34sS1ssPnF4/jRq7pDicbcMtkxxLOedcjegqmGf+3ICkAxmxg2WAW4x9FzKFM1nMC7xm6I7K/TFyKxZh+DE//X2Ft0+USHZJChIslXiuPUw0CUcs25rKmShG8iY263p4RbKHGEwnQZTQ1yrBdhoX310f0Vap6ElAQg1J6IqvqVsXdGwUkrSmKDJsLaVW7HRXjLQ2qOro8dq6fzooSuDJ2UD+JuEl+gMzQkmeoY2aytz39 j1rxQ1ye yzktVqwHZ5fPvF/RAs1g4XsqWDkQC5dN0t8IR/ikzMjunUFzVO4LgPoL7vqxk67tp8hmuwFCx4J4T85DT3l1uj8V+YBW5waPtTAoRoj2ABL3jbULaXf8WKyPic2kDY6gLNvRi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 10:42:42PM +0530, Pintu Agarwal wrote: > > I agree that reserved is not a very useful name. Unfortuately the > > name of the region leaks to userspace through cma_heap. > > > > So I think we need prep patches to hardcode "reserved" in > > add_default_cma_heap first, and then remove the cma_get_name > > first. > > Sorry, but I could not fully understand your comments. > Can you please elaborate a little more what changes are required in > cma_heap if we change "reserved" to "global-cma-region" ? Step 1: Instead of setting exp_info.name to cma_get_name(cma); in __add_cma_heap just set it to "reserved", probably by passing a name argument. You can also remove the unused data argument to __add_cma_heap and/or just fold that function into the only caller while you're at it. Step 2: Remove cma_get_name, as it is unused now. Step 3: The patch your previously sent. > You mean to say there are userspace tools that rely on this "reserved" > naming for global cma ? Yes.