From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 841A4C001DF for ; Tue, 1 Aug 2023 18:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 258232800EA; Tue, 1 Aug 2023 14:13:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22EEA2800C8; Tue, 1 Aug 2023 14:13:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D0DD2800EA; Tue, 1 Aug 2023 14:13:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EDA0B2800C8 for ; Tue, 1 Aug 2023 14:13:50 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BC9DC40D03 for ; Tue, 1 Aug 2023 18:13:50 +0000 (UTC) X-FDA: 81076334220.04.FDA865F Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf03.hostedemail.com (Postfix) with ESMTP id 3DF1E2001B for ; Tue, 1 Aug 2023 18:13:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=EG3k5D0X; dmarc=none; spf=none (imf03.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690913629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WCvORc63Xc/jlm9uhOtZxAQJTdnogdSx3B9Dg3F/tt8=; b=YCEdEM3qdPiRQ17LD7QGROlci5gwIN6K+sKdeoJ+2SyMJMF7VFP3UMXe3DnYPmS3J8voUD ogqtHj+UX5qdV8WmpDMkLXcMSSz9BSeRGeRuJm9v9XHS14nHPkgD4CQIBrRb3Hbk/yFiyH SZplcwlwS5hIM7SXuRCBBUYuv9rKea0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=EG3k5D0X; dmarc=none; spf=none (imf03.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690913629; a=rsa-sha256; cv=none; b=vAgaWjXfi86g9Wxd9DpL7p1iYTuvlpYK2krlcbs2sC/AfV6pZHw7kjQxruOQx/nKMLURmg 2rO/nq8E8TwsjeEx0S+yFTmCHlu2z2CKFZ0wUNcFVJARWUxNF2rfZgatCJIBT7XvqbjXOt qpj586AS4s3tmPjPDqG/WNcCOIq6Gac= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WCvORc63Xc/jlm9uhOtZxAQJTdnogdSx3B9Dg3F/tt8=; b=EG3k5D0X6i7MCDl7fPlu0Os/T9 P3DWozrpKZNiiTwIBKQbwpm6VZvqHcqh7vAhLujXPTORzLj8CF/HM4qZkvrXeBx7bFnKTsYO3WqWE bfWAfHbPGIYvejU5QbtqQx0o+6xAJQHWzVYVP8KX85kXbMgunY/JYMFk92i3U5+HepWLcYPvoEiBw 5zkkL3cy2U7+suRvx85VDiz+0m0G0BqTaOpB8ACt4WMUTt9BOyTdUC1F3BdlG3LcB4+k7LUJeTGaS sHJ2p05k/d1NF2jIFFJjlyNPNnnPCFx1SmRwdSU4C1BrS2bJZ1eskX0IZPg16ydkyxbSIuEmbP+8P iQLxh1XQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qQtre-00EpOw-2F; Tue, 01 Aug 2023 18:12:58 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7A4593002D3; Tue, 1 Aug 2023 20:12:55 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 5C6BC201C57DC; Tue, 1 Aug 2023 20:12:55 +0200 (CEST) Date: Tue, 1 Aug 2023 20:12:55 +0200 From: Peter Zijlstra To: Josh Poimboeuf Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Yair Podemsky Subject: Re: [RFC PATCH v2 11/20] objtool: Flesh out warning related to pv_ops[] calls Message-ID: <20230801181255.GE11704@hirez.programming.kicks-ass.net> References: <20230720163056.2564824-1-vschneid@redhat.com> <20230720163056.2564824-12-vschneid@redhat.com> <20230728153334.myvh5sxppvjzd3oz@treble> <20230731213631.pywytiwdqgtgx4ps@treble> <20230731214612.GC51835@hirez.programming.kicks-ass.net> <20230801160636.ko3oc4cwycwejyxy@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801160636.ko3oc4cwycwejyxy@treble> X-Rspamd-Queue-Id: 3DF1E2001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fcfi3pc8qtwir34uzaq6p3mam1w36c7p X-HE-Tag: 1690913627-847710 X-HE-Meta: U2FsdGVkX18S4/0h4kP0Q5cKumKk9fB7jQkE4f8Vc60fvTyo3HiraazHD/QmmkSqcPGS1HpODiExes8HDP0R/OqdmIK4wzvRovOV/0KRselemwJ0CUsb02w99FBonxcJ+ErQMYJkaxMhLtTVWlm0gNspqxSp2vmAqrqIH1kOrv1b2M7k1PjlRb8LDeLPHma0hlBMTg7NsDJ5CqSlNkZRBbacc6wPvLURfVbrARuVn6atD/D/UYdhjarhROtYUXcHqALqODYQPDufgRMm1cli9Ey0AFBJuOV0rmVP1nUEwGKYbxuau7b5DkmLm8Al7e5oLPCV3n5GxJ40IoYNLW6EAgoHYntX+GEykKgIPtQG2l8BGYoNm8vWwTXxiqL03NLDQ3FAPA9NoCaFE6WOqwEDBaYEGVgl31yThIvJFsFFpOEyWkFyoZQJYXijG/cUqhITVEVkMSnfMMgeOPt7X+JyYGYC94D97/c7Mfb4biWdza1N1R9W3LN0t1klqqyIadjMI3+ixsZHa4bWWHoO4eCNsCZ+fsZg9OpDKmlCgBgz8Esn5Ld7rM9BnUsxkJlQU/98T5AcF6ZLyW/sqVVKCm/YqR2XexPYcUBFyLit24IghFKUyTGre1v+zQu/YWINq7JIvCTd/HlXgG4ocWQnYewuCnGsuBk0n/816E9ZlumnHwOsKQ1EAIhsq5XMIztAXWKUWnAC4wh/S2BZ+omaYuvCa/wr8oS0kLu2J/QPlpDf8oZa+m+u0G90qWWjcBB7eR4/wCHGJ8vni9QOjn6Swq5XujupXLfYr9Wr7pn6P9FY+Bartqn4HR8R2ia2Kfc0NnBnO5U01/meswC2A8DQ8jBcyGcATacjdLYz+hjW6q4BfjglnVlrXc5mdSMl0TN/Ij/Rd4Dx3NuMh5Zy5R8FbEIs/XuxU1zXXyY8h6KqrRD4LDyKN6XrM/0Qf0ajyYYS7swzXBRcrCrW5egh5PiBIhV kGVM+hhJ kkUxnHRe9moYqu8E8yKwka3nzEdWxA6gz89hMaUsvxi35w5MKXgydICjf9I4PG/m3JE2Din92uCl+ajjjl4BYptxEDDnNSDXVt9BFtox8oQ03bgEy6L6PIesJywNMmHrGIr7RloWEGI84QPESdqgPclLj5AkZwwL+Q+q1gwme2wPAqVmmJOxDK5LWG/oOdaDwA1AhZoL+Aq7kGWXb8eOQG3kIOvssQFhLNFvevT0xvHkmxzuKfapwblnWX9QjbioXuZZg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 11:06:36AM -0500, Josh Poimboeuf wrote: > On Mon, Jul 31, 2023 at 11:46:12PM +0200, Peter Zijlstra wrote: > > > Ideally it would only print a single warning for this case, something > > > like: > > > > > > vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: indirect call to native_flush_tlb_local() leaves .noinstr.text section > > > > But then what for the case where there are multiple implementations and > > more than one isn't noinstr? > > The warning would be in the loop in pv_call_dest(), so it would > potentially print multiple warnings, one for each potential dest. > > > IIRC that is where these double prints came from. One is the callsite > > (always one) and the second is the offending implementation (but there > > could be more). > > It's confusing to warn about the call site and the destination in two > separate warnings. That's why I'm proposing combining them into a > single warning (which still could end up as multiple warnings if there > are multiple affected dests). > > > > I left out "pv_ops[1]" because it's already long enough :-) > > > > The index number is useful when also looking at the assembler, which > > IIRC is an indexed indirect call. > > Ok, so something like so? > > vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: indirect call to pv_ops[1] (native_flush_tlb_local) leaves .noinstr.text section Sure, that all would work I suppose.