From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Cc: Huang Ying <ying.huang@intel.com>,
David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH 1/4] mm: migrate: use a folio in add_page_for_migration()
Date: Wed, 2 Aug 2023 17:53:43 +0800 [thread overview]
Message-ID: <20230802095346.87449-2-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20230802095346.87449-1-wangkefeng.wang@huawei.com>
Use a folio in add_page_for_migration() to save compound_head() calls.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
mm/migrate.c | 44 +++++++++++++++++++++-----------------------
1 file changed, 21 insertions(+), 23 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index e21d5a7e7447..b0c318bc531c 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -2057,6 +2057,7 @@ static int add_page_for_migration(struct mm_struct *mm, const void __user *p,
struct vm_area_struct *vma;
unsigned long addr;
struct page *page;
+ struct folio *folio;
int err;
bool isolated;
@@ -2079,45 +2080,42 @@ static int add_page_for_migration(struct mm_struct *mm, const void __user *p,
if (!page)
goto out;
- if (is_zone_device_page(page))
- goto out_putpage;
+ folio = page_folio(page);
+ if (folio_is_zone_device(folio))
+ goto out_putfolio;
err = 0;
- if (page_to_nid(page) == node)
- goto out_putpage;
+ if (folio_nid(folio) == node)
+ goto out_putfolio;
err = -EACCES;
- if (page_mapcount(page) > 1 && !migrate_all)
- goto out_putpage;
+ if (folio_estimated_sharers(folio) > 1 && !migrate_all)
+ goto out_putfolio;
- if (PageHuge(page)) {
- if (PageHead(page)) {
- isolated = isolate_hugetlb(page_folio(page), pagelist);
+ if (folio_test_hugetlb(folio)) {
+ if (folio_test_large(folio)) {
+ isolated = isolate_hugetlb(folio, pagelist);
err = isolated ? 1 : -EBUSY;
}
} else {
- struct page *head;
-
- head = compound_head(page);
- isolated = isolate_lru_page(head);
+ isolated = folio_isolate_lru(folio);
if (!isolated) {
err = -EBUSY;
- goto out_putpage;
+ goto out_putfolio;
}
err = 1;
- list_add_tail(&head->lru, pagelist);
- mod_node_page_state(page_pgdat(head),
- NR_ISOLATED_ANON + page_is_file_lru(head),
- thp_nr_pages(head));
+ list_add_tail(&folio->lru, pagelist);
+ node_stat_mod_folio(folio,
+ NR_ISOLATED_ANON + folio_is_file_lru(folio),
+ folio_nr_pages(folio));
}
-out_putpage:
+out_putfolio:
/*
- * Either remove the duplicate refcount from
- * isolate_lru_page() or drop the page ref if it was
- * not isolated.
+ * Either remove the duplicate refcount from folio_isolate_lru()
+ * or drop the folio ref if it was not isolated.
*/
- put_page(page);
+ folio_put(folio);
out:
mmap_read_unlock(mm);
return err;
--
2.41.0
next prev parent reply other threads:[~2023-08-02 9:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:53 [PATCH 0/4] mm: migrate: more folio conversion Kefeng Wang
2023-08-02 9:53 ` Kefeng Wang [this message]
2023-08-02 12:21 ` [PATCH 1/4] mm: migrate: use a folio in add_page_for_migration() Matthew Wilcox
2023-08-03 7:13 ` Kefeng Wang
2023-08-03 12:30 ` Matthew Wilcox
2023-08-04 1:45 ` Kefeng Wang
2023-08-04 2:42 ` Zi Yan
2023-08-04 5:54 ` Kefeng Wang
2023-08-07 12:20 ` Kefeng Wang
2023-08-07 18:45 ` Zi Yan
2023-08-09 12:37 ` Kefeng Wang
2023-08-09 20:53 ` Mike Kravetz
2023-08-09 22:44 ` Mike Kravetz
2023-08-10 1:49 ` Kefeng Wang
2023-08-10 16:29 ` Mike Kravetz
2023-08-15 3:58 ` Huang, Ying
2023-08-15 21:12 ` Mike Kravetz
2023-08-16 0:50 ` Kefeng Wang
2023-08-15 3:56 ` Huang, Ying
2023-08-15 13:49 ` Zi Yan
2023-08-15 20:39 ` Huang, Ying
2023-08-02 9:53 ` [PATCH 2/4] mm: migrate: convert numamigrate_isolate_page() to numamigrate_isolate_folio() Kefeng Wang
2023-08-02 12:30 ` Matthew Wilcox
2023-08-03 7:08 ` Kefeng Wang
2023-08-06 5:04 ` Hugh Dickins
2023-08-02 9:53 ` [PATCH 3/4] mm: migrate: make migrate_misplaced_page() to take a folio Kefeng Wang
2023-08-02 9:53 ` [PATCH 4/4] mm: migrate: use __folio_test_movable() Kefeng Wang
2023-08-02 12:37 ` Matthew Wilcox
2023-08-02 12:38 ` David Hildenbrand
2023-08-02 11:47 ` [PATCH 0/4] mm: migrate: more folio conversion David Hildenbrand
2023-08-02 12:38 ` Kefeng Wang
2023-08-03 9:34 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802095346.87449-2-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).