From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68600C001DE for ; Tue, 15 Aug 2023 06:45:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E901C90001E; Tue, 15 Aug 2023 02:45:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E18D490000B; Tue, 15 Aug 2023 02:45:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEAA190001E; Tue, 15 Aug 2023 02:45:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B79C190000B for ; Tue, 15 Aug 2023 02:45:02 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 79F8DA0D25 for ; Tue, 15 Aug 2023 06:45:02 +0000 (UTC) X-FDA: 81125401644.08.B2E53F9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id CC60F140010 for ; Tue, 15 Aug 2023 06:45:00 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mPj9wVk5; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692081900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3IlHD+0mdDsHSYeFXjHoOcY+fxwGSXclvqtC60oVUFU=; b=i3YiPsmqh8VCGGgnxiajmUnud8fYcYmNAiekAghTsv2Huy7nyn9Fmyp38zqeGQe/1PwU8W JFI3X0705xv+DJwYO0gQn0cRs2fr+1eSqtCm6eAcK8aHbdiUZ/5NMoloQGQvNqTfsFofBG 0twXt3gdsXxLRCJ68JGg6KoiagRKf3U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692081900; a=rsa-sha256; cv=none; b=Hg/fKlP1uiHvSqlU8vFO1gv5aXURrIxtqGY2+kmkAdwzgHMQjeDFi6PbNPsGhX2v/BIABj kerpAntc3F58a5/BiYox1DQNWi9KDPy7wQf7KqMPveA8uRCACG4fYCxQrnRmk0NIy0MTH/ ncWPRY4pe2ZC3IW/raJeuSuT21Kq8KI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mPj9wVk5; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BB1D1638FB; Tue, 15 Aug 2023 06:44:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3E22C433C8; Tue, 15 Aug 2023 06:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692081898; bh=N/4HsXYS350f+iJkjsF8MsfXr2M7KiE37MDOm3Kw0lA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mPj9wVk5xpXrsnlHJ10aHVTpPUNZij6r8fuG6qaGGV1lWlwwm51IiVptZo1xCN8q8 rWshzJ0rDR9aW7dvQsExfmz+P/AxUVhabzzzlcwXOpeMANKqfQWt3aBSeCTRfBOZ/S KKW/yP3r5DVq8fCF841czMZX6++DG+SxJik/f9GlMrx4YL6fOWk/uaTgEnUpP49QM7 mWbiI61KbGgS1RlJ+EjZR0eWwTHR55IgQI8XSeinQ/mbKKUMQgX9OQIii/lrrf+kUc GtjbJXEEe0eVAW6kdTkeOUObuSEiqpcmE22Sz/1fc/ZGFILL+ozNLYGKxwQlZVTrjC RWprzgy1+S29Q== Date: Tue, 15 Aug 2023 09:43:56 +0300 From: Mike Rapoport To: Andrew Morton Cc: Kemeng Shi , pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] add page_ext_data to get client data in page_ext Message-ID: <20230815064356.GP2607694@kernel.org> References: <20230718145812.1991717-1-shikemeng@huaweicloud.com> <20230719094421.GI1901145@kernel.org> <20230720053736.GM1901145@kernel.org> <20230811143929.79ee3231cbcdfbe43852a4bf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811143929.79ee3231cbcdfbe43852a4bf@linux-foundation.org> X-Rspamd-Queue-Id: CC60F140010 X-Rspam-User: X-Stat-Signature: rkqzg9ede7pnpxtuhygsw8je3th8hgnb X-Rspamd-Server: rspam03 X-HE-Tag: 1692081900-100831 X-HE-Meta: U2FsdGVkX1+wyFnR/z2oQOU0AeDUIXuts/oEqZ2rhVsaWaLJ7UIDTeTuA9QyEdf5tOcNTCmrcabvOqKmQOxjT7jHOf763O+lQUDM3qR8xVCqLtOkPknCULLj/SvSrqwuq18g21gcm2hGwXoQzau7OnsAApaNsaIGy9s23fWDVtzqfOYV1Kbt+S3LSiy6n51ZrB7QlvN/fThUU/CZ9yf8Sgw7NtiDcxpIoeQ8QES/iR2rVGq2bjUr416YHSx0FftCUpsrXmRbITfhvOAhca6xhLhmapOR/cNBwj96Z8wuQj4G9737yzMy+hjbb06oiLYvHPnBQo0kTgRNplk1b6B1O784kfrXGcZxA6rvB4ARRLHDnpYxwBIZZrZpz/6qukvq468ekWNLr26NNt7y2WEt1pT8OBoiPum7/TxDCwm+Cjv9EJgPTYGKB5UXTNk5yEI03IxpCDs1pC/8HrhYBFNUDCJTCt8nm3R1j2mQEEVsxjmZh4T69dQN/l+eR1GihEA9E3+uEkRJb1r8HqkIW1owsorCx1wXAEQx6AcBmFaBt3hVTrXYF+bsZL7esjpznJI6HZoqfOewYzcZXBU7dl00TUXdUhCfLEQHokvWTJvGYARB7W4bOlWMz3kFqeGhqO3n/xXAnnLAXN6Fsl1IfFgC28QkMTOICAGgeW0iBLDJvsjjjg4uw6FUq0O4vM+NQTRu87wQ+a1mvR0Mifo297f+WMqOAUP2NLNtCYAzwZ/uvVYrxfWzKC8hZcsdgbmI4alh8OI78HKPczx6yt1BgC/3N7X9SstnKC3W2Y6LdE3ZcuCnLVG9K6C+WlXeF+n3rfFKBXH3FgdFh9kE3tH/w7Ib4kOIGzhQ6bPjEChWFkrNoXu7L9LRlkTtgmAMeXc8hQbp95vNUAqV2lmd1012Xdwni5ZFNZq+PisqcGUXg3u4gxSKXH/UbcbFCP643l660Wn9T15PK4xIkH1H/TnG4Qj N9lksrdB vJswDq8e/HNiI2ff0iWT8QbLHGYGImbuFyQOrj6CrdZOSLjitMEWLK8UgFYzrUoH1AKXywlzVuaspl1c2fXfuP3dFl7VRGTsPlS/2xm8kR0oUz/w7b7stk9GM1MQufVpWwkdkAlmjPobxd2bZArMNTHJKa8byKxn8lWGuL4/K2wSrIlBy9xOilVSu97w9hpGJp7h1AwuxwA+p/bAMrqo1Qtxc9yiD9aEMEg99VUg0J+UDrLjk7QiuVpqPFKp7eI01Z+5wtY1Y4wC/YuS1pQ7YOwo4GUqIqs6AJkOd40pLu+4uhJGAheEndB6mGbPI+LBmnGpZ1SIzr6vJx2sTB5PYIHE5dbL51j4Q0y64kpR9LWjLNbwXHNxIxuQV8QS/Flr+BpmMV6jgCYk1OWs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 11, 2023 at 02:39:29PM -0700, Andrew Morton wrote: > On Thu, 20 Jul 2023 08:37:36 +0300 Mike Rapoport wrote: > > > Hi, > > > > On Thu, Jul 20, 2023 at 10:38:39AM +0800, Kemeng Shi wrote: > > > > > > on 7/19/2023 5:44 PM, Mike Rapoport wrote: > > > > On Tue, Jul 18, 2023 at 10:58:09PM +0800, Kemeng Shi wrote: > > > >> Current client get data from page_ext by adding offset which is auto > > > >> generated in page_ext core and expose the data layout design insdie > > > >> page_ext core. This series adds a page_ext_data to hide offset from > > > >> client. Thanks! > > > > > > > > Implementers of page_ext_operations are anyway intimately related to > > > > page_ext, so I'm not convinced this has any value. > > > > > > > Hi Mike, thanks for reply. I thinks page_ext_operations can be futher splited > > > into public part which used by client to simply register and private part which > > > only page_ext core cares and should not be accessed by client directly > > > to reduce decoupling. > > > > It would be easier to justify changes in this series if they were a part of > > the refactoring you describe here. > > > > > This series makes offset to be private which client > > > doesn't really care to hide data layout inside page_ext core from client. > > > There are some concrete gains I can list for now: > > > 1. Future client cound call page_ext_data directly instead of define a > > > new function like get_page_owner to get it's data. > > > 2. No change to client if layout of page_ext data change. > > > > These should be a part of the changelog. > > > > I added this to the [0/N]: > > : Benefits include: > : > : 1. Future clients can call page_ext_data directly instead of defining > : a new function like get_page_owner to get the data. > : > : 2. There is no change to clients if the layout of page_ext data changes. > > Mike, what is your position on this patchset now? I'm fine with it, so if it's not too much hassle to add it now Acked-by: Mike Rapoport (IBM) > Thanks. -- Sincerely yours, Mike.