From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99129EE49A8 for ; Sat, 19 Aug 2023 14:12:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08CE190000E; Sat, 19 Aug 2023 10:12:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0155C900007; Sat, 19 Aug 2023 10:12:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD2BF90000E; Sat, 19 Aug 2023 10:12:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C2E2F900007 for ; Sat, 19 Aug 2023 10:12:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8458BA08E4 for ; Sat, 19 Aug 2023 14:12:48 +0000 (UTC) X-FDA: 81141045216.16.6C67C00 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf12.hostedemail.com (Postfix) with ESMTP id 9E33540008 for ; Sat, 19 Aug 2023 14:12:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ZfnvpAJg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of yury.norov@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=yury.norov@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692454365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QFVxXxStyebQd2+5mwYh1o0joRC2SclF2vbhFRruGlE=; b=MZ3mQEb1Afsj4FwfiF3/i9SSHmrr5qTfSBFkN8MrudPOdJdjP2U9CtRwSpiSl2oyteDQzQ 5TaivsmdpQZMurB6OXWZus6BGc9a6lwKio+EWpy8Tfk7kUahiPe3IEMhzEyoOIt3lTk//Y +zeam6Qlm6YDYIOfY5yiaY1+Fvi2Jlg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=ZfnvpAJg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of yury.norov@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=yury.norov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692454365; a=rsa-sha256; cv=none; b=caI7MBTkvaWpCkJUx6hh/EbYDL+tBone+HFg+JUhiqGwY4LQDidDI9+0mkdnwR202/gEQM G0QQMoZVp/P2lBrZ3Io0eEpWoTHJJGFIzjhDVdQMxw1pWs4IiU6QcjO83sd1TWGOkdE/8t 5Q8cW8Al9R6ME7lZgAdFeC/yn+VMnr8= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-64f383be0d4so146496d6.3 for ; Sat, 19 Aug 2023 07:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692454365; x=1693059165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QFVxXxStyebQd2+5mwYh1o0joRC2SclF2vbhFRruGlE=; b=ZfnvpAJgMbfQ3CZw7R7tBTIb0/CjcaNSgcbF2GnwC1IHBGukLBv2YpA5Xks+Msu2TA uMhZWngetDzl4ElT+MpmnGvhNpcECn0iQeDQaf7+z5ohObKr5KveEms6lREnz0pkluIU lbhrThEQrUqq6005xo225pWxTJLTL7a5laff9rT5866P9fbRYXvRztLy4FgY5FGg/NNs 0+QPT5LsThOBOcRtvSSNj3gmKBcKzSr9A+7gOARHUk+/0caenQwXXwwIjYV4cA1ZWQsh TniAp6hta2j/wAcjBcjfdlP6BU1uXdT2cSDxOe10NQwQoEvi2oJ38UOEwKOB6im0XK+m //JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692454365; x=1693059165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QFVxXxStyebQd2+5mwYh1o0joRC2SclF2vbhFRruGlE=; b=ZSQA9FF4JFHenNSsLczxKRSKZ+7raqWHzncRS7+7QPrw8xH7wVeXZNLEDWM+vYO6mj YpaMpZlWD9Ns1/SBMqRaTtrL+G1iZnEOpmVb7OrSGtQFLabVynQWX7KEOsl9WBmnhP7Y DVtIWZFaMY7NHft8hifIMLAEg/rNq7SNJhxBPaE/7Oh8i4MHI77aKIEOm/VOHYV7Npk3 kPyTN5QPG4cxfEsXFqBBUxtfoqc3y43FsIeeQvZmFtQNSZV6o4mGiEQa9hcSE+4pClqY hZ75v0rGZIja2z4w9OzHddol4htOAKijrgaiU+tLSVQZ1a7O7NxgYgd/hyzcPEw0mdaU pb/g== X-Gm-Message-State: AOJu0YxKyNwk4SjxRjIjnFJ6L4JTO3ICnho4IqtEByWJlSrCOy4hdgGO d9Du7t5yPWZHlkWZD2frw5k= X-Google-Smtp-Source: AGHT+IFUX8eTyssulPQya93DY8TjvT45WssAgMpP4ifh6tDP9KAQSGhQl+ktG/q4W6s+7sBb8lbdUw== X-Received: by 2002:a0c:8e83:0:b0:640:5beb:d89d with SMTP id x3-20020a0c8e83000000b006405bebd89dmr2415714qvb.40.1692454364731; Sat, 19 Aug 2023 07:12:44 -0700 (PDT) Received: from localhost ([32.218.242.113]) by smtp.gmail.com with ESMTPSA id h16-20020a0cab10000000b0064906cfe430sm1473236qvb.135.2023.08.19.07.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Aug 2023 07:12:44 -0700 (PDT) From: Yury Norov To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Yury Norov , Ingo Molnar , Peter Zijlstra , Andrew Morton , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Jacob Keller , Jakub Kicinski , Juri Lelli , Mel Gorman , Steven Rostedt , Tariq Toukan , Valentin Schneider , Vincent Guittot , shiju.jose@huawei.com, jonathan.cameron@huawei.com, prime.zeng@huawei.com, linuxarm@huawei.com, yangyicong@hisilicon.com, Andy Shevchenko , Rasmus Villemoes Subject: [PATCH v2 2/6] sched/fair: fix opencoded numa_nearest_node() Date: Sat, 19 Aug 2023 07:12:34 -0700 Message-Id: <20230819141239.287290-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230819141239.287290-1-yury.norov@gmail.com> References: <20230819141239.287290-1-yury.norov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9E33540008 X-Stat-Signature: g4iksokq3zkqs87mxyz4qk91zjcsf667 X-Rspam-User: X-HE-Tag: 1692454365-183205 X-HE-Meta: U2FsdGVkX1+USYujpecvlx5dH0tg/MfKRH175yz7B69aHUFb0TV8lfcs/e8AJXyL3nmHJ0l77HKn0L1oEUgtuGaf25D7HdmiMuQm5r2M2xFy57EA4g3el3ecsbAsJT1dpY0keumMN1Z5oeK1i1xc5dXJ1m+VGnKsQAXM+NwPPfELlreXQt+Ur0Ckxq9lVHcQpJeo2braa0GGAPy686W+QvWyykBvxzgSIUDEbmGoPcOdoJpmV8wKAFt/9hrH2fddhJYxYlgcq8JOqetAeP6S0CU2DcNK93u876KnMOgLDXTzlHAQ2VHElrVreLmqzTCH0R5HERmJZr0/k8TBU73sPpmzQiYTPeC2t/R3MYU7IwoFPsYvyRK5gYrmQxnX5WdsQxrQo050uTwOD10kPwHsmMVEuIxPi61+5Xxmsp3A2xAyCNVXf7LFkjKacNCs6ruHG0aFpREjmgSld9vaIJ5wcGzcpHrHZGjyrSTMuwaM/8d2LtNRC0Wr88qUIep23CEPaLJySgwNbIVqk72GI0aP9lEzRUIW+Zljfb2qVQY0XR4V59jI64VOM+/9iZjDFijaliK3wJPKY4IEwS58aR8rEOA1EIUBfjfkyyf5XuoXdhKtoPk16JQ3KmVtHt2voI89v4asp6SbzE1u19sr1vR5c4YSwVXJUeGDlmV6RVEVeRR592+83VE8XHYEvRpp6L75vCCyk1EiJFYXiibojcpv0J/pE9Z+7PUklQAD8amiCx0rVHKgyOsurzaPLJ59GUr6EvLwxvEj4GY72nHsEASwZLmDNKzqZCt89EK45RWQgyRmJuPKebRy4p3G+Ld0Q0mBZrIjp/uNjhYIOLtba5fcjC10c4i3bln9khwzFejHHuJJeGJOVlRs1xiwONUAqGujQtPgG1CmY/O43x/tYw/yQXQA1OtXmJzTBA9YYf8cAU6BR1b+OydP/DcfTZqUkUJgUB857fCXOp9k9FuCwDZ D3SQ6Gss 6gUhBES+Mgq5rlD0MGZND4eszpRIDD7BCp9491JdR98jgXrUoL/IxJF26+fJ2P5hRhUgpIINuwv52VYt65hTnmGUVvSPG7y17kGjWPhh38SXaJfFeI9DFj6Uua/0VRACBqNGIVlVzV3sd0UyAm6imu5I1mOCRzok7i2vzQaNlQHKVKisdWikn1W8aVWV6px/2allLUpsmDkn8uznMgsCZxiYThIBHtF00Qxm857XWAmSatP+6Q1AHsLzcdBqODex32B8bCTFQcIcHI6woI0GlRQiJJs1VIy2s7pLoumQgJbx93OmNLQQiruhyloCsPvrI0QUrJRlqmZUkqf9eHFnRNBhkhojd1gtkXO6WSqbiqfAxi6KIcP9o9OArCOk+WT1u49ruahpdD/9ojlKoGVIn5F7VmYatCAUvJJ3VMKiy26yzOgpCFmFnJ5f9ZvL7K4t3GV8Iz839mO+IjQRAbCZBAu7ZmP/2WIqiGZQ8wWTO2z0ItOgoaYpuhe28cHo61H1O6zi+mknv6ejsrKdKNrCr093yLYqYYQ3epB8+MsNprIHNM4hVAEBcTqnusCMvhuYrEeVsALJkEL/L72tPs3CUi2j68A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: task_numa_placement() searches for a nearest node to migrate by calling for_each_node_state(). Now that we have numa_nearest_node(), switch to using it. Signed-off-by: Yury Norov --- kernel/sched/fair.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b3e25be58e2b..e7b7cf87937b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2645,19 +2645,7 @@ static void task_numa_placement(struct task_struct *p) } /* Cannot migrate task to CPU-less node */ - if (max_nid != NUMA_NO_NODE && !node_state(max_nid, N_CPU)) { - int near_nid = max_nid; - int distance, near_distance = INT_MAX; - - for_each_node_state(nid, N_CPU) { - distance = node_distance(max_nid, nid); - if (distance < near_distance) { - near_nid = nid; - near_distance = distance; - } - } - max_nid = near_nid; - } + max_nid = numa_nearest_node(max_nid, N_CPU); if (ng) { numa_group_count_active_nodes(ng); -- 2.39.2