From: Mel Gorman <mgorman@techsingularity.net>
To: Chris Li <chrisl@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
baolin.wang@linux.alibaba.com, Michal Hocko <mhocko@suse.com>,
david@redhat.com, willy@infradead.org, linux-mm@kvack.org,
Namhyung Kim <namhyung@google.com>,
Greg Thelen <gthelen@google.com>,
linux-kernel@vger.kernel.org,
John Sperbeck <jsperbeck@google.com>
Subject: Re: [PATCH RFC 0/2] mm/page_alloc: free_pcppages_bulk safeguard
Date: Mon, 21 Aug 2023 11:32:25 +0100 [thread overview]
Message-ID: <20230821103225.qntnsotdzuthxn2y@techsingularity.net> (raw)
In-Reply-To: <20230817-free_pcppages_bulk-v1-0-c14574a9f80c@kernel.org>
On Thu, Aug 17, 2023 at 11:05:22PM -0700, Chris Li wrote:
> In this patch series I want to safeguard
> the free_pcppage_bulk against change in the
> pcp->count outside of this function. e.g.
> by BPF program inject on the function tracepoint.
>
> I break up the patches into two seperate patches
> for the safeguard and clean up.
>
> Hopefully that is easier to review.
>
> Signed-off-by: Chris Li <chrisl@kernel.org>
This sounds like a maintenance nightmare if internal state can be arbitrary
modified by a BPF program and still expected to work properly in all cases.
Every review would have to take into account "what if a BPF script modifies
state behind our back?"
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2023-08-21 10:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 6:05 [PATCH RFC 0/2] mm/page_alloc: free_pcppages_bulk safeguard Chris Li
2023-08-18 6:05 ` [PATCH RFC 1/2] mm/page_alloc: safeguard free_pcppages_bulk Chris Li
2023-08-18 6:05 ` [PATCH RFC 2/2] mm/page_alloc: free_pcppages_bulk clean up Chris Li
2023-08-24 6:28 ` kernel test robot
2023-08-24 15:25 ` Chris Li
2023-08-21 10:32 ` Mel Gorman [this message]
2023-08-22 1:27 ` [PATCH RFC 0/2] mm/page_alloc: free_pcppages_bulk safeguard Kemeng Shi
2023-08-22 21:14 ` Chris Li
2023-08-22 21:19 ` Alexei Starovoitov
2023-08-22 21:29 ` Chris Li
2023-08-22 21:35 ` Alexei Starovoitov
2023-08-22 21:46 ` Chris Li
2023-08-22 17:48 ` Chris Li
2023-08-22 18:28 ` Matthew Wilcox
2023-08-22 18:57 ` Alexei Starovoitov
2023-08-22 21:34 ` Chris Li
2023-08-22 21:37 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821103225.qntnsotdzuthxn2y@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=gthelen@google.com \
--cc=jsperbeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=namhyung@google.com \
--cc=shikemeng@huaweicloud.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).