From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A7BBEE4996 for ; Mon, 21 Aug 2023 14:49:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E97A8E000E; Mon, 21 Aug 2023 10:49:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8998A8E0006; Mon, 21 Aug 2023 10:49:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 761EF8E000E; Mon, 21 Aug 2023 10:49:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 673838E0006 for ; Mon, 21 Aug 2023 10:49:05 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 46ED040CC3 for ; Mon, 21 Aug 2023 14:49:05 +0000 (UTC) X-FDA: 81148394250.03.9E91B92 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 98F4410000B for ; Mon, 21 Aug 2023 14:49:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VAlmq6sM; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692629343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MWQ/dDCHoNJk/U+XsbQdw7khPYxzEdLBqjUAuWlm2Fg=; b=HY19kQqQcBc3xMl6MQirOzXkqSXO7EnHlb7M8cTG8QUwP4lZ2nJq7+mLO2HT0lETmEAV5a 2LiZxXlEmhmf86Uyyd6UFhUtvmdThkShDipyH6zX58NAdCBw/G9TzOh4fR9onCenCYK7+V O8VqaL1t1JuZKIiUqUexKvB76oEb61I= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VAlmq6sM; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692629343; a=rsa-sha256; cv=none; b=5hsCUOH6m+P7VqXDv0Mj5N5FbM7n4Bb/kpHWCYF7TfdsprVVq41l54703+6NIhwNYxosjH jgsqrwt4M8OJcJxhsuaEfqQpqk9E5ehozcd1WIMXZFPw13qncMSHP/UxYbbBfyn9hZ+isY /Gdw+UrYEBGSA+m5+wrOgaMCmoXAt5A= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8532263AFC; Mon, 21 Aug 2023 14:49:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF6E4C433C8; Mon, 21 Aug 2023 14:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692629342; bh=3afoTbeGCPP2VeMz10L5Z1TOYPl9gktT2YYKQFBV4YI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VAlmq6sMl6RQzRAXvXItSnID1noay7NjR0DzLty1Mw7M8/pmuJOwZLXcyR/+oB0W8 8tzlu8MGX7QHSfgmrmwkMU2Qd+mUbOlfNal53SqegXJtSM3GzhCybKpRB1ofvcRuHN wX2Sq9kEKf587rIf6wqo8euwLZB1M98eoxllZSdma1onnRxW+Ceo0IltI7LwmTZlww 3BFcJ3FN+v8xKEHCzYp5lmnePfDyw1mRMpcosBp9rH4WlZ5Wd410El5WJhAwHSqs4X xRxIc2nSIThZ6g7bcfVAc9Ez5EBetSBVCIVyVWQwqj3QBwX1Pv7l1LbK0GtVQNwO5Q lvOwM8dTnJP6Q== Date: Mon, 21 Aug 2023 17:48:36 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] secretmem: Conert page_is_secretmem() to folio_is_secretmem() Message-ID: <20230821144836.GA9849@kernel.org> References: <20230821141728.2536317-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230821141728.2536317-1-willy@infradead.org> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 98F4410000B X-Stat-Signature: fuankpk4ukzauthpnra1knj5fji7d3tg X-Rspam-User: X-HE-Tag: 1692629343-938104 X-HE-Meta: U2FsdGVkX1+vKAvTDRSLsFbUvrBymc1wM3pr1Bwh+Q+ntbX9qjJh7fbmmgKtaZQ5HjsYUeAS4lMjn4zqNO/va+eEyEefwQpRlfj29uf/M4wO/cpsGtxWCVyLII8wdw+Qt8dJlVoH9gWU3PsjLr8YmIArKsiMPrIepsKAl9QQLeP3Kjl/Tc26ETuXMuiVbbE/LcLQzhQGFnH8pGswSU0GrfhwBhgxbKMcAhW+E8BQiG1MWikjsl5NGQYRrcIcinUIfe83j1mNl21uZ9jAoRbNnO7HZI74zJ4RhmlNWW+56lJD7he8a4y5gFBbsovZNsaGjM1POUNQT51HRpzKL3SiPZMKi5OOD7QI0uL63dazh92ORh8XizLonjRfWG3ADcSYIpPGfcTSTn4WOCBbSWVKy7/qMyQg55eAaDjPfLuePdtp5m9wd0JKlP+VjUfqtw4CrnfWQNkxejGm3H21lWVG1oqbMMwaiHUm211O/OnzdHi9PhJwnW91oSAL/6iy0spFUqRUJg8tOBgb4XYo+Qs+kvqJ6MjYTda6b3ZqHuTdqFrwV4IWEwb29e/+N7+1LjZEy/Lz2gd8b6fxJS9bkcGBzluEJz7hTi99F2Ou3PV8FZz2n3OM1lLh4RdwSfHuQZiihMXQUGEaHqQKsnDermW+uCqGV6bQOjA1+s9KRAkeUV7jsUbuvYDAWBKJwuydKuHrP5GgbDrkTVCs8mZjz7v+aR+YqdMrd92oC3DlnpQF6VaEtZNrpg55St7G1Xf77eqjcHI+AgL2HSnRARGZfMiMYhOC7ekHR8oiGv+t8wCEFQ3tYBHiwPfw4bJTFCk03nlluhwZST/1VJNJTAd/PomnpRLS11efw6c/x9cFjmCKOb19gQ4hWHq1SJOBY3aqM9NJkMPK19Mrm6W3EcRPJK0jfG6i9q9gUpsjBCpZZDHSidfj3Nk/i35d47quyN1YfkxK9CVMsiBeWB8lRckuSut ahjrwfHi nCIwzcVu8B8y0ebQix6ZPZuKgzwkI9Ej6jJVi2A34d2WhrSu7hpfLUma/R8eFIsq7AiBBSNJOyN8YXzhNsSFt0063CHFtWK8O4Gll9prJPokvtOQQ7ydcb4oAuXVaIGZr4vvWiTWlDFRCGimrm044ExESQj6yYOPsHSKlZQ3UpNyf9yEXXlrRD7oMdXJHXMfPSE/TTRWqU7c6YfL9OE7ch/ImLXZu45XGi8a2iQpIZxOZ1FurvoArPB9V7IVb4CKuikZnbYX14F0ny1sQZECZIKOP2NpwNYsS9lmGGbLappw+iRxQ1/JDc+bsGzE06yEheMimCSWGn9YVkSVfr0Q5SopPdsEa6+cJXVnBd1Eo4lc/yqPUk6s3ap5aBuZWWi0GMK8stFPF8BZ6TQQvpTFvh1w0Lrn1vwDiBjA676DCnzxwjzZ4SaM8sWkryBsOTmQZQY9gl2usUbH/PLk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 21, 2023 at 03:17:28PM +0100, Matthew Wilcox (Oracle) wrote: > The only caller already has a folio, so use it to save calling > compound_head() in PageLRU() and remove a use of page->mapping. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Mike Rapoport (IBM) > --- > include/linux/secretmem.h | 15 +++++++-------- > mm/gup.c | 2 +- > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/include/linux/secretmem.h b/include/linux/secretmem.h > index 988528b5da43..6996f1f53f14 100644 > --- a/include/linux/secretmem.h > +++ b/include/linux/secretmem.h > @@ -6,24 +6,23 @@ > > extern const struct address_space_operations secretmem_aops; > > -static inline bool page_is_secretmem(struct page *page) > +static inline bool folio_is_secretmem(struct folio *folio) > { > struct address_space *mapping; > > /* > - * Using page_mapping() is quite slow because of the actual call > - * instruction and repeated compound_head(page) inside the > - * page_mapping() function. > + * Using folio_mapping() is quite slow because of the actual call > + * instruction. > * We know that secretmem pages are not compound and LRU so we can > * save a couple of cycles here. > */ > - if (PageCompound(page) || !PageLRU(page)) > + if (folio_test_large(folio) || folio_test_lru(folio)) > return false; > > mapping = (struct address_space *) > - ((unsigned long)page->mapping & ~PAGE_MAPPING_FLAGS); > + ((unsigned long)folio->mapping & ~PAGE_MAPPING_FLAGS); > > - if (!mapping || mapping != page->mapping) > + if (!mapping || mapping != folio->mapping) > return false; > > return mapping->a_ops == &secretmem_aops; > @@ -39,7 +38,7 @@ static inline bool vma_is_secretmem(struct vm_area_struct *vma) > return false; > } > > -static inline bool page_is_secretmem(struct page *page) > +static inline bool folio_is_secretmem(struct folio *folio) > { > return false; > } > diff --git a/mm/gup.c b/mm/gup.c > index 6d0c24e93425..2f8a2d89fde1 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2600,7 +2600,7 @@ static int gup_pte_range(pmd_t pmd, pmd_t *pmdp, unsigned long addr, > if (!folio) > goto pte_unmap; > > - if (unlikely(page_is_secretmem(page))) { > + if (unlikely(folio_is_secretmem(folio))) { > gup_put_folio(folio, 1, flags); > goto pte_unmap; > } > -- > 2.40.1 > > -- Sincerely yours, Mike.