From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3470EE49A6 for ; Mon, 21 Aug 2023 14:55:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87A6F940007; Mon, 21 Aug 2023 10:55:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82AD38E0006; Mon, 21 Aug 2023 10:55:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F315940007; Mon, 21 Aug 2023 10:55:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 619488E0006 for ; Mon, 21 Aug 2023 10:55:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3CF8F1C9A92 for ; Mon, 21 Aug 2023 14:55:02 +0000 (UTC) X-FDA: 81148409244.04.BF7DA3C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 8DC8FC0005 for ; Mon, 21 Aug 2023 14:55:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Lw3R69kc; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692629700; a=rsa-sha256; cv=none; b=c5VDo7htx67d3lZCBb2GfIqj5J5D84IWAEocmnVXCktz+NMiJ6dWU6DqGqGQiyvSGD4rAw AKvAdjkGmNirRN52Q/5m/teS9FO/s1unNW2bgebrb76wbICvHV6dtfTqrd0XYTM/z1481x 4E0jVq+lZYuV9SJ+y7RZnJ5ZQPBa6qQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Lw3R69kc; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692629700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CE+H/GJlxrIQIlGa1B2zcZ1/9zvJav43J31x+J7lAGQ=; b=bNMHSE3V4ktlqTuGTfPqEBTcLa8oTh2RlEJN2aizX2i4fx3YfmnsGLVBNA11Vt4TW7oZI/ rLbAjPzZrWqpU3G+xaRKCfOHqFUHIVRJb+t7rBUZHRcCIYmvDr/7flchTfCozti67exF0F d2p06OLnKQoDHtcJVq7gMRet93JeW3k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C503E6109E; Mon, 21 Aug 2023 14:54:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4D5DC433C7; Mon, 21 Aug 2023 14:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692629699; bh=48bXFABCG3RekOXEork4KjEus4UPEb02K4FMMIA6aIQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lw3R69kcL91pV8PMKSoZRXOEtIj7oHZ39cPwDwsQVsiK/fRZKt37Mza2ihKYPDvhz KU2WO32msinRqUGwu2iPSRZNx0BPXQpNwSEY0ilytvnKrH6h8MMkqh9dzAFnK079ig c5toYLnPdDGJJsdRy2pQTROxMNrxSN+xVUHKZBESQbC24/ZbnKsAkKdSBW/u+4GNtO r6NlJzZI5Oq4eDY4a3xNMViUbEGDo11RNo27j3nUcasVlwPr1II0Ctss4iHhRc2Z23 lBB/R2A5poZz2xF+AjO9c7ygNDG+IZlVe7oyNRxaSjRILKcl+L9l7t3xOO32N819Rb 9HUcYiYdUWHUw== Date: Mon, 21 Aug 2023 17:54:34 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, linux-doc@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 3/4] mm: Fix clean_record_shared_mapping_range kernel-doc Message-ID: <20230821145434.GD9849@kernel.org> References: <20230818200630.2719595-1-willy@infradead.org> <20230818200630.2719595-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818200630.2719595-4-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8DC8FC0005 X-Stat-Signature: zzz6rqydz1czo35ceipi9p6yhkdjjj4r X-HE-Tag: 1692629700-865774 X-HE-Meta: U2FsdGVkX19rNt6lKp++SdeNPgUt7pYVHTrpxNLHblUe49LehMaJ0iBHti+tR0YMoQFtVBoDXKjhuQ18K8GwUmdDG0TGPa0FWdfDjX0XWNW206ZjMQbpWUJmeieVyMIr2TSEsRmLDXdB9jMy4ydqyeuI4hB8Ki1SLQrlwDbW6WiuOVzF/fRVeW3YBehC3vV8RqMluiuVMvG980hLD7evIy2yS+wiK8CELXeXO0AB64NezDMth2bwKC71hM+Z3g8cWzJk4G434LJQTanfBXtdUbBLHL1Lf0PPVjsvVAasp2EhioJp9DS/uluuMToMcMxkDMFVwGbE3ppEBmYcjptD+ISMOm5bO+NugE1LkkNN3V4fhBowzlRsMLE9OQX++E55bDHHwHdvLYYaiqurZXMpIrlnbJ1flJ5D28/uEYZoJym/MATvNDE2dtJ9Xv5dQ8S5ncxjLMoi40ur8zdb9UwB3hvy05pja+iqkSW/AggNjyVPr0IQHI5Y+Z11KehpdiXxOTWhJW/RZU3/o0meW/e9/R5yoh8lHCV94Q/Rc47l+efsdLHusulF1eGqxz1lEiluI3GQ+mFzyHUhynFQU9rWKwp4T+9OcEB3LpTWtUnzCClOZKjgrK817LbfAZQ/t1JavmX6kwmY/Z8hnSrVv8FkIn419LhB7HdJ75UxqTVZ+ionm/ESC/4XeM9F6APRu3mRp1NTPOpzbeQG99IlGnTjLqzikFTwa4tz0w41bBMMxLdMlwK7cn5cfgTW+FL7rC8hk9GRk+Wz7e4P8f3FwNxWj3xY02PZGP2QsfULSCQKVQu6Vxn2Ua0gHyCQMhNQDMHv8knM9lmAkt2manE13Pi+U/PTnwOILXW+Rk3wtJBXEYi2xlreVzRDvP9vYvGp4+rG6dCrNs/EqcGBev8pSWaN6vOjZVLwJXPk+MrtRJnXwJ9K0XbyzbVgc/dbW9RG0/mezOfOPYu8PCvObh4PJtd Y/G7XtRu /JbN0fm2HIuz5DB5e0bRtHieaYw8UziavJ5LdFaNt7YA5gsTKw+/FW+1bSLvCW86XZ9HWr9cGlGDxUbGHsexMJYnSCbq0A1BGVZ7JgwnAiBmU2tKHC32pKL7Q2nOsaBpn5+a2vr90v+o0CC1BLB6rYwpW9lx3wzhl2kjqK3ncLJsLRdVXVUiMilPk5PjV1t7DjCZKv6qiiE4fjqFZpp8sT3oa2sN+gGb6JBuyV9avrM2lp9eoBbGVRJtYOhO/CZpHlp7UbYMT2EGIXMerNj3xfFOH1rIbNAiHYynBXFbahRBICoYMyhZD9uNSbxkzLKrIbfzRGHU4Zo1+LHNBW1b+1H4crtELiRHlGO9q4YQFEMCi9KeVTHJFKhlGmKr8zGwL0PmYrtdK4J5HsSuOfN3mpODkaCfxWG/zPiEaGuxfQu0WvlfMSwACoBFSg9JnRTLeDZI83FJ2lfu8bcE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 18, 2023 at 09:06:29PM +0100, Matthew Wilcox (Oracle) wrote: > Turn the a), b) into an unordered ReST list and remove the unnecessary > 'Note:' prefix. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Mike Rapoport (IBM) > --- > mm/mapping_dirty_helpers.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/mm/mapping_dirty_helpers.c b/mm/mapping_dirty_helpers.c > index a26dd8bcfcdb..2f8829b3541a 100644 > --- a/mm/mapping_dirty_helpers.c > +++ b/mm/mapping_dirty_helpers.c > @@ -288,13 +288,14 @@ EXPORT_SYMBOL_GPL(wp_shared_mapping_range); > * @end: Pointer to the number of the last set bit in @bitmap. > * none set. The value is modified as new bits are set by the function. > * > - * Note: When this function returns there is no guarantee that a CPU has > + * When this function returns there is no guarantee that a CPU has > * not already dirtied new ptes. However it will not clean any ptes not > * reported in the bitmap. The guarantees are as follows: > - * a) All ptes dirty when the function starts executing will end up recorded > - * in the bitmap. > - * b) All ptes dirtied after that will either remain dirty, be recorded in the > - * bitmap or both. > + * > + * * All ptes dirty when the function starts executing will end up recorded > + * in the bitmap. > + * * All ptes dirtied after that will either remain dirty, be recorded in the > + * bitmap or both. > * > * If a caller needs to make sure all dirty ptes are picked up and none > * additional are added, it first needs to write-protect the address-space > -- > 2.40.1 > -- Sincerely yours, Mike.