From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57DBCEE49A0 for ; Mon, 21 Aug 2023 21:22:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADA7B280004; Mon, 21 Aug 2023 17:22:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A89B4280003; Mon, 21 Aug 2023 17:22:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 929BC280004; Mon, 21 Aug 2023 17:22:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7F3B3280003 for ; Mon, 21 Aug 2023 17:22:23 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 41AA6140598 for ; Mon, 21 Aug 2023 21:22:23 +0000 (UTC) X-FDA: 81149385366.10.455A6FB Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf05.hostedemail.com (Postfix) with ESMTP id 6EC12100019 for ; Mon, 21 Aug 2023 21:22:21 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=Ak4Gn2HW; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692652941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xce0vmMn1gvMkKEgP8SciOlKPAtITGIb7QGEMytqaF8=; b=XJt2bxlwMhWCYW+JIwzBB7hA1iHSCH04JjNmXplQfVvki3r+r+kk9uVtHG1qSKPwZttfq9 Sx9l31hWxSi1BSwMKW9jm3lBqY0YMtA5ucVPhnCzBy0TBvYW2BGALeVuthyBJR/p25mEpK PBn7/+vsHbUIipf+oat7nnYAhbYGa4g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692652941; a=rsa-sha256; cv=none; b=Ux5x5Wb1aAKnHYJLMPgtxo0mlICnsMWOboVRx0kf09wOwbUiJIxgbFUri1dKs70QE6vP5P Rc1l6NoB3Gm9JTKDHpYsfNXLkToYdK5IhycPRwouCpchp8K1o26Z8TAYf9w2sCsbcxiZqO /mciu/jGCPS9SDI06x3boBjzH6YPI2Y= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=Ak4Gn2HW; spf=pass (imf05.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.179 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4108f11c067so13835431cf.3 for ; Mon, 21 Aug 2023 14:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1692652940; x=1693257740; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Xce0vmMn1gvMkKEgP8SciOlKPAtITGIb7QGEMytqaF8=; b=Ak4Gn2HWylrO/T/r4SzJshlnVyfDAHGOeNUz9ZhghusisFnCAi7w7cOaAAZZN1xGaF pbIG5wpxUM6hHxgwTyjk2uEmUx9aSY9prGdOm5dAigoJaRdE3VeG6Jyj7zfRNJ1cwtCS g4pIexKwZrtd8JfHwQufnJBhakTEkD8NY8K6LwzfWp+jZCPVf5+RSzqGQ5e+8kSMSMwI 9kDrEBYbz9LmpO0l8UlClqzdy3kZGunS4gXa85rv/g6jkIXc1gBicsBgXew8/+sQQoZg ZQ4lH1utQWz1+DNnm75M/t2dHpbvWir/UudpA09J1oprZmmwgDSxiGHAA2cs7DNpu5c5 ZZiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692652940; x=1693257740; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xce0vmMn1gvMkKEgP8SciOlKPAtITGIb7QGEMytqaF8=; b=ef81V5T6ZZMaBR9t1jzXEB9xMkWukXeUDlWQpv0xGk7Ry/ndVs3fRIrMgMhhNAcryy FN4cOTPuRNp+M4iKFDOSQdjb6E+AWrNsA3KJrDK3MW+QOjYPf5wN2JDLdgVVtvuO0RJ6 rdg/3EehOuuN5o4KNvHrmmzQ9a2mHstOeA8iijDcaUdfbz5jKCe+D33FXjgdQA+CfLfQ e88k/Vngs7gvynUiDsmGMZB7nzGFcSZV+ym5DAI6wLyz2JCaJUZ36Z/TuJDpA7sXuMq5 jbt+w+lyx2pnkNv+lpvJQPILBOwI0RAfEy6i0/8aB0TPR7cbKPWsVnirm12y7bzTmSdS OJcA== X-Gm-Message-State: AOJu0Yy4WYHvwqa4xPxX7jxeVlBrV8twy8JBdmX5hCdE7fEVreF3nTCn hEMKZLfkfCjbi6JyRVJSriWL5g== X-Google-Smtp-Source: AGHT+IHBAB4GS08K6S/HYAbBsfqGccIZK0IyQOFY1AeNje6eraFnI5xfEwxkuq0fB5uCSRGT26pKFg== X-Received: by 2002:ac8:5e4f:0:b0:410:8bcc:fbac with SMTP id i15-20020ac85e4f000000b004108bccfbacmr10068053qtx.7.1692652940437; Mon, 21 Aug 2023 14:22:20 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-699c-6fe1-d2a8-6a30.res6.spectrum.com. [2603:7000:c01:2716:699c:6fe1:d2a8:6a30]) by smtp.gmail.com with ESMTPSA id h20-20020a05622a171400b00410957eaf3csm1101726qtk.21.2023.08.21.14.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 14:22:20 -0700 (PDT) Date: Mon, 21 Aug 2023 17:22:19 -0400 From: Johannes Weiner To: Zi Yan Cc: Andrew Morton , Vlastimil Babka , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/8] mm: page_alloc: use get_pfnblock_migratetype where pfn available Message-ID: <20230821212219.GC106501@cmpxchg.org> References: <20230821183733.106619-1-hannes@cmpxchg.org> <20230821183733.106619-2-hannes@cmpxchg.org> <4DE7DCEA-796E-463A-8EF1-FB441BAEDD96@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DE7DCEA-796E-463A-8EF1-FB441BAEDD96@nvidia.com> X-Rspamd-Queue-Id: 6EC12100019 X-Rspam-User: X-Stat-Signature: fuidtmf58gowpghqazgzji9xzsadh7eg X-Rspamd-Server: rspam03 X-HE-Tag: 1692652941-791064 X-HE-Meta: U2FsdGVkX18u2SqftXfW2s/lI6JUzmNNVhN7DIVg+Oc5A+khdHweasX81diUEsvErROX2tIOCD4/FVG3Spj8Xq0V7tPDmjhmQESX88eNyVClgT62wEr0hzEqkaYGr5sMBGRh02Ihul8sLZaZEWFwQMac9LVsYXMtd+2uFwwFYDh1tAlomSfCi2JM0did0tSDCzdobJ0187Tm2Vx0Xr+pwonrNCWU7vLaL8ZJ/yMKwndWu73IVuJrSqj6tuRs8vFfM1BYt0etos8Y1XGkXJax8BnxZTcR9xICWNdvAdSNnGk1RUbCPb1eZxPjHP0nJc0OR5Bsq3uA1PrKDJe2dSx4ZDTNWT4UcRvhKkNP02XTu3kSPeLOCm1i/uxpExH4+FRi/1uE6J28812S5dSCEAgS7fN4uT7pUaa5on6wsId83L2TxTF1nHlBTT3SMRKFT5M4mE6EcT+FkIoL9+hxURo4ll73wMWyc7TxCP33whASUuRIOV58tnJMFek5Uwn0OeRKWOsu0QWVKfasntfVufHRj+DWZvDyp4/jYUChk9PmKFWCmNAyUp4uiBPkamID4JJF62xgvrKwvQyPUHwOV4MZd+o6v2juGgKnZhJE2VtwbUdZHTvxnMfqd3dqQ2nY46qKoJImi3kYwi9rJAoJl/o/zvIQRH2xkz9UG+T5hy3Lli6n/Gxc2MF+y6Xh0qgTFyxPo6f/+qMY5N+422EyWfEtlRCXVRyoqehbJTAdZATe2/9yYEeUhTjgO/RhQDG+Jhc/uc2csWTUzs8KI2IRZPPJSvLcEev8tJkTc42jDVgtnrwcrfGqQOPFubLdq/GGDw7ic5k2Xx3UcHgT8v5X/V3YhaLowsW+7hRIxMJmL57KhW3dpGVtm2G264ppuJE/cSRASoS7xba9F5/e3MP5LeJOkcv7Slt/AEKtfGM/Gi5qKVadko+xRXTW34FQZ1iH3PQofUdCCv9ulBjVR+/ZY/d +wYkgfU1 D15wcdi4d55h3F/pg9cHzXVXxC9VXZ7TVv9Zci78GjrMGygwtgFHubtKCZmR59Zk93XPTXRCHqCUN81uVEl6R7iGnv1KwBdrkp1sn/iLxFgj8eZAjXHUcIlxzY6UhhC8lO8gnVScxGlVPWePK2EKMB8bVZU1yOtJT/xkxqVFwbyJVN7vUJzvZZWWN/KysSR3rYt6YYt5CGJwpR9LY8nheO3rIGiKkS51svouvNFqz9XlqZwOa5vX2i1sL+60ydLlOF8+aYL1o3/UdJI5GjPqSd8E2jHQ5BzdsKLzJSfrRQ+Ql2IWTTx5sHeFeDp3VvLD5BsX02YQUO3ABhCPJcWTmVFF/PPRyLB3YF+l0vkJPpkK5clYRisTsQ8MxnWNlDiBdi9dgsjbODE5lNQEpabK7Pqc50DKGxG9hpDSoGxv8dZObDJuJbarNK9nMPIKpr7jcWn49vABOaN2XZxPqoKZhu2OdZjjgUWeUTh51ys6jIKhomdYkSSpWfjX/m4kEwyUxdeXVj6HvYSbSvvbHeYUGEGnoklJDpZcBHF1Po1U0Sjze7o0c+Aq2RXSUIgysWn7FbT/iyrlnXanoU3ErfauLLTpZNWs7kXXHo7SDSVfedijVjnY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 21, 2023 at 04:29:36PM -0400, Zi Yan wrote: > On 21 Aug 2023, at 14:33, Johannes Weiner wrote: > > > Save a pfn_to_page() lookup when the pfn is right there already. > > > > Signed-off-by: Johannes Weiner > > --- > > mm/page_alloc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Just notice that it is already done in: > https://lkml.kernel.org/r/20230811115945.3423894-3-shikemeng@huaweicloud.com Even better :) I'll rebase on top of this.