From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD9AC83F06 for ; Fri, 25 Aug 2023 22:28:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 422D5440009; Fri, 25 Aug 2023 18:28:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D24B68000E; Fri, 25 Aug 2023 18:28:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2748A440009; Fri, 25 Aug 2023 18:28:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 146A868000E for ; Fri, 25 Aug 2023 18:28:33 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B800F1C98E8 for ; Fri, 25 Aug 2023 22:28:32 +0000 (UTC) X-FDA: 81164067264.15.AB52421 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf15.hostedemail.com (Postfix) with ESMTP id E6297A001B for ; Fri, 25 Aug 2023 22:28:30 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=LAD89c+g; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.180 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693002511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h8jUx7iw70g3n6oT1VXilWUTdEYZ99rx0FoJBfC0hcQ=; b=MQp2bBRBNSOXgw+wgLJ/natYgAuLkuEz2JzXi5QASPi8VkMTLHZXjdBdov7/P3FIihH/Uz lo483zvC+6tnMTvjTyd7mYaXrAuF0oSdNZU+9vOG6jV64IAllkJiW5kPkHSLa5Fziev+Kr /QWltX5h8BbWn7bjN3SikommoIvy04Y= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=LAD89c+g; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.180 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693002511; a=rsa-sha256; cv=none; b=jUV3Z26idwb1QGZeTr4JHDC/2TRbGcUX24M6CJu+S8mVEOiyZDTjb2D2vEy63d70tdSnEa 0SnmpIAoy1ig+hlJkapctHhTeuMRcjZy9qfrq9mPeGYN3VcAZ8ekhRgS75Jr1nheqjC9wj dwPkWtzvCeqG+LTE4shKmKAsaLWnOmQ= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-68becf931d0so1154955b3a.3 for ; Fri, 25 Aug 2023 15:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693002510; x=1693607310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h8jUx7iw70g3n6oT1VXilWUTdEYZ99rx0FoJBfC0hcQ=; b=LAD89c+gGUDuT5PjcCMIvYuA1c3LCQ7U5nJbYQU6HlJzlNM7GtUP1bfqNd3yeeA8mf CxGhvvVZD/o9rYVKZJ+5sTWZECxzqjro3ZHPsepwwRectEAGU9GJEPrkwgIogFf9F9JX JxCtvSELwDLmc0QZELEXlvzx8UQZ6rT5MYfOM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693002510; x=1693607310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h8jUx7iw70g3n6oT1VXilWUTdEYZ99rx0FoJBfC0hcQ=; b=XjoWYndelXdp1xvcm6G4ZUCh+hGpWVsh2Z2cVc4pDLiIDBtXbHAWTly2Ytw04MlV/h 21N9BnTAUPBGUscxyFJFENM+8QM18sPljnf6VsOoCTKED2zt0pz2Efv5cKS9GPp0ZPny YSAW7pPOuGxvLmVtQLxAGtyutVhjZC3Apzv692Kx60PUY7b7lKdcGvMABbydfcS2ysMu PGMkXS1u5gFvZdjjSwynSa+N1dX+MnyAxeq3OI7gUcC+v2hjKcIwKWIpDE5d9cGuqmlv 4qxLZxxjHHS2XP+PdTg2rYUqh92bDdjATJGxWGvMsm9vBPT/4SI9UIHwoPwdZC8yYLeV 9/uw== X-Gm-Message-State: AOJu0YzV9RGmWJJeKQ0CQrvOYlurRhPa4YGFgNI5ZBlCQpgVO8G559g/ FJVHqkjPfs7AGS/6yxTEKw3UGQ== X-Google-Smtp-Source: AGHT+IHe3WDOcAo8v3TLTNHzQM/dioBQeEFsUIGCrxTbXjYQRVduwZsvHc2uqIQMogZMTr5uBPntzw== X-Received: by 2002:a05:6a00:1a52:b0:68a:586a:f62 with SMTP id h18-20020a056a001a5200b0068a586a0f62mr15300829pfv.4.1693002509735; Fri, 25 Aug 2023 15:28:29 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id l4-20020a639844000000b005651c9351e1sm2144974pgo.64.2023.08.25.15.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Aug 2023 15:28:29 -0700 (PDT) Date: Fri, 25 Aug 2023 15:28:28 -0700 From: Kees Cook To: Florent Revest Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com Subject: Re: [PATCH v3 2/5] kselftest: vm: Fix mdwe's mmap_FIXED test case Message-ID: <202308251526.E350861ED@keescook> References: <20230704153630.1591122-1-revest@chromium.org> <20230704153630.1591122-3-revest@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230704153630.1591122-3-revest@chromium.org> X-Rspam-User: X-Stat-Signature: mamdx7zbbxxazcm6w9pdaqcm1zfg8s4b X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E6297A001B X-HE-Tag: 1693002510-768753 X-HE-Meta: U2FsdGVkX1+Fm4464Wz/GdgMXWxCFrJi4Q6WyhbzqP4OXOQP/4ih09Yw+4l3kEvzDkpWyhvz0rnAZtuANNSUEfZrVqqrOaqc+aF6O7pUBFCIjlCsJT2n5uk+FpxoiA1zIeozPkPO8aCBxrtzd9QGIufuqQSpVD3BcM7PGF0rt2mhjOPjlyhYvx5fwYifao0QZeIgEjxYd5lFGBNpwM+sPHtN534BbkM1gx3mnPWN2+7oj+bpfhuV4ppVANMdblo4Y7KcRudBJK+ZxyMD/xbcLTHv/AIXzzZby0qHH4LSCJuLRcGtMMr8HPbmbLfHW+4FE129pSnHHnM3443XbMf+FLJpbFkMSFk5qVx8BUIc+s8NzQlN8SF+3wa8YdiLJXvNueA+oFD33k1UMM9TU6DcA/NPQkK0AOs9t4CU2BUkAc/0he+sEcdLf4eMB+mGunrfsNDBE7LNo0xjTYhHQ3A5HwpYUbG8Fk2XJl1vsVFMlo7kr+RWp+zJFFHFqE4PxDX17l+cQztxyhhQj7eOBNOVvMZs68tD/lXqX83hr6DluxN8LC6FEcfNMZjnqliotAov3WBgrHQT7xN2qtP3rS9sZN+CU7D//Of4ynsuJWlKSWYmy0GJB2fWjJRRqEs8y5P6gvbcrF1zGHWkMcXaMw2L2hfOHu5R0IjfZ11nRjCqAImaZdaT2rI1sNSwXLNUnF+DQE5CiKt6oT1Ci/5yA6h7ZbckT+ltBg7b7lPzsLkjIvVjiAbvxSHGYTtZJYJJ5p5SCnXwbowyDRK7jmki1LENRCrFNSNZQJ54b/X7EZgOyhUOUA8JIz5hT5OBlDtxkXZyY3B8p7MCnCjrcf+QkkqEkNvvhJ77NWwTaxPXJkTm1nOSkhErdBu8ni5OzoD6ZEORio3Yk4PQGBwZQr6TbB4I7HeT9pk37NaMdpTdnnuk9gmslIIwGg5naMNRVGUpLorV94v2d99o+Yyh1QOXetX jaVRe2t5 w7YXAL+4vTuRG9nFFfcRtxd1eLBxSr0VHuD5LSVINy2q8LombKizyQZUYQtHpFVpGG8fP8uPsKx+Yi5igSseR4jmdWQd9V5SVnVqYTNnb/Q6n+iH9wNAmtLIK4m4fSm8wseDVCQ/TWnQvo9p4WJ83ZwYrYgCDeSpaw1tV5j5b0dsi2Y6qFMAR2GO+8DAzB0srsK84tBmRFooqr1YjenluBGTei0q0VDJNnKt2g5iX77G3BlDY/6vxY9JgH8mn0OiCk/vDJR8yYXckx76WOrWM97j8kTgW+oFfEAh1diBjTpPyam5CfSKM+m6jYmScbTRCWplJUDquPAXPDhtQ66XlE9HaTQBF9rQRN2HfygQ43YWLscFEb0oCgIwvlp5wCTSOLUBU3bnPpUlMjhCJLMEOAmu4q7pWLGhFpa4wiHa410cynWUvcPzvhfa0d3zmWoNhiQtfh5pjHYuo+Y14/RvGLltrlq8Tfm/KdUXN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 04, 2023 at 05:36:26PM +0200, Florent Revest wrote: > I checked with the original author, the mmap_FIXED test case wasn't > properly tested and fails. Currently, it maps two consecutive (non > overlapping) pages and expects the second mapping to be denied by MDWE > but these two pages have nothing to do with each other so MDWE is > actually out of the picture here. > > What the test actually intended to do was to remap a virtual address > using MAP_FIXED. However, this operation unmaps the existing mapping and > creates a new one so the va is backed by a new page and MDWE is again > out of the picture, all remappings should succeed. > > This patch keeps the test case to make it clear that this situation is > expected to work. > > Signed-off-by: Florent Revest > Reviewed-by: David Hildenbrand > Fixes: 4cf1fe34fd18 ("kselftest: vm: add tests for memory-deny-write-execute") > --- > tools/testing/selftests/mm/mdwe_test.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/mm/mdwe_test.c b/tools/testing/selftests/mm/mdwe_test.c > index d0954c657feb..91aa9c3099e7 100644 > --- a/tools/testing/selftests/mm/mdwe_test.c > +++ b/tools/testing/selftests/mm/mdwe_test.c > @@ -168,13 +168,10 @@ TEST_F(mdwe, mmap_FIXED) > self->p = mmap(NULL, self->size, PROT_READ, self->flags, 0, 0); > ASSERT_NE(self->p, MAP_FAILED); > > - p = mmap(self->p + self->size, self->size, PROT_READ | PROT_EXEC, > + /* MAP_FIXED unmaps the existing page before mapping which is allowed */ > + p = mmap(self->p, self->size, PROT_READ | PROT_EXEC, > self->flags | MAP_FIXED, 0, 0); > - if (variant->enabled) { > - EXPECT_EQ(p, MAP_FAILED); > - } else { > - EXPECT_EQ(p, self->p); > - } > + EXPECT_EQ(p, self->p); > } This is just validating the MDWE doesn't block a MAP_FIXED replacement? Reviewed-by: Kees Cook -Kees > > TEST_F(mdwe, arm64_BTI) > -- > 2.41.0.255.g8b1d071c50-goog > -- Kees Cook