linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, willy@infradead.org,
	naoya.horiguchi@nec.com, osalvador@suse.de
Subject: [PATCH v2 2/3] mm/page_alloc: remove unnecessary check in break_down_buddy_pages
Date: Sat, 26 Aug 2023 23:47:44 +0800	[thread overview]
Message-ID: <20230826154745.4019371-3-shikemeng@huaweicloud.com> (raw)
In-Reply-To: <20230826154745.4019371-1-shikemeng@huaweicloud.com>

1. We always have target in range started with next_page and full free
range started with current_buddy.
2. The last splited range size is 1 << low and low should be >= 0, then
size >= 1, then page + size and page will not interleave.
As summary, current_page will not equal to target page.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 mm/page_alloc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 88c5f5aea9b0..bb74b40dc195 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6510,10 +6510,8 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page,
 		if (set_page_guard(zone, current_buddy, high, migratetype))
 			continue;
 
-		if (current_buddy != target) {
-			add_to_free_list(current_buddy, zone, high, migratetype);
-			set_buddy_order(current_buddy, high);
-		}
+		add_to_free_list(current_buddy, zone, high, migratetype);
+		set_buddy_order(current_buddy, high);
 	}
 }
 
-- 
2.30.0



  parent reply	other threads:[~2023-08-26  7:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-26 15:47 [PATCH v2 0/3] Fixes and cleanups to break_down_buddy_pages Kemeng Shi
2023-08-26 15:47 ` [PATCH v2 1/3] mm/page_alloc: correct start page when guard page debug is enabled Kemeng Shi
2023-08-28 15:21   ` Naoya Horiguchi
2023-08-30  6:27     ` Kemeng Shi
2023-09-26 11:33       ` Naoya Horiguchi
2023-09-27  1:13         ` Kemeng Shi
2023-08-26 15:47 ` Kemeng Shi [this message]
2023-09-26 11:34   ` [PATCH v2 2/3] mm/page_alloc: remove unnecessary check in break_down_buddy_pages Naoya Horiguchi
2023-08-26 15:47 ` [PATCH v2 3/3] mm/page_alloc: remove unnecessary next_page " Kemeng Shi
2023-09-26 11:34   ` Naoya Horiguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230826154745.4019371-3-shikemeng@huaweicloud.com \
    --to=shikemeng@huaweicloud.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@nec.com \
    --cc=osalvador@suse.de \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).