From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6119CC83F11 for ; Sat, 26 Aug 2023 07:45:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC1FD68001A; Sat, 26 Aug 2023 03:45:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E719468000D; Sat, 26 Aug 2023 03:45:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D602868001A; Sat, 26 Aug 2023 03:45:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C712468000D for ; Sat, 26 Aug 2023 03:45:45 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 978121A014C for ; Sat, 26 Aug 2023 07:45:45 +0000 (UTC) X-FDA: 81165471450.19.116A22B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id D9C944000B for ; Sat, 26 Aug 2023 07:45:43 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=tOmOTOeh; spf=pass (imf12.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693035944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G2K9bDD7sIlffuYOGo85tRefCBxXQtiKevwFJ7bQxtI=; b=z0WpC/7kUwEDGavIKmiC0Ffrq3OP5LCO85IYJ40JeLkieYbSWeFeJYWxpjZWvUA0XZvqMU QknMbLcWSWrtBMfCxJlb6Kln5iZfRkVw0/7zTNdRHiuO0jX5tmJxWfrwcOnlj/jBnwyPu1 V7fXq7PUfoLUC33YPF2RiBiocYo3lr0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693035944; a=rsa-sha256; cv=none; b=lGXrs8z0W4OGpST4OFU4mlB5Q+YT/ieL9SifCWAmrS6SJ3+Y++OA3t2LIhpJ3WhcAHgjpT enRd/0sYY5TxfuFGsOzFATIER745cttJKn5ZSqYvBnN4HCZvQJbkMuWLKDTEjoD1EB3n/d xN/JVA+2QPZHzepb6hF6wNALVw4fwao= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=tOmOTOeh; spf=pass (imf12.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6B8460A53; Sat, 26 Aug 2023 07:45:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C335C433C7; Sat, 26 Aug 2023 07:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1693035942; bh=jbRlaGZgeH/nIUB92IrBZ2CS9Rn4xUf81ltVeKgCTS0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tOmOTOehfejMw6TmNeJ0go3TdvMF1LuCEe4T8izxS2NEhgWma/BTBW+qc0da+Fcm6 /1KSQMi6Mdt6/6j60RNIXcEOcypFugr/KwhKn/RDzRgJdv7uTrsz6VfOQ9BAwIaDh9 5z1uBU2iM9LHkw/fb6PPjAKvpTB4ReWzhWZUvFgE= Date: Sat, 26 Aug 2023 09:45:39 +0200 From: Greg Kroah-Hartman To: Stanislav Kinsburskii Cc: Stanislav Kinsburskii , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Wei Liu , "K. Y. Srinivasan" , Madhavan Venkataraman , Anthony Yznaga , "Mike Rapoport (IBM)" , James Gowans , Anirudh Rayabharam , Jinank Jain , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] Introduce persistent memory pool Message-ID: <2023082633-magnetize-cupcake-accc@gregkh> References: <64e7cbf7.050a0220.114c7.b70dSMTPIN_ADDED_BROKEN@mx.google.com> <2023082506-enchanted-tripping-d1d5@gregkh> <64e8f6dd.050a0220.edb3c.c045SMTPIN_ADDED_BROKEN@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64e8f6dd.050a0220.edb3c.c045SMTPIN_ADDED_BROKEN@mx.google.com> X-Rspamd-Queue-Id: D9C944000B X-Rspam-User: X-Stat-Signature: 9fm6tpj1hy4jdictjbmrhgdsryebdjwy X-Rspamd-Server: rspam03 X-HE-Tag: 1693035943-914852 X-HE-Meta: U2FsdGVkX19Zggl56pFEoxnzer5eXUOidP3I+jdDn7/IR5K9B61SFYXTAjq5vNHGX0RLS80zHhZM1vLC6aW8Bs2d8w1RdM6UBARUaOWSLm1YwJxnNdIsbyYhyAeXXcjLjmQi4t69TRel66rp5GsBIQfwFAnjf7pfOgiz8voim4olNd6U7V9C00byigdvyLmBp76q256R+ZlHQacHMScg2fGElEp6w3MCNfMEjLUhgJvthPeEFZWAbzQ8SvhIJxxjQbh1tl03DmKcS/tajhJollkYpE5G0eohKo2jIajBJ9FN/ZygqJJ1NGtOQ7Jlbr0jEsaSR5rN7ZKLCBMtZfi2VWcgmeEEb9zI1FqgbxYlUO7EOGlL/Aj6L7sA/RVA9+dDRrVCImNy1tOJKehQVsRJeFaupnwUX23r8f8aMEr15Kbx8Hlm2Oso5WN+xQwSPAcWbnXaMceVSfJDOJniTanROpXJP8xjxvydydS5z48iQ4v6VO+rqvQN7vd9v85+qQco84Rki+dTkDKGE1MQA/S5gz7i8Sz5T7Mqt8/5+2sqs3gbPHp4m0wUWgS9fzxGp8wU8Os0cauMTTu9aKamnF2AP5EvIli45bkJj2BlRTv5hXUzHoJStQZ+YeJ2bG1Ec5efvlStIR43bGtENEiqdvZSK7rnyT/DMvcerqB4BOEPF1xn5oEkdQe/ztPVFEmrfgFqG1hEA2r2kasl1tLW8gfrTmx7uRsaV2AfoOxfcwxNcCvT0aGgcyO7E955bmrAgkgm96lShiabHq9jzrq5SqsoGoQXoMENykdtqFy0g3kChgGrS77ggOPaRtkfUVZ+YrM6Aap4oRU2HKILaaMU6gEIsjFsRjy2BBG6oITDJTp85gU+FCUJH0WZ03fu1oK8Uqt0Z26C4h/NzWIsKmmaRABuJ7IzY2Gbij1r5R9GfvUiwkcK7pPtbXwPYHl3Fwkb8c1wSMPTtROg+fnJ9EGnCja 6R6aHaf8 5Ew2S3Q4RHy3eS0RT/MIBidZ1ReYlZIuE1M99y+Q3aTvvDK+Fs025qLzai3w/QTi6DCJCcJ7JlmJV3/b/p3KMyD95fRu/DZT7o6tlIMLhjquBM0Oq6xQfZ5GfaMjBQYnIKGXdOxatNRiWIWZ00hyMe1xq03eKul5l6xrBn+qfqKq2Xdn3QgTClC+RwnvT+8jxz7BOp4Fr3oYoqeeK0B09DHm0Mw/ZhtCCAPdnhXv2wLPqRYJ8Be2sWdVuYbHIi/Ex2g2gaLCFxrpCq1BBaMuQ3sTrCjmPZsQmA/THadxjIbqiaBpiz+6q6WKdmreft9GKeIVLdwAyaLmSX99GIolid9Gz5gyYjqIRP2N0ccn60ZcD0PhtsnKgOKbsKn4o6Kw2lMT1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 22, 2023 at 06:36:10PM -0700, Stanislav Kinsburskii wrote: > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include > > > + > > > +#define VERSION 1 > > > > In kernel code does not need versions. > > > > Could you elaborate on this? Should kernel version be used as a backward > compatitbility marker instead? kernel versions should never be checked for in-kernel code, so I really don't understand the question here sorry. For code that is in the kernel tree, having "versions" on them (as many drivers used to, and now only a few do), makes no sense, especially with the stable/lts trees getting fixes for them over time as well. In short, there should not be a need for a "version" anywhere. thanks, greg k-h