From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B34EC83F12 for ; Mon, 28 Aug 2023 07:38:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FF4A280015; Mon, 28 Aug 2023 03:38:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AF71280014; Mon, 28 Aug 2023 03:38:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29E55280015; Mon, 28 Aug 2023 03:38:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 19C9A280014 for ; Mon, 28 Aug 2023 03:38:17 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DC271C032F for ; Mon, 28 Aug 2023 07:38:16 +0000 (UTC) X-FDA: 81172710192.26.83805F3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 33924180004 for ; Mon, 28 Aug 2023 07:38:15 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JSS8T3rd; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693208295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qRPY48ADJYN8rHn8p9RW3VQcuXJuIMnpP0qj5GsWNv0=; b=b1FW5cAOaih3c3H5rbgaHQvsCrDi4yCJKZLcLKQGBXXYDO0W5H6GgQM+b/Xj1fcfQXrGuV ZrLIM1xEA7Ql8cNV+bYNK/CBQOycAWNBjRe2vOlJapPi8QnzYQ/URxrICKaKfnfhEpVVdQ SUL61Acak5JmghnTXbQwvfmlY76UkXs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693208295; a=rsa-sha256; cv=none; b=Cph9lKRz4NWRXBkNnVWXdNY9CevF+HN3kq2a8PSKwmoLLMzzIb1usbKrjlgxvcgRpmDtpQ EBW2QSP6IU+8OfjbpGH8sLOWLECv5eCRoZe2VqTaN47iX49MkNlTejw0dIvhLKQXLuyVUl WIbAltla9hR1+jIb0L7MG6+LU6l6g7U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JSS8T3rd; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2864C613F1; Mon, 28 Aug 2023 07:38:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FBE7C433C7; Mon, 28 Aug 2023 07:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693208293; bh=TN7wbrdH1LLCxeTtgWlrErpBeefbe8IFjcDcJDLmDEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JSS8T3rd6ZgEuKWd2MhhYQ+WddolJ03LE7uXp9cgN1nypR51eQpff7SMTGA1DgR2/ VExGTDeVRgrXtpGyEDRLu7lQUOrkNOj6Cfy7KDKDfVC9M0CT4b8yxdmZGsrb4N7rOF zSE8lvQ/RdKQ2u1Aax3I3OSa2jRnDvlyUNI404Mhj45+th5XcHT0HhdrecJJd0Fwq2 KiSVBF4oJYLgGFhPAKdQ97tzOxoS9ufgUH2UgC7h8MQLjqAsxUTY/W4Ip/9gdsL7+S SPfHYkLKkTJ+VYgmr6OShOTtk/oyH8gfkX9XepqdzWh1wWMjuPuwFNcIkt2tj4g8HM Q27IBYXKf6BSA== Date: Mon, 28 Aug 2023 10:37:39 +0300 From: Mike Rapoport To: Usama Arif Cc: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com Subject: Re: [v3 2/4] memblock: pass memblock_type to memblock_setclr_flag Message-ID: <20230828073739.GB3223@kernel.org> References: <20230825111836.1715308-1-usama.arif@bytedance.com> <20230825111836.1715308-3-usama.arif@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825111836.1715308-3-usama.arif@bytedance.com> X-Stat-Signature: zg3gxxs4j3a7qpzrazm8f8xqcsesy3mh X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 33924180004 X-Rspam-User: X-HE-Tag: 1693208295-247526 X-HE-Meta: U2FsdGVkX1/JLVPwAZJRgNf3BaRdN3I3ZTDvbYG4IeAB+qQKX6AHdtnwPxlfAD2wnSHVVxRdgN5K7j7BbEchdIHrfRj4OFsBvhv8wCaWAGbxE2eA/0nLLguJ7w9neiyy8Fs4hpphnBxt8IacBt7Brv/3BOzZppdKnCu5CUJA6xPtk30WuvxROFWKVYMhEcpAyYCzQp942vHnHYDwXbFrFJ0mx4x4J6Rtp6BBjbNx3+sjlo4Iz3F7tMyMkdQ762urdgGm95iUovn5pMw3O+tQxgitOoFHD4NUjTuFi+/jxGpcRuU5GSLcyJMTw82Rm9beF67W8TV22dE2eueLCfyR8IuEi4Z+7l8S2JRsZM3qYtV90usCTmk0X0xDpaKZH+e61aarduUGLLP8kCIPmuhNCulSadaW3Prv6CDhF0zRa6/kCANst7EJQxQ0k5uRlsJDWWNuCiyFYowowyxUcuP7ci6gpGDmQJx9nPREcMP5H8AAw6jx0ENyHxthzym28s2JAnM6eG+CoPDMN72RZvSUneuIfmrD8LBJ7BO0mZ1GQmpeYr1QAe8g1uC/KdB2So5G3dlUvu/9JUJPbI8rcYbW5grmXGXD24K9994vAqXur86o8Km6rMfzMV42d174xYL6IiOJPOVaN3+Xlv6VIYklvqJ90WUnA5FwggcqsAsWVWHKvdms4kTfjXZG9NjYPhX8lKlPTAHfgc59/CZoBUyroYwTEXmnQK6cn3+I7Jshj/81QQD9nOiAGUEFrz5ZCmYS7/7WqE+jx49OI0tOCpjNd3S9pquwHy2RYLWo856F0tNXytWO55dkcrtmn6n6bHsLvfugEsediR6zRz8OpcW+EeZ+pSMbwqTDO0iqjlFodgzQzugxIuGC3zCK94tO/D30tV0xSatgYGKHjgQHPdbc3uodtJ2FbKfX0VUDIuRuK3Vc5hGF6LzTeFVc5pRsHCiS0BOOiaqOKgBpf7bs1w5 FfckG/aG 499IgajTE+fQA+fArc8uuTfVWlEOVxBf1JmHmJX0cEtIhfVeNP9BdHZOwXu3KzIsitIPGgDo26lBFq4NR/kifwEDVQKuC0/QTaqo5fI2fhLkpnXBiUXwb3KDdHWNUhKw9JpMbMlwnuTCPC7N4uGCA/7IEPBzo4BX0khH0Vqmo1L+4eJWOkoh6ynB2pgm8PKt+DatALV/CQe7PmMFJTED1LiLIVcSeYcfD11lpCQKGGHOYS9r70ZOIDb8+I2hZ3y3meP4tia6m4koQHYNiu3PspfCcZefWZwEjin3Wg2u1UflbTUJ9jb6T+jsCYIHqDGqt/fm5PhVYBeAMaiVI2S/XS5eOZKIC0P4kGheTwlKkCJIIDHErL2KZLgHUq2t8ucccP/0F45QLitks6cU6chkNqq79TuQuC4+Ww13oZIBsU7gg3wCxCCKnTO3gweWHr5G1W1mEUHUgIFKysAU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 25, 2023 at 12:18:34PM +0100, Usama Arif wrote: > This allows setting flags to both memblock types and is in preparation for > setting flags (for e.g. to not initialize struct pages) on reserved > memory region. > > Signed-off-by: Usama Arif Reviewed-by: Mike Rapoport (IBM) > --- > mm/memblock.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index f9e61e565a53..43cb4404d94c 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -896,10 +896,9 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size) > * > * Return: 0 on success, -errno on failure. > */ > -static int __init_memblock memblock_setclr_flag(phys_addr_t base, > - phys_addr_t size, int set, int flag) > +static int __init_memblock memblock_setclr_flag(struct memblock_type *type, > + phys_addr_t base, phys_addr_t size, int set, int flag) > { > - struct memblock_type *type = &memblock.memory; > int i, ret, start_rgn, end_rgn; > > ret = memblock_isolate_range(type, base, size, &start_rgn, &end_rgn); > @@ -928,7 +927,7 @@ static int __init_memblock memblock_setclr_flag(phys_addr_t base, > */ > int __init_memblock memblock_mark_hotplug(phys_addr_t base, phys_addr_t size) > { > - return memblock_setclr_flag(base, size, 1, MEMBLOCK_HOTPLUG); > + return memblock_setclr_flag(&memblock.memory, base, size, 1, MEMBLOCK_HOTPLUG); > } > > /** > @@ -940,7 +939,7 @@ int __init_memblock memblock_mark_hotplug(phys_addr_t base, phys_addr_t size) > */ > int __init_memblock memblock_clear_hotplug(phys_addr_t base, phys_addr_t size) > { > - return memblock_setclr_flag(base, size, 0, MEMBLOCK_HOTPLUG); > + return memblock_setclr_flag(&memblock.memory, base, size, 0, MEMBLOCK_HOTPLUG); > } > > /** > @@ -957,7 +956,7 @@ int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size) > > system_has_some_mirror = true; > > - return memblock_setclr_flag(base, size, 1, MEMBLOCK_MIRROR); > + return memblock_setclr_flag(&memblock.memory, base, size, 1, MEMBLOCK_MIRROR); > } > > /** > @@ -977,7 +976,7 @@ int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size) > */ > int __init_memblock memblock_mark_nomap(phys_addr_t base, phys_addr_t size) > { > - return memblock_setclr_flag(base, size, 1, MEMBLOCK_NOMAP); > + return memblock_setclr_flag(&memblock.memory, base, size, 1, MEMBLOCK_NOMAP); > } > > /** > @@ -989,7 +988,7 @@ int __init_memblock memblock_mark_nomap(phys_addr_t base, phys_addr_t size) > */ > int __init_memblock memblock_clear_nomap(phys_addr_t base, phys_addr_t size) > { > - return memblock_setclr_flag(base, size, 0, MEMBLOCK_NOMAP); > + return memblock_setclr_flag(&memblock.memory, base, size, 0, MEMBLOCK_NOMAP); > } > > static bool should_skip_region(struct memblock_type *type, > -- > 2.25.1 > -- Sincerely yours, Mike.