From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 162BCC83F11 for ; Mon, 28 Aug 2023 20:10:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AFFB28001E; Mon, 28 Aug 2023 16:10:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65F728E001E; Mon, 28 Aug 2023 16:10:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5275D28001E; Mon, 28 Aug 2023 16:10:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 425FC8E001E for ; Mon, 28 Aug 2023 16:10:19 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 149DC14053B for ; Mon, 28 Aug 2023 20:10:19 +0000 (UTC) X-FDA: 81174605358.20.C36BF90 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf01.hostedemail.com (Postfix) with ESMTP id 295EE40027 for ; Mon, 28 Aug 2023 20:10:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=opnfX7b9; dmarc=none; spf=pass (imf01.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.51 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693253417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ToWphglk+jIuHakrdkLEs6Kl6awIC29pkULLo3yXCKo=; b=Z9Or22riUR6ifbgkgcOsNJACN81FToF/l/DhrfNdgPBbbXiZPAQSlJPSXQNasxPgkVQQaM uQMt/6iZ64pETl57dFs48EIVWbPPsf6WWlxX+YN5CLtZt2U6iJ3tbyHmCTPtmCUwH8Wwc9 0EMcAToa1efQB4dzyBequAYbQdHzBO0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=opnfX7b9; dmarc=none; spf=pass (imf01.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.51 as permitted sender) smtp.mailfrom=joel@joelfernandes.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693253417; a=rsa-sha256; cv=none; b=DAkDwt6utLKEpQgglmK+VaxFYUaVMbXBmDnii+BgPO320A8G1Df+1opubuAnYZX6/STsfi T19ZKNhac6JF7oLBUM+P8NSfq21TurqEUPclXWDuxaO9EDtCDPLSMDhJwRR2PfI5BemO10 2hlpKB1wEphb04SQiWIHdLFlIUwOrsE= Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7927f24140eso118590939f.2 for ; Mon, 28 Aug 2023 13:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1693253416; x=1693858216; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ToWphglk+jIuHakrdkLEs6Kl6awIC29pkULLo3yXCKo=; b=opnfX7b9FR3Qkgauj6UCrsY7xR+J5wJYa42+TByn5zs9WuIDdwBZ/EyWTlLxHjGozd OWZE/Jpypl+dCk7Ci9R8//E58DBdZQD+ygj2hIVUa85drAGTVHz4nZCUeVcD3J36N4JP Ye8g8HF+YWnBiCSglWYj4qaKxJdQBlO9dphiI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693253416; x=1693858216; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ToWphglk+jIuHakrdkLEs6Kl6awIC29pkULLo3yXCKo=; b=MgsSv4mGArkYnpdQN/Be/UagbHh+4KaJLppd9vZ4Vgn8OTKP0J1wzxTK1MN3Ab+XxP xnTmyS9Yq0cH4AxgFccDdfxo0OMftQsGel8mbeW6jLbgCHhpbFuE3DLvYKzVBgBRR5nN 8ESTDE5vYv3DWTwUCYcJhveqyhFD1Y2Dj7OPdYxFM3ZgGw4PyzvwuI08dlbgYUMbpWjt IHcpvqojtY45217pOhZmJpg2QQM2P5HVm1p7RzHLYOO6+HHcfHggbKCsNk+Hu0SDVlx4 xUf+Qm1VuZDslEVE4uY2RVnNxNYRThbUrjKz65b5G2AJynaMZEHhgFNMIeMV70SxsGew v+0A== X-Gm-Message-State: AOJu0YwHpPgtbvyejhmq0g2uKBjK/i0xNMFN4SHXjnaYfpkBTOvkCPy7 o6s6Jr3MgzD49L2pANmV1AcPuw== X-Google-Smtp-Source: AGHT+IERYLuZL1QL0QoiA84CN1/KLm1TA2o4+eMMfgLcKyh2olmnmGGumOzk6cul2wISK2HloiBTXQ== X-Received: by 2002:a05:6602:4250:b0:792:931e:a93a with SMTP id cc16-20020a056602425000b00792931ea93amr7871160iob.4.1693253416305; Mon, 28 Aug 2023 13:10:16 -0700 (PDT) Received: from localhost (156.190.123.34.bc.googleusercontent.com. [34.123.190.156]) by smtp.gmail.com with ESMTPSA id s21-20020a02cf35000000b0041cd626ea0csm2704691jar.147.2023.08.28.13.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 13:10:15 -0700 (PDT) Date: Mon, 28 Aug 2023 20:10:15 +0000 From: Joel Fernandes To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: Re: [PATCH v5 6/7] selftests: mm: Add a test for remapping within a range Message-ID: <20230828201015.GE1621761@google.com> References: <20230822015501.791637-1-joel@joelfernandes.org> <20230822015501.791637-7-joel@joelfernandes.org> <08ce8c61-e7a2-417a-a3cc-d20861753ae8@lucifer.local> <20230828185912.GD1621761@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 295EE40027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: d39o5phdncy6uu3xoekidy4foghetu8u X-HE-Tag: 1693253417-446152 X-HE-Meta: U2FsdGVkX19AutzzE9YZcsvgFSFjbp7NzT0BO5zkx9CS0R4n8zW3GDn+KORBJ/TIq0mDtw39QbWXZR4Vtal/3eFKO5Fo1Ezvut8vyg/yTjhjBZ84dxYgoeXf+PEn4uZglyVBliWo5XcDTSyFYNV+kPTe+Mlw3NKBGo9irnLHJ7n8SXmkgCK7GCyRcJKFYa2eNWbsjR0NzL4qcLRSGPGkpQGP5jt5Hb1DqzRm3TEp0JSq1ULxlYJDa0PU0XMF/IyCjPdqkcK0s0YC5OaLOJoZNJitI5f3EKZi51JYyU/bdfFg3PQGegafJl0sw0g2cQtGcnradNc5Ka3ZuxH8dl9fQVNh1vUSQ+ERDawZOZvQz9V/XswXLkpggMdEdHmwbvJ2Mw7H54yPhXaicrl8wCqZOipeZB7NkFghQhzdB3HwsDQlXKX25oNiBd0L/M6YC8Yqqi697Hr3IH/9hC7jINJ12at4+y2VT4PpECA3ZLR1/c9VM9o+jHSs4dIvQwngGVhPV6CJBoiZsUyIZ/zCFkYnpSkhQQbf8taZO5arsyg6gzD3SvuwYnSD04Az6i0Q1dMSrB9E46yFoC3gEe7tPOSB0lp3m7n9HtClgk5y2IonzQWYE0btXO+wQDUPLsyjVzoURUduhZ9JSH1a0IrJADu5+K2TFgfcPbjNeENKk5myddJ8B+jNiHh+8NY+KkaYTatEkgqwcYjkzwm8DrhK8Warjz1O+P+nkw08ZVRu9fZpDEQZghvUydLjkyK+UKqi+N8W6oVBpO1GFHIVOVrvizCVFbXHjOkxoaCEYHgDJWavVDgG+Eb0Yd72ZoswzQWDFWs0izWVv1OT/wD/xcc3OZ0sEhYNZ0uOENXyFc4nrcesAiaQN++nwG8EOkYtEH7VgynIsgHOyWLeIV3Zc1WKApF1/JY3qIKxbzV5QH4KM6+1m9LvztT8qGwoo2SaWL6gwCelP9p5Z29x1Wgyw4bY4x8 2z3wcJiL iHRxyPsJm6LOH8qZ8HS8h4f+FTpmnGTE6ES2P25a/KrwRiGGx/1dbp0SoXgmj+Ud6U8KOa8NUEbOtDwnocBccL1w3QN/OQ1FK9leNWN3j/aNfJilVL0o7/TLvZk+UxFdyFwz6G2Vyy1Fac0EGIpxQd424P7wTRjZ6/uBSA447YgA1VL3Obqx95d12nhqI3aU7I600dFVX58KhwAbRTKPAi57UaDphK3fLBmdwrM1MvauHKwX1bA/K7HvS9nji1zWp/O0zl8scIjQVAplEV1DcwRSM2PvskoVE6PF9zaGUTUwj8yWMbB6fjUyc1nLy7cRtZfn39yYNKMXTWV5OZkLqOuEttiEBeMZDUjmk28WXZpKPb1UV2DycOp4nHZLh11JoT6Ew X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 08:38:17PM +0100, Lorenzo Stoakes wrote: > On Mon, Aug 28, 2023 at 06:59:12PM +0000, Joel Fernandes wrote: > > On Sun, Aug 27, 2023 at 11:15:20AM +0100, Lorenzo Stoakes wrote: > > > On Sun, Aug 27, 2023 at 10:57:59AM +0100, Lorenzo Stoakes wrote: > > > [snip] > > > > > > > > +/* > > > > > + * Verify that an mremap within a range does not cause corruption > > > > > + * of unrelated part of range. > > > > > + * > > > > > + * Consider the following range which is 2MB aligned and is > > > > > + * a part of a larger 10MB range which is not shown. Each > > > > > + * character is 256KB below making the source and destination > > > > > > Just noticed, I think you misspeak here, as this test doens't seem to > > > offset by 256 KiB? That is the strategy for mremap_move_1mb_from_start() > > > rather than this test so perhaps comment needs to be moved around? > > > > > > * 2MB each. The lower case letters are moved (s to d) and the > > > * upper case letters are not moved. The below test verifies > > > * that the upper case S letters are not corrupted by the > > > * adjacent mremap. > > > * > > > * |DDDDddddSSSSssss| > > > */ > > > static void mremap_move_within_range(char pattern_seed) > > > > Here we are moving 1MB within a 4MB zone of a large mapping. Each character > > 's' or 'd' is 256KB. The 256KB there is just for illustration and not really > > significant as such. The 'ssss' is moved to 'dddd' 1MB each. Here we make > > Ahhh I see. I find that a little confusing here, perhaps clearer to say 'each > block of letters is 1 MiB in size' or something? Sure, I'll do that. > Cheers! Cheers. And thanks for the reviews! - Joel