From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF55CC71153 for ; Tue, 29 Aug 2023 02:13:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F18038E001F; Mon, 28 Aug 2023 22:13:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC84C8E001E; Mon, 28 Aug 2023 22:13:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB8B68E001F; Mon, 28 Aug 2023 22:13:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CB1588E001E for ; Mon, 28 Aug 2023 22:13:46 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8DAF8805DA for ; Tue, 29 Aug 2023 02:13:46 +0000 (UTC) X-FDA: 81175521252.24.EB2B85C Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf28.hostedemail.com (Postfix) with ESMTP id E32EDC0002 for ; Tue, 29 Aug 2023 02:13:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=PAFIQnX8; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf28.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693275225; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WSpE78AlAGSFYIPZmWk0Cvmp1sPO7AW6n90ce46uOYM=; b=YHpRKRLv9DWDKkTW23JDB8I1bYF1vHGCn8B0AXFT4EvvPMWzhGuOfdzAF1HP91CahYXAPI dAWftJ2A7IBsIEs1lecT6avotz6Tp+BrWvqi/p/EJM3B/ky27e16RiGZaBpWFEgKRvWJzR Jy79EQrihTRqm3ANdAZUXFp2iNJSuPY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=PAFIQnX8; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf28.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693275225; a=rsa-sha256; cv=none; b=RL+CnreeQ33+YdrnEWIn1Gq4JxaOjZMgF9J/wFulYhbHuSQgWLMmMsnbV/VpMws8DaSGtE ogYbir+6qT+uTHw9prCe2BJDDTp95C0WNchsDCuV4Dn5BTT71H8CSn44xgyf390wyZrR+W a1LvFgI9lyZdcDS9xZD/NkqVa81GBpI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WSpE78AlAGSFYIPZmWk0Cvmp1sPO7AW6n90ce46uOYM=; b=PAFIQnX8h2mZe312CRFxBUGRhR yewAkg9miKRYD9Vz8UTH7Z+ppmL39kw4LeosjxsuhpA3gEBVXHTXUZpGvPRRdiqX7EnVQ4cRARMqU MgrwPXK7cJThHqvEsRmbUeqg1ngZt/qSYMxI+i0SGVsWv1wEmes8gW8EHhSOD+X/V9nRdb0NqNfte z3xmoKxbu81NegjTRuzZ/0wz66egxTQrE0xlU5sUuFZNGZqNBQ2VuSPK0H83+YYCMcQvFrOhEzk2d eQ8a5o9d3oxteEGOvuq9kuMxWmsfOjRHfytiNSlkG2eL5lsIt+/1a1CPSzZhlEodHA0F/M4yqR0Ly ps7rt9eg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1qaoEb-001i6r-0D; Tue, 29 Aug 2023 02:13:37 +0000 Date: Tue, 29 Aug 2023 03:13:37 +0100 From: Al Viro To: Christoph Hellwig Cc: Jens Axboe , "Darrick J. Wong" , Andrew Morton , Matthew Wilcox , Christian Brauner , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Hannes Reinecke , Johannes Thumshirn Subject: Re: [PATCH 4/6] block: stop setting ->direct_IO Message-ID: <20230829021337.GC325446@ZenIV> References: <20230801172201.1923299-1-hch@lst.de> <20230801172201.1923299-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801172201.1923299-5-hch@lst.de> X-Rspamd-Queue-Id: E32EDC0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5s9xwrwj3ezuw4ru9i1b3b35tz7y8zn1 X-HE-Tag: 1693275224-32177 X-HE-Meta: U2FsdGVkX1/kfhs4BDBG6OS2dVMxZ70cp+XRXkfYkFZnFVbQsPaKLLiNJ/2MsXZPL3+ZyEc4yP3mPnYVFEOS5soEP+D2OHZQE+ZWLgsCVhPr9p91tRGnstGWQ2GBC2+NvFqks3PfXPI0h4z0M08bMFbjpvk3MLftIDNIbYVfoa2u7FsZ7JpC19hyOTWB5uPow61vspqJUs8cvG43EUwJ0JBDxiNkuqFpQoBNp+4OkJQoDxdscY/6Ps+bHJCWNPh91JccjHyEnQTsRvwBLZ/JF0RR2s7yIFERnKBGs6/PqCQFz9mJZ/6CKIsDFzoU0isy4O5R6svueUVgTYqUJJS1g7S+gIQMILNd3Ta4gKS0nyn5PRNr3apfEKlSPkpAbAXU9tyoub75Blui/yN8xcWJ7G8NjbGjnzRGOctNDxpODtsqF8ptaFq2td1s7CSW/bNN9UdvuQZm4sRLcmmlcW6NEAUW/fN+tM1o1IwAFiANck4cw+aEQiXeqA4yWYPJl4Z34+9wTWE8E6Sc6BfadTnkemrm+u3jvajYDcxmIBXlESFTwUO5sWobaF5FgvqcUH8TwlHvnIsAtBg0ZrxvhL7Q3g/FqK1PKECfLrAc1wqkRrWUYNmzskzr9sTceq92FAhEBvF49+GpnsnwdbYWEyRvM4kihjvH+OUe7EhWskyExpIDEUBqBgXZUCqxXLq1ZRDeSPbiYwGF+AXo7EHOCPvVqZr/P1IBG4vThPZrqT52j6reo7znOkOz65UnhG4LvaNA1QMRExUG13PvOsMM39Jl2fTL0F15u1JMebdPpfEfoYiLfQ/joBbF57vIZ1R8/KF8uZCozdrJl2l+r8Ua7h3cuV55SPnqcRlxTszKP41ctihhSpv0/FybqbB0nGtzOwtNyOm7L/kmNENAidDqr3515DLP85fsdxFT89TuiKDersGvVxzVXKW7DAkRfXFM3RHStQYOa043ZxYPw4nl2nq vnKEG2Hk WO5l0uHP5kE+LDbUBIgi7qvtjxwjTWUMq5eF0R44d2y16E+Xqce5SrUP69gDMXhq9IzW/6lKk0nVfb7s+NI7RA2Oas1yp5hLB+hc4evWS4MqUUT60X6zdnpXSO9bbtKQvriGx8M+xoSwHkWFSCwQSrqhJhaJews9LqopYZX8hQiKaFqbl2KOJ6DGkz3gju+Baus/w+tquz+thufZHZzQu1W5Nkpp1FlapxGRuLMLkDvU4BiCUluQvItrtkMq18VnlzzX5BzKShayi9oF2nkzCqvDFI2Js9BwNCEY8hxTo73vavjA209zkD3Dm4nluV3MhHvEFvOiS173ipFQARJr7bjxpILFnkGK0ZXwycpCK6FGF3XF4+86z0R8OXa8+qOr93N1Tkka1oLStKhA0ar6noT1IrR/1JnOtO03J6CxtgeBKOoF05lOdTsfHhzjQ+U3rGa0/fIzA/iBvYQ8z+7PqoUFjXUDIyGrOeQRhhTMi0kWW8Fw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 07:21:59PM +0200, Christoph Hellwig wrote: > Direct I/O on block devices now nevers goes through aops->direct_IO. > Stop setting it and set the FMODE_CAN_ODIRECT in ->open instead. s/nevers/never/