From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D2BC83F17 for ; Tue, 29 Aug 2023 22:47:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C59838E0027; Tue, 29 Aug 2023 18:47:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C07E28E000B; Tue, 29 Aug 2023 18:47:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA8B08E0027; Tue, 29 Aug 2023 18:47:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9BD218E000B for ; Tue, 29 Aug 2023 18:47:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6DC1FA02DB for ; Tue, 29 Aug 2023 22:47:27 +0000 (UTC) X-FDA: 81178630134.28.6D16CCE Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf10.hostedemail.com (Postfix) with ESMTP id 863DBC0016 for ; Tue, 29 Aug 2023 22:47:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b="q1V5fHa/"; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf10.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693349245; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGuBrJRA9Fd4AduQK/hSseIFrv8V5F+R7owbTsvIznw=; b=cgzic+iqdeFt175u7drZge2qURggUQOKfat1XRH8ESN3caAJfSqJKdUuRVE03LRfFAz/77 447a1MXPMdoIJII1Y9DSorz9pFrfZXk4gg4JHS47wOwPLmUHnSc3Kma3M+xG9+4ATB8LMc MmPk4b9WNstlcwlP0+G7aP1OdXF5xdA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b="q1V5fHa/"; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf10.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693349245; a=rsa-sha256; cv=none; b=36hsZEvQgz9LUtwpX9dbbTQ78UY5XZy1UUeAN+0UpHLq4CufO+TITkRn62FqwD+oFmEd8R yfg+z7qQkwfimOPIR4BIjUhJX1V5XTvy8NG1kpZ2UBED+BuLnb6zQ2PdPsXAq9P42NWDq3 +HGHc7u638289s23xMFSRUnhHV7d6BA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XGuBrJRA9Fd4AduQK/hSseIFrv8V5F+R7owbTsvIznw=; b=q1V5fHa/AXkRLdmnc9TtDTItxb sjv5FpbdJarUSWDm8h5uqmHXkHTGtBOUlKVK5U/4PExCLqpYcowYZaV/PvP/kk1bfsDWLvRZIDMi6 J4YRKXkMJOy3sqhHWZHu4Fl1bfB/qtOHn3XYeh3dGmGOC0qbSQkD2Y+wYSoEusMnNBuy4+VyYQnkY Lc4KlaQORaxPNCRh9pBUGO98Ft5v23nvU0WQJiozkEiistd3znn+J2fx0QgNh+u6E23YopsyfOSpr Rmce2YRpGqgEixjkKJHtsYkWfKbeh3RTX6XJKjEhssGOmTvrkXGjl1f8Qxu8W6gub1Ziw1YBVxlnq 0FDl8ZIQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1qb7SA-001wYO-34; Tue, 29 Aug 2023 22:44:55 +0000 Date: Tue, 29 Aug 2023 23:44:54 +0100 From: Al Viro To: Jeff Layton Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Christian Brauner , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , "Darrick J. Wong" , Dave Chinner , Anthony Iliopoulos , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mtd@lists.infradead.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr Message-ID: <20230829224454.GA461907@ZenIV> References: <20230725-mgctime-v6-0-a794c2b7abca@kernel.org> <20230725-mgctime-v6-1-a794c2b7abca@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725-mgctime-v6-1-a794c2b7abca@kernel.org> X-Rspamd-Queue-Id: 863DBC0016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: iu9fqetf1taqtgykasnrzg4izhf79s38 X-HE-Tag: 1693349244-840914 X-HE-Meta: U2FsdGVkX1/ezD2VqQsJNQHmEY13q65Dyi24nKSQF6Y6EjNf3X/oJ4G71/TJP3A6n+ZgRrhD8DWetR6MADn47lon3KzNKOoKa6WiJqq+D9oq4A+Q13Mk6X8WTVwZmKXPdpAY830he65YjZr0h/sH7Y6nDURYM6debTVOINw+A/fe6xxvwHUBU/G2ZqdIXWK08CytL/lVQCYycYKild9O5u2o53792n+IYKgKanpGhFHbKD2plh2n7bYrtD1nXv/x3X2Q1P+2ds7HvhE41uPlukHh8CP+G8FbA/sSu3H1SbqimF25U2CQJfGsWZK3IAESo8TqPoe5V4drJUxvCnYygfJkxScrq2fELoSm1nxHAP12UJ22ptIS/czGdtkiNHOPJqdmHAgvNLs7buD9eYjH/K47IZxKQ6rf+cDnMV/R5h5R6BiB4+AjJuV7RwdOMouwrvDUhnrlo9kRAZtK3hrqcxnB2NbwWwzrtNsqU3Fgu/UJRscNWOQ+Of12MNIpsLzOe8ap0/5cTVjuzy4xV29/L4Wh9+WvtWnNHlMT9WW1PThdXyuBdsETLN+4h+s5DmUskVIkMITMsVqr1yC03kagAW4dJXrDL7BzjeGYdGlvsYTIc2Z2cYos6VxHaBAILo1fuLqK4PvQTT38aG0zuaDvdYbvufpvNXW3QGNuJureDjq4EPlOpD0c4GC3YKSh3T1MQxm6mDQsHEXynhNVoiZhwnuAVwT5RpozXp3Bo2alug7bIh4HO6jVYJWjKWRf9ibEX9tqgvWdZVzlaDCqOOxm9opA6LQkefty1k05kzI/dIvbYr0r4Z+I67CcloArmNcMhXAFXvVTTo8k6OL/X7S7KfHrw6QfNvE85O6q5swDjXFGVChRYuDltzN6efK2KgNtW/58juzswRIT33sChriUf5yZL4BIsb5SwLAtMEKKgfu4sl5N09HK02q8PW2BgNp7EyzwGjraUiYXYA9kJUS 911Y+qNW o15tsNLL/r5vjT9gjqs9+KfSu9s5qAm5Hz1c0egKOicYFrIGWOoOvkLTzFf0WdNLOpjJwk9DZQODsxUfDbRBAxQoMXiFQpe/W4pnhae796WEvp84P1CsJxCi//lOLF1HbGD20yuYIdGwkbCCaPDO65OGjbkae4F3y/ToadmZKnwr2hLzpBurvBjZ21OSLDKrEt1ZsQnNkDy5dDnZ/btWFfTS0/KeMpDr7Jrhrs8cTptlsTcGghpzLsGsVuly0+fNo0NF3XoO2BfhZvBD0uy8K4tktSkGYniMsTMURrFraXAp8E8O0vxQ6o9otUPBL3DLWTOrSSGoOwJW4GujHxoEatFqmM2Me17wSYZGxzSaED1lFSEl2xHcOr/GTtru89fglVm1GchuvfMCa67eKb4y9MUra3UWk6Gs89KAOHBc5aywyomTYpVZepbOMwDCUhmD9gt0Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 25, 2023 at 10:58:14AM -0400, Jeff Layton wrote: > generic_fillattr just fills in the entire stat struct indiscriminately > today, copying data from the inode. There is at least one attribute > (STATX_CHANGE_COOKIE) that can have side effects when it is reported, > and we're looking at adding more with the addition of multigrain > timestamps. > > Add a request_mask argument to generic_fillattr and have most callers > just pass in the value that is passed to getattr. Have other callers > (e.g. ksmbd) just pass in STATX_BASIC_STATS. Also move the setting of > STATX_CHANGE_COOKIE into generic_fillattr. Out of curiosity - how much PITA would it be to put request_mask into kstat? Set it in vfs_getattr_nosec() (and those get_file_..._info() on smbd side) and don't bother with that kind of propagation boilerplate - just have generic_fillattr() pick it there... Reduces the patchset size quite a bit...