From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C803AEDE9A1 for ; Thu, 14 Sep 2023 09:35:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E37176B019A; Thu, 14 Sep 2023 05:35:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF2EC6B019D; Thu, 14 Sep 2023 05:35:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAFD56B01A6; Thu, 14 Sep 2023 05:35:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B7E256B019A for ; Thu, 14 Sep 2023 05:35:18 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5741F1611AC for ; Thu, 14 Sep 2023 09:35:18 +0000 (UTC) X-FDA: 81234694716.13.441E20D Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by imf15.hostedemail.com (Postfix) with ESMTP id 1FFEDA000B for ; Thu, 14 Sep 2023 09:35:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IS2ONTWk; spf=pass (imf15.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694684116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JjJsT99VVZMBiJs/P1qIfA5Hu4o1IpI73H7ME8tpSn0=; b=g1oIG1JthdzjncIcjksonJquFcjGrejsxaq6glI98cxKa4CbafgZDzlxWcxyo3/7KORT0f 0plOiF+x9icFFqx3FAKxeIJhkrlp78/BDLSlG6F/M/UNwe6d71bn9cnw9yQkW3sVOPfDoP pj3MFnrS6H3y4153MPYrN/5VnPP+QSA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IS2ONTWk; spf=pass (imf15.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694684116; a=rsa-sha256; cv=none; b=qLYKWnYeUB4tvJYwiOKPIgVf88fISGSqK56TulYJ65Z6dzMN/kn18hSdjmxpWZRdEAfpk1 r7reQ578tVJe6ESzsQOMk9BpAdFmZoR3yOZljV38EO9Az9ug4KVyIf22o4mL2HydvaWJ1z h6uOgR34GR/+ALON0vLE1bKlWY57ipc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694684114; x=1726220114; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xv1a0gFVKwM0KgM27I+fvR02P+gkJIUr4CQzjEBt0Mg=; b=IS2ONTWkExUsF409kjq+AdaeSC4nz9DbG0AlTekbKgS/oaX7i9rzzd0g jwlnGE4I9Gbofnwp3WgLYWzybDhvL1WNYUnnYUujV7NcE1RcLdahtMbSH n/Nkw/MtP04mwKEqdeSiB1MJHxO+bL1TXxKTxTXAHd/wrCvUpzIlPgUxk eQA1xe7dyzyB6knRNTBbJoM2dwpWOd0b6THJ8p40wDcqQTZjLRkCImTHa qx8agth0Jq9S2tZjMysxb4Cv4cLszGctdk/bLKOEpmWRhc/RsXGdv0caE 4MTlbr3chpzvV6loA/RK/Q2v3gKbhWbCbPGDJ//cHrWEXfN/pJ5+lwgEa w==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="409856689" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="409856689" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 02:35:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="747655958" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="747655958" Received: from lkp-server02.sh.intel.com (HELO 9ef86b2655e5) ([10.239.97.151]) by fmsmga007.fm.intel.com with ESMTP; 14 Sep 2023 02:35:06 -0700 Received: from kbuild by 9ef86b2655e5 with local (Exim 4.96) (envelope-from ) id 1qgika-0001RR-1I; Thu, 14 Sep 2023 09:35:04 +0000 Date: Thu, 14 Sep 2023 17:34:22 +0800 From: kernel test robot To: Nhat Pham , akpm@linux-foundation.org Cc: oe-kbuild-all@lists.linux.dev, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 1/2] zswap: make shrinking memcg-aware Message-ID: <202309141736.ABab8fuf-lkp@intel.com> References: <20230911164024.2541401-2-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230911164024.2541401-2-nphamcs@gmail.com> X-Rspamd-Queue-Id: 1FFEDA000B X-Rspam-User: X-Stat-Signature: dqf5kyyoab35x9cd7w8mejw5a8mgwek5 X-Rspamd-Server: rspam01 X-HE-Tag: 1694684113-290259 X-HE-Meta: U2FsdGVkX19VG+efO1/+4y5HsF+DBnqpVK2vKCk8YNvdznBh4C0tsnVo0GXWtdWBAmW3b70ApRZYWFFvFkW+DKH7Fvxl24ngshiPnk397tU7vV973O56If+oDxD4BJ9j0DR6siR5nnzcXt/LlXkvMOpzk6eHcGSdPBw0ByOvF5DwNNICtgBuEmJ0v9arxfnI5+S0l3+BoO6a+qeWg7zYQADE2H2LN3kLrMJcpQmh+ND372Ox9gSw+HXJd5RuQ9jnFMFBccaf6pGrSFYuFfmZXo3FzyLH/dSvlPALjZKf4Jfoesx7o/0agDkcdvyqYyp5qePLBATk/3lQpz7xn3o7NyPoXfPsHSkVMiYvanGrA1XmByX0noanBujXrh7dsIK0ZmeJVv5FwzfvH1tBmjaK9nq+PIBeD+M4AIC/JD+ttkzuUcRKeGpIj1Db+mGLFp2hEtqpH6Np98v+v1XIliwwX1eR9GLMNnDAIE6aC8pNeht75gh0ymrYAUWLh9OUxlSebj+hiQpXXTKoAxF6xpoXw50K1dMDZHRb4V2VBvbr6bwB6SFck6hf1NjpFMn3gc2zbVNH4UFvz9KZGUoEx639NAdlG5BvdaeSCGvbCj34lR0fytct2wNigDZSR79j5W3l7hyOzeXJSD8CaeZUujB2ZypAOEY3FfyJljxhdmyG6Qgalt+Q/fjQQWY0J7iF04wtmWMOgPpPEtMuy3aZXFeaCYowsiYdAcsR812dJCa5c1mRfUl4w7/7HefRwjzI6GTh9IqQqdOL90zszSUlAfBTLAy7WsTUENlJ+tU8vSX8rkajWsSUX/jySpigFTh7P4BTcRzPgNV/96q/aK7mn78vvz/K6/9vaaDHFjnrETp47/OpkvlFdRkerau94yub/uB64GjhdVfmvCWeLZ2qeP4z8ByNgPRGtWBPaYPjqmxnwkCgVfJyFcBAYTrOLQHcEhVcayf02h0sLWb0Cpjbybs /bf9T4xe O8Zvm2mzgAYvMwQLFxlp64R/1Dbv4ndsRaP83vinpBe6vN6fN6krCyx/nZDVlTLms2fTmlnxfr9au4oKPi3m0FIhpyqRro9rQRRtcLkN/bRQb30OuCKIjwHRsEBW8ESHN7LMn1Rb/0+3NE5c8+XZXuA2x+TNiffvTXrHVbNjNVNEgtbIxb37n0W1gRJ37buw6utZmSxjUjf4X1wDAIL+DCK9S6j5nfLXFOwZE1s0yNWbqtCpDORIWScbEI/FdRSxbQ5REbkVrTFPM6DKlq1voLBOhDovD+7Cs52BUjzEt55kSKwKrwRbkPa+GXV8osiekJwqw6vYHW8zk+2Aq7C87DczVJmE43kOF8OZjr57RuupshzyurTPA4xh68KX9g0rt8aoaSdiu3gS05dM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Nhat, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.6-rc1 next-20230914] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Nhat-Pham/zswap-make-shrinking-memcg-aware/20230912-004147 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230911164024.2541401-2-nphamcs%40gmail.com patch subject: [PATCH 1/2] zswap: make shrinking memcg-aware config: loongarch-randconfig-001-20230914 (https://download.01.org/0day-ci/archive/20230914/202309141736.ABab8fuf-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309141736.ABab8fuf-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309141736.ABab8fuf-lkp@intel.com/ All error/warnings (new ones prefixed by >>): mm/zswap.c: In function 'zswap_lru_add': >> mm/zswap.c:320:17: error: implicit declaration of function 'get_mem_cgroup_from_objcg'; did you mean 'get_mem_cgroup_from_mm'? [-Werror=implicit-function-declaration] 320 | get_mem_cgroup_from_objcg(entry->objcg) : NULL; | ^~~~~~~~~~~~~~~~~~~~~~~~~ | get_mem_cgroup_from_mm >> mm/zswap.c:320:57: warning: pointer/integer type mismatch in conditional expression 320 | get_mem_cgroup_from_objcg(entry->objcg) : NULL; | ^ mm/zswap.c: In function 'zswap_lru_del': mm/zswap.c:330:57: warning: pointer/integer type mismatch in conditional expression 330 | get_mem_cgroup_from_objcg(entry->objcg) : NULL; | ^ mm/zswap.c: In function 'shrink_memcg_cb': mm/zswap.c:694:80: warning: pointer/integer type mismatch in conditional expression 694 | memcg = entry->objcg ? get_mem_cgroup_from_objcg(entry->objcg) : NULL; | ^ mm/zswap.c: In function 'shrink_worker': >> mm/zswap.c:758:51: error: invalid use of undefined type 'struct mem_cgroup' 758 | css_put(&pool->next_shrink->css); | ^~ mm/zswap.c: In function 'zswap_pool_destroy': mm/zswap.c:906:43: error: invalid use of undefined type 'struct mem_cgroup' 906 | css_put(&pool->next_shrink->css); | ^~ mm/zswap.c: In function 'zswap_store': >> mm/zswap.c:1298:23: warning: assignment to 'struct mem_cgroup *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1298 | memcg = get_mem_cgroup_from_objcg(objcg); | ^ mm/zswap.c:1300:39: error: invalid use of undefined type 'struct mem_cgroup' 1300 | css_put(&memcg->css); | ^~ mm/zswap.c:1303:31: error: invalid use of undefined type 'struct mem_cgroup' 1303 | css_put(&memcg->css); | ^~ mm/zswap.c:1349:23: warning: assignment to 'struct mem_cgroup *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1349 | memcg = get_mem_cgroup_from_objcg(objcg); | ^ mm/zswap.c:1351:31: error: invalid use of undefined type 'struct mem_cgroup' 1351 | css_put(&memcg->css); | ^~ cc1: some warnings being treated as errors vim +320 mm/zswap.c 313 314 /********************************* 315 * lru functions 316 **********************************/ 317 static bool zswap_lru_add(struct list_lru *list_lru, struct zswap_entry *entry) 318 { 319 struct mem_cgroup *memcg = entry->objcg ? > 320 get_mem_cgroup_from_objcg(entry->objcg) : NULL; 321 bool added = __list_lru_add(list_lru, &entry->lru, entry->nid, memcg); 322 323 mem_cgroup_put(memcg); 324 return added; 325 } 326 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki