From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15013CD37AA for ; Fri, 15 Sep 2023 20:57:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A41978D002A; Fri, 15 Sep 2023 16:57:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A18E78D0005; Fri, 15 Sep 2023 16:57:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908448D002A; Fri, 15 Sep 2023 16:57:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 802E88D0005 for ; Fri, 15 Sep 2023 16:57:02 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 53F1F14073F for ; Fri, 15 Sep 2023 20:57:02 +0000 (UTC) X-FDA: 81240041484.11.0D2F8EF Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf21.hostedemail.com (Postfix) with ESMTP id 92F0D1C0012 for ; Fri, 15 Sep 2023 20:57:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=azcdUIzA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694811420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+5BeJTKQ+1ikY10aMboTw9qo9cYRheGp8DXKbuRu77g=; b=US8p5LptbOO1WIdB/MxZfZ0Ctu/vtMylG6eGlZxU7doMkx7Zs1dPbmknMlXk8AsFyydFlv Nye8UPP/0yo+06N7dlMGRWSGk0UaNTjx8V64VbX3xZdjCZFMPk0GC/Ml10QoYsLU4yDW9m +D3O4vwiHxks6mM0aXXLda3U03KkBSg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=azcdUIzA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.171 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694811420; a=rsa-sha256; cv=none; b=EvRbmSHtZxl7OKvdLwq8jora0RUy1eWxue91gm3kjWqws/+bw8i55NIHavsd250rF7Hi5G Pep0Jw3abko62uiUEq+uXRgjyjRgghpuERBcLsCbR2jQBlKe42Hg4MxZtWcZ2t/fDF+wI+ owOGsMw28Vul5AjYCrIWeoSpqo1bnJ0= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-68fac16ee5fso2401406b3a.1 for ; Fri, 15 Sep 2023 13:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1694811419; x=1695416219; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+5BeJTKQ+1ikY10aMboTw9qo9cYRheGp8DXKbuRu77g=; b=azcdUIzAwMSin3+u+jNhI2rP48Lf6rwlRqRrhMXiu1LYwKKioxTk3e/Ocd1u6Bbc5V XUQVsqUF7qS3dkegG7/IvhYgPL+Mh6QlL71Hut11AdmgH/aVvHznbltuEYJkyrMkzBc2 ruYmiHGu+t5721DL8mmiqTN1NCj2qES7PJYBU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694811419; x=1695416219; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+5BeJTKQ+1ikY10aMboTw9qo9cYRheGp8DXKbuRu77g=; b=Dd1XqJlADkumkSNmlNTe7eaIjoHhNugrEUHyNFtxxLnrWpFMZudZZe6D1OWGyre2Wf 9ju2NmjXAzE5zXi0FaOYex1UkCNKah1B1ReGFNcs6afJFEg218W1E28mF4tNuPo8XXc/ yLDVpaX3QDoUYbYHWStUoKFaMFVJro7MOTaoXkOMhcdhGBZFyTNMlyUAMgrDsX2+egCM 5cI9al2CQsxLQ1PLyR8yuM2PLcJSDeqhUJDvI7lKy8Lh0FPLNjrkt9zvw+Dcjkb9A9aC rOMhuWQHNzlZizWIdEBwScICu2LJ83LxZEsWX4i0jmoMJGk+Yox7F+y/srMNle8vksW5 fdfg== X-Gm-Message-State: AOJu0Yz2mN9np1sEshF1C9GvmaPoFRcIStNWDMq4IF+AziLx4zRUa8/3 tVpnm4lmtkrsFM/TWW7SlhGn0w== X-Google-Smtp-Source: AGHT+IHJBAYhxn1GGRB5vzrXcaafNOi0rnc01xyeDJrxzCSkXZlY8N/3npkmx1Wu5YzdeWtLZT+rkw== X-Received: by 2002:a05:6a21:3297:b0:133:e3e3:dc07 with SMTP id yt23-20020a056a21329700b00133e3e3dc07mr3739773pzb.49.1694811419599; Fri, 15 Sep 2023 13:56:59 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id m21-20020aa79015000000b0068a6972ca0esm3336769pfo.106.2023.09.15.13.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 13:56:59 -0700 (PDT) Date: Fri, 15 Sep 2023 13:56:58 -0700 From: Kees Cook To: Matteo Rizzo Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, corbet@lwn.net, luto@kernel.org, peterz@infradead.org, jannh@google.com, evn@google.com, poprdi@google.com, jordyzomer@google.com Subject: Re: [RFC PATCH 03/14] mm/slub: move kmem_cache_order_objects to slab.h Message-ID: <202309151356.1A6AC69@keescook> References: <20230915105933.495735-1-matteorizzo@google.com> <20230915105933.495735-4-matteorizzo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230915105933.495735-4-matteorizzo@google.com> X-Rspam-User: X-Stat-Signature: itqrhambcwnuroncr4ng17z4ap9qpod8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 92F0D1C0012 X-HE-Tag: 1694811420-401443 X-HE-Meta: U2FsdGVkX180AG0OWxYdVrzlplrh6slctf+48Cv+V18QXlN2Zw+BWjjqVJjylnTILgIsjatry2ZsrtWEfA0Tqc34YIzOhEsDG76bfGkG5O4TFYGFNLPlLmA4GaSBM0KTlMnqJjdp4LYaVEU7lylqJudWBdYC1dmicjk0BNI4vK/iQ/5s+1PrnmNX13zy0fSKwK26yZh92lEgdgGI2Phs5b5ypQLtWOY8SYooU4rGg4dcGy7FkFS9sxtQbCa1p3+LPuYsfY7x5Hinuq0zpe2byt8WKG66QkYDje1Yr8urTrKPgZk5ItKWnZYTzp2l7jraDpz4c3EeiPn6iXrvs/Y3g7fmlT9f07ZkGybzwixoy4KbvJJM7UmT955L1y3bt6qQlW+tphS0mR5FVu1mnf/7wjrmi8mPdxUaa5lX+dm84+dSCNMflWjINTwYA9yJh5A+3ksqDiG5Yk6VVcLJZb8rbAeXCr57P46dSFirb9nDby2aaghahHWTqP33bCBDkWR3xNiIF6YNW4GsbMhWfXmLhB9IkRaP/OBhWvMEt4K+Up2FiwF/kV4g9eC9aTI1/1mNssRrfaz8BBED5lX9idAnjN2m+HkBP4VXCKlU8hZ+5qXT9K1RYVFCHpsdWkVQhoqbVk7+Y+lu+mNZe7IThEn/OswLRl7om9kVXgo+eftvB4XYmbWLou9nLTba8Dt4ZvWf5pddTlIbRl1LeD2LOcrTJbvPcmQ2NL+gfoWK099skcTRUoSVVIbkl7YbuMsbVhZ0gdM1z02txB3Rbio85yC5a0Fuo7CZo0YRgKZqzZCSdkLe12BPo9864TETyTquaHDQqoZkag4CshTESoQ4tGb1cmO1NC1pDyJK1ifL9OXK9LmyVpK4IZfu8r/zVYmzV+jjhHgH84Fi7DzrMb84Yd6HrgVYNA2cyqTpORKlxW9Qdo3cLquxoopLJCZBaALoVFZq+DtcAv5VbnPptaRBn0B FT9BVdcQ mMW3CSLffM5zkB9GQCgnIwaTnvlqjK+lweGEIH4yf5NhV09gqsbX5stEnuGoJb3qttP+JdkmxjW4H4Y2XVrnrzdlSsrvYBUsu8YxUrw4uYckLwEFId7TNy3bITVI9irzn3T3bLsn+0h75bzugNzVqDdqpHYqr5KxnmitgUwyxLd1ewDh97vJXW4L3XUcsC85vHQiP41bxfMJI373A6fBQ1cn2KSgpyVwEmInBtcnWuatfisQxFyzx/54QGao2F6B5C5S5Q/ZIH4mr5Cr45DuJLQduC21NJ2vPmxE6Hqf8QakuEQXpYf2KwCm+ifPNW8LxyorRtOQaFkay29AdvrabUxzIse0eoB6xF+Y/cZj7kz/SG+CSdsP+OoGW5ccbeqIpEkoba1vLf5svPMGJDYJE/eXA+S7YZE68Z8O097SalG/WgmFC8TdcJs8yBQ07dEgrURcAX7PyE5aHry0dsYkzrYMtnTWbJn8YjAtloXsCzj7omAbcobO6DN9h/C0vEMD9PvlhvWwEsHzBa7SnOfYn+5WllgpAcxQTLHdYN5i/FUE0gnY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 10:59:22AM +0000, Matteo Rizzo wrote: > From: Jann Horn > > This is refactoring for SLAB_VIRTUAL. The implementation needs to know > the order of the virtual memory region allocated to each slab to know > how much physical memory to allocate when the slab is reused. We reuse > kmem_cache_order_objects for this, so we have to move it before struct > slab. > > Signed-off-by: Jann Horn Yay mechanical changes. Reviewed-by: Kees Cook -- Kees Cook