From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A0ECD37B0 for ; Mon, 18 Sep 2023 11:00:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D55666B02E4; Mon, 18 Sep 2023 07:00:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D051A6B02E5; Mon, 18 Sep 2023 07:00:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA56C6B02E7; Mon, 18 Sep 2023 07:00:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A81A16B02E4 for ; Mon, 18 Sep 2023 07:00:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7274A40CDA for ; Mon, 18 Sep 2023 11:00:20 +0000 (UTC) X-FDA: 81249424200.23.8CE243F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf12.hostedemail.com (Postfix) with ESMTP id F407140024 for ; Mon, 18 Sep 2023 11:00:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JRcMHnFI; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695034818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tAklPFhZuMEVKjNvfqxQZuVXVhaouEWZsF9++YV8GrI=; b=rEn02y1Kqwy5fhfGxDdCuGeaJpt00vUMvoBjWqwrMrOZF4Uszta9HIWjHfzQR7p5hU5TZS SX9bb7LUuwHJiZQTAGvs3Oc6QrOrFicy3kbdgYdYPkut0ohZBNaf473bb1Cut0bREwzJiH ZdrNIiMl6A/B++Y4azAGkz/CGNQVPAE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695034818; a=rsa-sha256; cv=none; b=h/JZDeSiKiKykbVXFusR6EKsXU+64HrPvP2+CG3OiLdyzKTrCng7SFEHTb/pkKzd+RNhqd 9vYY4XAESg7JI9VhAMGyCW7chh84PWN4vJlrNUHrKzI2R8UKtCoU11zINnvXwnxAUiVI9/ g0jVJss2jVqHslzI7GBQeO3Kzzt0tso= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JRcMHnFI; spf=pass (imf12.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5A0E8CE0B53; Mon, 18 Sep 2023 11:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5A57C433C7; Mon, 18 Sep 2023 11:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695034811; bh=mUP6+EOkqcXwwHbp/HXe6HO9SgJ+ru7fakc6rUq1+Cc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JRcMHnFI1H4CVwaI8yhCmtOPdp+FzuUGK1NYH1ESGOZO88hXQArQ9JBPK0zrjBcM/ SVKzKoQsepWlY0yExn8n7Ktxh8iH6SMKq8HwLfEgZKThDRR58TZfmcmJBX3wCz+QRI 1yTCoU05IGB50cuGOB3BbwoozrxtM6BByqKgN9V9ibyaLCTvwOf8e7SMuHj1toAI2Z F80Ak+P2/ZW89YQkuFbzt2KiHl5+SIf6CFdZcBUJdxdFRESd4C2pevyskRCW8nXDSq 97X1VirI6/6iAIoTX7GTjXfu0vGeDgvaiXdpfrgzk007VZTiIpwgcST8HgVxgjQAa7 PHdi2af/UUV+g== From: SeongJae Park To: Jinjie Ruan Cc: sj@kernel.org, akpm@linux-foundation.org, brendan.higgins@linux.dev, feng.tang@intel.com, damon@lists.linux.dev, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/damon/core-test: Fix memory leak in damon_new_region() Date: Mon, 18 Sep 2023 11:00:09 +0000 Message-Id: <20230918110009.78365-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230918074759.3895339-2-ruanjinjie@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F407140024 X-Rspam-User: X-Stat-Signature: 773673gau3e81o1ocbci864gh1rg31y4 X-Rspamd-Server: rspam03 X-HE-Tag: 1695034817-251057 X-HE-Meta: U2FsdGVkX1/PD83DJsZF8qkx1m/PNFQoT3KzX6E/+jrFGIc2DUNAy6HPhOn0EJkkEQqKiztPf9K1oGK26H+gjdVAzaCsoshG4QbABIeYjY9f35+ad1OL0mcvoBSuwNZpUyM6ksyBO8cHePiFphpBfXMALQUJX35zUfIbFGDuphr9riwUO9aqhB+Omm6eQvouxLCwmur3JD0wH3cQtf6vEiT0AoGqq+w4FJQE/g/wBWjldzPwcKETAY8xFH0BA8mFJAilHU6ROJM7k0s4ERtXAwunDu2TuBriS/rIusaj1wHUWTEs/0PTmjVGNPWppKLZJC0yeRSqG8WxGirKUZ/S5FdJTsDAPa/jxB6PonqiT7mXwRL3vZSOS6OHfjkjFkrsb90IIk2+G0ioKzLhskDbyG124IodCvlDnTq6sH6/rrtceUlHbQ+Igb9ABUY+s4IZBjMNI69lQ5qslkzaTUrG1IIKWNk7jAWd+7Vl6IkB3vuVbvOC6Gwr4/QLkEU1QIwwPNYbwhE0lMxZ/S4VPXBLdtzw+453a5GLDjkvAWKvD+cZSh3yrocwOu7cawIS/5vL9fb2oJrKV313oe1b6+eP+n5P8wMA9H9sMzzQZwmVKSgmoZo2gJJ93wwojajXGziCxWeO3E3xAzZ9TLTaNRidiTHKx4uK6Skm2QJ6O2FQec1oZ8Wg0QmlZE4nnukVtdziAPrAnO/N1KnqSCbcbgvPVXa/OS4X6DUX+vJr2vFf+lHGeClJwoy0t3H8KLWw9aeaHtS5TcpMx20TY2veR+ujD2HAnOtWcTo2ZySgxOe5rEkDwwA2/Xpdp2hzWZdpBlUqZOWWBYTEI8fsui+S34tWR/8ghZ44ekw33apAlx6PH5DyU5tb5r9s1Lv1pwF8tbTEYyFyDIVNquTPx7ULnD7nvd70EzqsdLqZS8lb8RqL8B0u6zn8006l0Q0JqkMeQt4HRjhizgWes287V1k66Dg VvI+FJ2A BthoAP6DQyi/R+mzgg3nF2LPD3dE49TGr6pNNAQOE8i3dZUVzViSiKea5MJDmEN7hI8ueIgo3CplcLZ9k3b+rNSZcDBMPkN+3zSHwt/EL7yq0eOTFXVAxjv0eSvDHRNOhlGc6OAUxZPuF9auwNsX10dLZj+TY73g4snb8zW3DlAuScVVGsSM7AzD+CHqKKUr3FQzyomNuFfmzO5YSoyqrgI7cPF8ZH1LdHFb7/5cqPq00HV1OpbbkLX+VWZYfeIs/40gPj3lrbtINZNuKCVCsWSIU/DHa9jxoPUqNHACYr3MTYEIEkHsaqBRA+EHdciaxeWuRPOVZ249wnxnn6cJ8RG5uCGfNrq58AUXfZ11p8naex+3UI8OFKrBCbSWp66SdGBiV0O77nEv8HWjNXUd1l6iYjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jinjie, On Mon, 18 Sep 2023 15:47:58 +0800 Jinjie Ruan wrote: > When CONFIG_DAMON_KUNIT_TEST=y and making CONFIG_DEBUG_KMEMLEAK=y > and CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y, the below memory leak is detected. > > The damon_region which is allocated by kmem_cache_alloc() in > damon_new_region() in damon_test_regions() and > damon_test_update_monitoring_result() are not freed. So use > damon_free_region() to free it. Nit. This patch is not directly adding use of damon_free_region() but replaces damon_del_region() call with damon_destroy_region(), so that it calls both damon_del_region() and damon_free_region(). I think this part might better to be re-written? > After applying this patch, the following > memory leak is never detected. > > unreferenced object 0xffff2b49c3edc000 (size 56): > comm "kunit_try_catch", pid 338, jiffies 4294895280 (age 557.084s) > hex dump (first 32 bytes): > 01 00 00 00 00 00 00 00 02 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 49 2b ff ff ............I+.. > backtrace: > [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 > [<00000000b528f67c>] kmem_cache_alloc+0x168/0x284 > [<000000008603f022>] damon_new_region+0x28/0x54 > [<00000000a3b8c64e>] damon_test_regions+0x38/0x270 > [<00000000559c4801>] kunit_try_run_case+0x50/0xac > [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c > [<000000003c3e9211>] kthread+0x124/0x130 > [<0000000028f85bdd>] ret_from_fork+0x10/0x20 > unreferenced object 0xffff2b49c5b20000 (size 56): > comm "kunit_try_catch", pid 354, jiffies 4294895304 (age 556.988s) > hex dump (first 32 bytes): > 03 00 00 00 00 00 00 00 07 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 96 00 00 00 49 2b ff ff ............I+.. > backtrace: > [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 > [<00000000b528f67c>] kmem_cache_alloc+0x168/0x284 > [<000000008603f022>] damon_new_region+0x28/0x54 > [<00000000ca019f80>] damon_test_update_monitoring_result+0x18/0x34 > [<00000000559c4801>] kunit_try_run_case+0x50/0xac > [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c > [<000000003c3e9211>] kthread+0x124/0x130 > [<0000000028f85bdd>] ret_from_fork+0x10/0x20 > > Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") > Fixes: f4c978b6594b ("mm/damon/core-test: add a test for damon_update_monitoring_results()") > Signed-off-by: Jinjie Ruan Other than the above trivial nit, Reviewed-by: SeongJae Park > --- > v2: > - Replace the damon_del_region() with damon_destroy_region() rather than > calling damon_free_region(). > - Update the commit message. And thank you for making the changes. Thanks, SJ > --- > mm/damon/core-test.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h > index 79f1f12e0dd5..3959be35b901 100644 > --- a/mm/damon/core-test.h > +++ b/mm/damon/core-test.h > @@ -30,7 +30,7 @@ static void damon_test_regions(struct kunit *test) > damon_add_region(r, t); > KUNIT_EXPECT_EQ(test, 1u, damon_nr_regions(t)); > > - damon_del_region(r, t); > + damon_destroy_region(r, t); > KUNIT_EXPECT_EQ(test, 0u, damon_nr_regions(t)); > > damon_free_target(t); > @@ -321,6 +321,8 @@ static void damon_test_update_monitoring_result(struct kunit *test) > damon_update_monitoring_result(r, &old_attrs, &new_attrs); > KUNIT_EXPECT_EQ(test, r->nr_accesses, 150); > KUNIT_EXPECT_EQ(test, r->age, 20); > + > + damon_free_region(r); > } > > static void damon_test_set_attrs(struct kunit *test) > -- > 2.34.1 > >