From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3BC1CD37B0 for ; Mon, 18 Sep 2023 11:03:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E1E56B02ED; Mon, 18 Sep 2023 07:03:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 391BF6B02F3; Mon, 18 Sep 2023 07:03:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 280D06B02F5; Mon, 18 Sep 2023 07:03:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 195DE6B02ED for ; Mon, 18 Sep 2023 07:03:12 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE53E1601E2 for ; Mon, 18 Sep 2023 11:03:11 +0000 (UTC) X-FDA: 81249431382.30.9DD0E1E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id F3AB7A0045 for ; Mon, 18 Sep 2023 11:03:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Zi8DFmZm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695034990; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E7/uUPSa36onm3YDBaofkWQwcpsI/E+7twbtAIQ9LzY=; b=YnfDOQNR2Zqruxlu9ZiUAJ6o3O8c2amcNIvGUCJpYYD4lj3ce5iCzDWS41oKTpB4EUdyL3 UpIsrAknGl1yvXUZA6ox2lzDdftMrKzNvC1xSHRVb/qUZLwOO7bKOmOM9QWvA3PU2gwE9M nC3vPUKGaDKIVJGSMjbz9CSLlIxAnZY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Zi8DFmZm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695034990; a=rsa-sha256; cv=none; b=e2BDe40pr+CoxVuCpGVZjR4fhk9pLewLNAXqTd15BGZb1Jap+nKv50b4GJqyvd90aiBsHE wUwc6Ev6zQa9EtlxAa0iJyOpTDkeJtUliXA/pcraAkxrMGW9dAtdPjNjoH/R7/230VIihj oDsggoAaBVcTFTAo+OGWs5SXB2vfCAM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 109F1B80DBD; Mon, 18 Sep 2023 11:03:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF0D7C433C7; Mon, 18 Sep 2023 11:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695034986; bh=xheY1ymXh/wvdjFd8+v/+GHt+em90YiVp8HQxiG3Nd4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zi8DFmZm1oR8NWs7ka2iDKaLGQgBPU04YKEruMLQeiJ774r2K4wMKMxgQlFbp0FXY DVGTGCkK3T7WQjdQpTp3+N2ZL5QC5N9Gy8vU+peGy6qMXRCMihR+yHriLYH8u8USqs oH77NXEo9PjHiLOFfKckdkLwWnoU6NUZtvBWOp6isqjzwTFuUr0BLR8By8DyzBG09o wx1RIIFk9yHkzPt3uwX6qM3TdpaT/IaK7OToIC1uWLx/WJyBd5mkIx7ThNpYeCgc/C 7MY5w7xw2c9gadANljIDPj9Ko/P54/tQ02XB23waPsc+5OO0aiTxgrN79iAEf4Sr0R 5aVR5b1Ik8Hjg== From: SeongJae Park To: Jinjie Ruan Cc: sj@kernel.org, akpm@linux-foundation.org, brendan.higgins@linux.dev, feng.tang@intel.com, damon@lists.linux.dev, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm/damon/core-test: Fix memory leak in damon_new_ctx() Date: Mon, 18 Sep 2023 11:03:04 +0000 Message-Id: <20230918110304.81807-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230918074759.3895339-3-ruanjinjie@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F3AB7A0045 X-Stat-Signature: wox8hdnri8fmt3oeo734prdmi45yxe4b X-Rspam-User: X-HE-Tag: 1695034989-307446 X-HE-Meta: U2FsdGVkX19PlmrDuTB9DXkOr8xgbULOtp6rjxrMyXL+ecKqMfeFgbKyZBnsjLW5rqb7lOeTbp+GnS3D8Ugo42RWfJaSt+mau4UVEqC4xCNHWLa4KDLrk3kyD39HS3zK5O5GlnboGfeGWWLdZgNYhV18BTvDxSBe6eTAAx6mybC+LwPUIJ/3jH/HyXigrfX2YiYxanM45z9wyNdV3D9gJm0crujHw5j+iths0T/nYMfpLnz717i0k8zbtqrDhT2FE+0usWS/VnvhCeHICrlK2clSSY0f82ZxQ5d09gLNjUhlb9B44X0NAFfy4TCIkWfSy1LbNAEZENX5W5Kulliphm+QNZM6KHry+Ein10CBbyYrkv2eG5RF990IXcJqOnF9MshD48UnxnEYN4PGklsMbQensJT4Q0vyGt3K6OLpoHMT14c7Lcs6YDIah7NxwbUaM2j+g8qA1SeSzhnVDKXeEiLQclsbRUfyCdx8FSnzY7ibQCK1BQgrgEvD3797W/XCVefvtKuEGgV+KdVEnJRQIiEMRREIRsog/fnLxzT7+Xc4OpzAL9cqdIdZEHLOpVRrFPunRlzRhno3qTCbY8LXUnf4jTjtQAql4Kirq+jfQB3ZM8c0hLpjKoBb470SUCf2qT41zjm61fNr4/qI9T53onQ00y9DpHVkmIG7DtjMjMrA8dcuxu2VlY8gjE4VP5bUwxWxPgLlAHHHHttflssX7u85iNjqwedzQqKUWp18W0eqcv6Mbt6k9rCuc/RiIMUP7U+toj512cCWa64G7oax6AvF6yUUuenoEmLv5rjcKyCvnAMMpLMCmL1UZrE34NX5PjGWMv5IMN/ZwQTTZbV/HhzAhzPP4aKdL5Yo4kbodR2JLXg0uzkPi3A9ZDQvqF+eVYwJXksawUjkVGutHs/YsVtITvpTFqrgxgiFDubMbNAUAxwYVrgI3+XuQIHjn5s4ipro1iKBQH8vg6QXQUZ GlHOidq0 HgeTMiQ/4+md3JGwm/8/wh5rkrrwzdp4Avmmypdob/91V4lwE0aaoIB8t0IkMA+sgBMvWFxdKU2Kk8pymvdwKrtFplNqfA43FpdPOJ7srnt7WvXrccE0NpXHqqf5ff0EG9zfYTVW2js2dA4rX6+eUFzxakT5lXlysT4G+vB8vuO4Gl9O9Fk9RUY/V6yHv/LRJ9ypkx+t5xVqd1DIpRHPYddRqGdFk4vMCnA3sw/4vWpeuDlqhztjpUKzkcY3sbZqixlc0qvbU57ka8E1eCEuSBw7RhDamVUBn7DJ0iJ+rk05A6u5MAMB7D+GeuWGcehKMJFj4Wm36fIWQmmA4xXnrxNUcS18MJK5xfqrv07CKXaYenxiCJ2mkzHMgvghJZgsLMRFxKXuWQBf7abJjM3pH6A/mq6ZqB7asoyFNaP4LPLC+rXw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jinjie, On Mon, 18 Sep 2023 15:47:59 +0800 Jinjie Ruan wrote: > When CONFIG_DAMON_KUNIT_TEST=y and making CONFIG_DEBUG_KMEMLEAK=y > and CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN=y, the below memory leak is detected. > > The damon_ctx which is allocated by kzalloc() in damon_new_ctx() in > damon_test_ops_registration() and damon_test_set_attrs() are not freed. > So use damon_destroy_ctx() to free it. After applying this patch, the > following memory leak is never detected > > unreferenced object 0xffff2b49c6968800 (size 512): > comm "kunit_try_catch", pid 350, jiffies 4294895294 (age 557.028s) > hex dump (first 32 bytes): > 88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00 ................ > 00 87 93 03 00 00 00 00 0a 00 00 00 00 00 00 00 ................ > backtrace: > [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 > [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290 > [<00000000b5f89cef>] kmalloc_trace+0x40/0x164 > [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4 > [<00000000daf6227b>] damon_test_ops_registration+0x34/0x328 > [<00000000559c4801>] kunit_try_run_case+0x50/0xac > [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c > [<000000003c3e9211>] kthread+0x124/0x130 > [<0000000028f85bdd>] ret_from_fork+0x10/0x20 > unreferenced object 0xffff2b49c1a9cc00 (size 512): > comm "kunit_try_catch", pid 356, jiffies 4294895306 (age 557.000s) > hex dump (first 32 bytes): > 88 13 00 00 00 00 00 00 a0 86 01 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 0a 00 00 00 00 00 00 00 ................ > backtrace: > [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 > [<0000000073acab3b>] __kmem_cache_alloc_node+0x174/0x290 > [<00000000b5f89cef>] kmalloc_trace+0x40/0x164 > [<00000000eb19e83f>] damon_new_ctx+0x28/0xb4 > [<00000000058495c4>] damon_test_set_attrs+0x30/0x1a8 > [<00000000559c4801>] kunit_try_run_case+0x50/0xac > [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c > [<000000003c3e9211>] kthread+0x124/0x130 > [<0000000028f85bdd>] ret_from_fork+0x10/0x20 > > Fixes: d1836a3b2a9a ("mm/damon/core-test: initialise context before test in damon_test_set_attrs()") > Fixes: 4f540f5ab4f2 ("mm/damon/core-test: add a kunit test case for ops registration") > Signed-off-by: Jinjie Ruan > Reviewed-by: Feng Tang Reviewed-by: SeongJae Park Thanks, SJ > --- > v2: > - Add Reviewed-by. > - Rebased on mm-unstable. > - Update the commit message. > --- > mm/damon/core-test.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h > index 3959be35b901..649adf91ebc5 100644 > --- a/mm/damon/core-test.h > +++ b/mm/damon/core-test.h > @@ -269,6 +269,8 @@ static void damon_test_ops_registration(struct kunit *test) > > /* Check double-registration failure again */ > KUNIT_EXPECT_EQ(test, damon_register_ops(&ops), -EINVAL); > + > + damon_destroy_ctx(c); > } > > static void damon_test_set_regions(struct kunit *test) > @@ -346,6 +348,8 @@ static void damon_test_set_attrs(struct kunit *test) > invalid_attrs = valid_attrs; > invalid_attrs.aggr_interval = 4999; > KUNIT_EXPECT_EQ(test, damon_set_attrs(c, &invalid_attrs), -EINVAL); > + > + damon_destroy_ctx(c); > } > > static void damon_test_moving_sum(struct kunit *test) > -- > 2.34.1 > >