From: kernel test robot <lkp@intel.com>
To: Baoquan He <bhe@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Zhen Lei <thunder.leizhen@huawei.com>
Subject: [linux-next:master 5741/5912] kernel/crash_core.c:214:13: warning: argument 2 null where non-null expected
Date: Tue, 19 Sep 2023 12:02:17 +0800 [thread overview]
Message-ID: <202309191144.B0MToaPG-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 7fc7222d9680366edeecc219c21ca96310bdbc10
commit: 5c322f6aad10f0920f842a4ccf82e9b9f351c0a5 [5741/5912] crash_core.c: remove unneeded functions
config: s390-buildonly-randconfig-r006-20220512 (https://download.01.org/0day-ci/archive/20230919/202309191144.B0MToaPG-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230919/202309191144.B0MToaPG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309191144.B0MToaPG-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from arch/s390/include/asm/atomic.h:12,
from include/linux/atomic.h:7,
from include/linux/mm_types_task.h:13,
from include/linux/mm_types.h:5,
from include/linux/buildid.h:5,
from kernel/crash_core.c:7:
kernel/crash_core.c: In function 'parse_crashkernel_suffix.constprop':
>> kernel/crash_core.c:214:13: warning: argument 2 null where non-null expected [-Wnonnull]
214 | if (strncmp(cur, suffix, strlen(suffix))) {
include/linux/compiler.h:68:10: note: in definition of macro '__trace_if_value'
68 | (cond) ? \
| ^~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
kernel/crash_core.c:214:9: note: in expansion of macro 'if'
214 | if (strncmp(cur, suffix, strlen(suffix))) {
| ^~
In file included from include/linux/bitmap.h:11,
from include/linux/cpumask.h:12,
from include/linux/mm_types_task.h:14,
from include/linux/mm_types.h:5,
from include/linux/buildid.h:5,
from kernel/crash_core.c:7:
include/linux/string.h:51:12: note: in a call to function 'strncmp' declared 'nonnull'
51 | extern int strncmp(const char *,const char *,__kernel_size_t);
| ^~~~~~~
vim +214 kernel/crash_core.c
692f66f26a4c19 Hari Bathini 2017-05-08 193
692f66f26a4c19 Hari Bathini 2017-05-08 194 /*
692f66f26a4c19 Hari Bathini 2017-05-08 195 * That function parses "suffix" crashkernel command lines like
692f66f26a4c19 Hari Bathini 2017-05-08 196 *
692f66f26a4c19 Hari Bathini 2017-05-08 197 * crashkernel=size,[high|low]
692f66f26a4c19 Hari Bathini 2017-05-08 198 *
692f66f26a4c19 Hari Bathini 2017-05-08 199 * It returns 0 on success and -EINVAL on failure.
692f66f26a4c19 Hari Bathini 2017-05-08 200 */
692f66f26a4c19 Hari Bathini 2017-05-08 201 static int __init parse_crashkernel_suffix(char *cmdline,
692f66f26a4c19 Hari Bathini 2017-05-08 202 unsigned long long *crash_size,
692f66f26a4c19 Hari Bathini 2017-05-08 203 const char *suffix)
692f66f26a4c19 Hari Bathini 2017-05-08 204 {
692f66f26a4c19 Hari Bathini 2017-05-08 205 char *cur = cmdline;
692f66f26a4c19 Hari Bathini 2017-05-08 206
692f66f26a4c19 Hari Bathini 2017-05-08 207 *crash_size = memparse(cmdline, &cur);
692f66f26a4c19 Hari Bathini 2017-05-08 208 if (cmdline == cur) {
692f66f26a4c19 Hari Bathini 2017-05-08 209 pr_warn("crashkernel: memory value expected\n");
692f66f26a4c19 Hari Bathini 2017-05-08 210 return -EINVAL;
692f66f26a4c19 Hari Bathini 2017-05-08 211 }
692f66f26a4c19 Hari Bathini 2017-05-08 212
692f66f26a4c19 Hari Bathini 2017-05-08 213 /* check with suffix */
692f66f26a4c19 Hari Bathini 2017-05-08 @214 if (strncmp(cur, suffix, strlen(suffix))) {
692f66f26a4c19 Hari Bathini 2017-05-08 215 pr_warn("crashkernel: unrecognized char: %c\n", *cur);
692f66f26a4c19 Hari Bathini 2017-05-08 216 return -EINVAL;
692f66f26a4c19 Hari Bathini 2017-05-08 217 }
692f66f26a4c19 Hari Bathini 2017-05-08 218 cur += strlen(suffix);
692f66f26a4c19 Hari Bathini 2017-05-08 219 if (*cur != ' ' && *cur != '\0') {
692f66f26a4c19 Hari Bathini 2017-05-08 220 pr_warn("crashkernel: unrecognized char: %c\n", *cur);
692f66f26a4c19 Hari Bathini 2017-05-08 221 return -EINVAL;
692f66f26a4c19 Hari Bathini 2017-05-08 222 }
692f66f26a4c19 Hari Bathini 2017-05-08 223
692f66f26a4c19 Hari Bathini 2017-05-08 224 return 0;
692f66f26a4c19 Hari Bathini 2017-05-08 225 }
692f66f26a4c19 Hari Bathini 2017-05-08 226
:::::: The code at line 214 was first introduced by commit
:::::: 692f66f26a4c19d73249736aa973c13a1521b387 crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE
:::::: TO: Hari Bathini <hbathini@linux.vnet.ibm.com>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-09-19 4:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 4:02 kernel test robot [this message]
2023-09-19 16:42 ` [linux-next:master 5741/5912] kernel/crash_core.c:214:13: warning: argument 2 null where non-null expected Andrew Morton
2023-09-19 23:11 ` Baoquan He
2023-09-20 1:16 ` Andrew Morton
2023-09-20 1:36 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309191144.B0MToaPG-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-mm@kvack.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox