From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98854CE79AE for ; Wed, 20 Sep 2023 07:20:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C493B6B0123; Wed, 20 Sep 2023 03:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF88F6B0124; Wed, 20 Sep 2023 03:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE7E26B0125; Wed, 20 Sep 2023 03:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9F85E6B0123 for ; Wed, 20 Sep 2023 03:19:59 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6E2DF40496 for ; Wed, 20 Sep 2023 07:19:59 +0000 (UTC) X-FDA: 81256126518.06.C2581AC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id 6690080009 for ; Wed, 20 Sep 2023 07:19:57 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="JwJfNw/l"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695194397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CZZs8q0zUsaCoRa8g+is75D/jBOv+EOJO5yetOqznF4=; b=JeDy1L+GEDuHOrXR5bMFYaeZMf0yNfmt6/w5kP9Y03LXmyv9qA9m2XoAJQOVHWS2wMe3LN Oyo6wTKIb2fP2O/BFjibV/gFL1NkWYVPTXL9+iXhV4mLcfyU5cLRXCUmHaZIMzdKTkVqty lOnLNVwVwyjaroHfvCF1TnrKqINBhU0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="JwJfNw/l"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695194397; a=rsa-sha256; cv=none; b=HC3ME6egPXCTZfGlQ8cV5NaCoRsPUFDQfu4HTOjbSfgffslbBjzhY7W17MKFRdwx70A7SI I4gNS0mNgRIm7hSixFKxCZHtM/6XRgMUISdgLZ9CvSlPWKJAbqhOizNq4VykpTJ8h2wFyX utpYAE0V6Cs0Zj6mJg0A2FRsnfLeK9g= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 76C46CE12B2; Wed, 20 Sep 2023 07:19:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4550FC433C8; Wed, 20 Sep 2023 07:19:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695194391; bh=qFdKBzqTmmQ2nUPNK5GbW1ZYNZ25HnBX2G2O6O2qgtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JwJfNw/lMLXQffIjVCXrlngljneOT1KsD/CT/8dx3/6vAVvsTcZnnJ1wTHnCl3Dxw XVGw5FQj7scOr7UQIxB8HR9uSOUorhtAo4kd+tgEtBXjsjQwzhQZTeXgnGNdUACt4D 9beTUeZFLL7xehCRZzEPLn3AjkYwxquqQBZrAlX/KlOr6EJk2yTeZxJou3Ako5IG/F 1OHIY7IxbA0ypJHv2yVoW99OewAZqs9frGUN7abb0dOwEiF7uLiMtu6fUpyGDmikuf 9dZalQI5eoc2NMridpMayTavc4YYmAiZhddH1DD9OfrB9wxzfL7NgtspXoHi358r6C ps4EoiYlOWEkw== From: SeongJae Park To: Huan Yang Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH v3] mm/damon/core: remove unnecessary si_meminfo invoke. Date: Wed, 20 Sep 2023 07:19:49 +0000 Message-Id: <20230920071949.26063-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230920015727.4482-1-link@vivo.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6690080009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 733gndo69pegr4ripb971j589sktuezp X-HE-Tag: 1695194397-947660 X-HE-Meta: U2FsdGVkX1/80GKXbg7If+k7nWfrMU5FqJoCYWaEwBRGgGm06IyPsBN//U9LQBI3XWXLaeXkk39Ye5Aavff/PBtbBVQSw/loQyijnxg5nil9p4PEira1WEJfqQRgivKWl9T89nF3apS/vtyBahLHYtocHBtyvzGTrsMHnU+988hAT2yxMfMvJEZdhdpg1QT48EU2pA1F7QhNtj0ryRu6xcSQS/quHLmeZ4jPW5IRAFIMSpVeDscs9cNvqEOf1vK9p4wZ5gn2BVBzI1SgJMiBlW2YZAfU55evfKSRiPCHEL6ooryfVKTAXCKjDXwEfgHvuFZctU6eAiFUUwathXMbFh7U9Hn7laEP5LyqC7KlcXQ/q9g1ukmOZ147LCQyXseLCFGQSv2r50DK52LCWrfARb39tUDdVHJcZRd50to76JSGxbmscHcWhxhTMqQVAP+SNYFY+bYUgPngQ/Hy+F6N5GMoJgyfA+QrFlSGKoyINisdHd6XD8BPJRebAjTdsrkqpP484cAxDkJzXxdZcZBLkOJ2/oW3klHdSZemtCTJ+DsvvGx1ynMi3+zte5gXKAkzCLk3+8ORp8eUQ3yXz37ynhTfbg7dsLhj1N2sx/dbtALYmBETZ2OVQYHMYUSYfPsv+akx0BXP706ex6XhowUSruQU00f54eATkUEIopM/HCXLh9xp8gsTRvBgXo6qr3nicsuozx5rL9SKmpbx2bk3eETuutL3MFT1O1kVElz3rWim0VuDGzn/5/Qz3zt8XYLEo5SRN7vcotuV9UyiuJ5/hI8F8C6d9kcDL51toIZF2w87IIRYo6rM2azl6oXp7CQSfUwScPCZ4ANQ4uIUJYaocsxCxdd5ty1oOiLhza7Tn2VKVR0P6YUDXtxAHzt8S4pKWGkJiFjHVIUFePyb/1Ko70UGVFLgfz+h50MCRG1Zg61dFvhcNMsxo8sXoMXKUEC6Qpx7ZkRA/0TvSlFyEGd HhYzR7KF Gu2fPNHpv8V08aoYf0cJQCnIoyYysOTU42TDoi3qI0EZ0Ut81v4NOy2QBMpLSk1T48i660r+H/wY1uMqZ2mL6u2ISxtBHlLI3g8I7QJFszqXreqZxbpH3PzOD34q9f8A7rlgNkcJSkgdP6Xk7sdFEbsLrJQNhV/jjoa61SshnUXc+UsN7IAkOA11Dbu2EjxfykRtK+2LIiGLvLkslLWLjgU3MWij9Krz4NfKJGBm1et4oDy6EHuYD+qjyLHye258NCJrIXOtjB1/CQPLXrRJneW4DjpJNLwXl4Mu7is7hGX3JMm55Lhpk/GzQyfMsngl4owgze/yAohzPv377H3dw+oJa+yryOWh29itX+96gdJIvJxar3Flso0/YMxxAaxnQr8XV9ZFoEqTT+KLw9znGh+C/TVoJEbFe7X5/Zy5GtfN/lyJAy/JzlC3VH+Fxn9U92xFY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Huan, On Wed, 20 Sep 2023 09:57:27 +0800 Huan Yang wrote: > si_meminfo() will read and assign more info not just free/ram pages. > For just DAMOS_WMARK_FREE_MEM_RATE use, only get free and ram pages > is ok to save cpu. > > Signed-off-by: Huan Yang Reviewed-by: SeongJae Park Thanks, SJ > --- > Change from v1: > v1 fold free mem rate logic into __damos_get_wmark_free_mem_rate and not > invoke si_meminfo, just get free/ram_pages in global. > v2 cancel this __damos_get_wmark_free_mem_rate and just calculate rate > in damos_wmark_metric_value to keep it simple. > v3 fix changelog format, fix code style. > > > mm/damon/core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index bcd2bd9d6c10..6ceb52298904 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -1280,12 +1280,10 @@ static bool kdamond_need_stop(struct damon_ctx *ctx) > > static unsigned long damos_wmark_metric_value(enum damos_wmark_metric metric) > { > - struct sysinfo i; > - > switch (metric) { > case DAMOS_WMARK_FREE_MEM_RATE: > - si_meminfo(&i); > - return i.freeram * 1000 / i.totalram; > + return global_zone_page_state(NR_FREE_PAGES) * 1000 / > + totalram_pages(); > default: > break; > } > -- > 2.34.1