From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2AB4C04AAA for ; Wed, 20 Sep 2023 16:07:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25D706B018D; Wed, 20 Sep 2023 12:07:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E6FA6B018E; Wed, 20 Sep 2023 12:07:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0878F6B018F; Wed, 20 Sep 2023 12:07:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E4A316B018D for ; Wed, 20 Sep 2023 12:07:20 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AF3C4C06CA for ; Wed, 20 Sep 2023 16:07:20 +0000 (UTC) X-FDA: 81257455440.22.8406DAA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 3E9EB40037 for ; Wed, 20 Sep 2023 16:07:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GC5fYtzB; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695226037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NJKv3snRIAkFo+TfYPNM4u17jT5fzZ5G87THml5mtVE=; b=RhsOtvk7RIOu1ANuCjBQugksZHL2dRz8cBnyP76h32Ewo8t9jQqYF3zPkVTkPFHYtQG9Nm RUJNlLrjTFQCL++h9buw+KLMeZCyS1e9W/6FibPOs8LM2rne1v0TbV/NkO173uhfbLLUs3 771g8WrbFjnQ665+MhqU3rObvO+D4Hg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GC5fYtzB; dmarc=none; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695226037; a=rsa-sha256; cv=none; b=QQEIgMRfx1gICXTcQfaUzAUHE7xhrwWvw0tCMcl6kaNFx0gNTNNfIwry0YljYKJVXcmW1z JAjtk79bs40Bo9a94LAp7vj0Tg0eVw7KPbRNxbGHJq/l43/SAqHZdbe7IF/Fc4u3SXKpzK fHI9z0i4ERIPMhgCc5BFfzDE6h5YlMo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id EFF2DCE1B90; Wed, 20 Sep 2023 16:07:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29A00C433C8; Wed, 20 Sep 2023 16:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695226032; bh=3uzNs0nUQHnC8DAXANEMXp/C0mvTUZssBZN/6eeV6D8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GC5fYtzBtzOX3JkqCQtIzslv3qoM8bDvQUxJskQr/99qHmcGBQ+MzLtNmz3ifp8sx c4/gbsWY+hHRhdhIaiOIEikZOfDE0k1IhuPg9S8Lr2PGPQeE022Zfq9wj1iz0BA+jM MhpjYvhxqVJdy6cPQGGf3+L5OE93zQGX8S0PbO00= Date: Wed, 20 Sep 2023 09:07:11 -0700 From: Andrew Morton To: liwenyu Cc: bsingharora@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangyun@bilibili.com Subject: Re: [PATCH] delayacct: add memory reclaim delay in get_page_from_freelist Message-Id: <20230920090711.ecc2d84cc29bb0fa540f1999@linux-foundation.org> In-Reply-To: <181C946095F0252B+7cc60eca-1abf-4502-aad3-ffd8ef89d910@ex.bilibili.com> References: <181C946095F0252B+7cc60eca-1abf-4502-aad3-ffd8ef89d910@ex.bilibili.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3E9EB40037 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5b7opbq489dgc6gtbmgkf1rbefhmrxhu X-HE-Tag: 1695226036-65682 X-HE-Meta: U2FsdGVkX198RW7VYxWmsXKlWcZYipTfb+xFjFBYUKgm5ZFWXH9uzLHf4uytkoziDtiH0MesirFMPtXbsXlYurWX6MV5IIPWQkclk6jSGj8xd996pumrrhTCPCRx3PfEOQ9hbdMAapUS2+rRm695LyaLFjiyiPndEYPgMoqNlAJVlBS1p6ZQqZGDbe1kCiGMCjSTDt9JUZZWlm8xZLjKwLw8/JdYqiu7LXdZfrXEDmkgbayZ1yQ0n63yQFuwZbWC3MlZDK5ViiIkwQGXZ3RviT7diDrpeGU/CkmE3BvLSPT9wc67pWdjvihBrbUljWPA7q1Iwk824AhsBP5IXLYSWLFVlureFz129MhMkRTMpPi/f18ETMy2Sj9oagnjQuWT1BAecymIhj1aSZNt1Y+b9BW1aKJlrayuQgS8sccfRPPLROAZEU/cfTKXJHMAVBbHjU5b8acYaFVBpQKCbjcvUUVwMWt0nyJSPkwxC9fbHPs/VsjaHNSsLVXinNTBNMf8FNBToAU3gNDhORr1KvLcT46U8owpUqQ3WgGLySdybb6Q9Qv/0hYfWD6cj+zNQJqw+oXWqKbvQkLcmnfou4utlZCJcYVRf7dfTOLKKx+z2IoDpH/2xTNCsPd/I0+hw0Dzqo4srFcwFbgrL7yOy3w+sKG5TXbcmaGxLaK0Jdr7FmkEyxogX+ubXk+fPeBrZcfke/xJP9Vc3zHFGkyAnBzA82osroYR5067MGECMIBMGRf6Nf3sofziSZAmhPoUM8+sDMFzJKMpJDMMotUm3IXlPxBpdGl08CTyRQOrNGy5M7bbECxWYyZwy5wp0GPZd5SHoTKPudw9HQOWUSfku+xygb50U7IZlFzb5rAaMck3ZEcYhswKbbSbopUWOn3BW2ZkNQ6NGK93ApouSdWg8kyyWjgL3FSI9KiMJdMDFt5Hj01M21ryaR2s0V4Xo3iPoUO8fBthH6qzffh3inT7hBM fAM2C3LR CcqrLvRg5lXDwTRCXwexxyHnT6/JQR98dM7qyScE+JdpVcflIuw5/u+rhEME2zKq5eByjS0iRoPGkokyE/O28Dd/Qy/daHPMBRyoh/R5lzDeHR4oJa13mAOJvhjwx7sZoysDtANor1xYSCqtu37lavECKkjPLIRKwK05Y4PHof9PkUxVAQ4v53blja4uK/vMV5vPIayJGjJmFxuJzMKZtrJAMrr66voIjHsckiad+Y6PEgqw0rbcIitNpO+Ma++9hxvLp46Jfz8fxbCPSP2gr+mkHxc7bNazsETOV4Qa5CewCp/bf0zpEw33vmOl8jclNSOfqrm+Z+xHhwTO9DCI329SdX4XeSuMr0bBTL6h9756I9wwCAq6cf5yOIu6RuT/pR93++HVqkkm91cW9j0+wqoU5Qk62zjK6Cfo+8nEF9adFq2c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 20 Sep 2023 17:38:49 +0800 liwenyu wrote: > The current memory reclaim delay statistics only count the direct memory > reclaim of the task in do_try_to_free_pages(). In systems with NUMA > open, some tasks occasionally experience slower response times, but the > total count of reclaim does not increase, using ftrace can show that > node_reclaim has occurred. > > The memory reclaim occurring in get_page_from_freelist() is also due to > heavy memory load. To get the impact of tasks in memory reclaim, this > patch adds the statistics of the memory reclaim delay statistics for > __node_reclaim(). Please review Documentation/accounting/delay-accounting.rst, see if there is some change we can make to reflect this patch. Your email client is wordwrapping the patches - please check that for next time.