From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79DDAE71096 for ; Thu, 21 Sep 2023 16:30:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11BE56B0186; Thu, 21 Sep 2023 12:30:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CCC16B01B1; Thu, 21 Sep 2023 12:30:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED62A6B0207; Thu, 21 Sep 2023 12:30:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DA9B46B0186 for ; Thu, 21 Sep 2023 12:30:33 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A8CB0A0C75 for ; Thu, 21 Sep 2023 16:30:33 +0000 (UTC) X-FDA: 81261142746.23.41B059E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id AA20916002F for ; Thu, 21 Sep 2023 16:30:31 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Sy+EhpEK; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695313832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ELVvPtLpBggjwwjsyHS/fdpj7bItbiduJJDg7MR2fc8=; b=Usn113rel0rM7XTZvy/MuSVbpxXaUXxxNFDyZMTO6FvXIXM6afpm+qDuQrrPjp08WmsVPb faaZN6jXOsLRZ4A+IWeikQxcl3F5I1mg4LfgQ7E5+D+p4AWCD8yHWtvVYyV3mpHnKi3kqx rhB5GnZ6UT67S23vUUMhu40v+TMbef0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Sy+EhpEK; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695313832; a=rsa-sha256; cv=none; b=dY6XhmvZtWqREUTYEQn8GMZdFkZY5ji6QA9SgoFRUzdQB2LL+CdroqlAlwaYVf3+BOynHe /Z3t4F+AFnK/rAm3QSxbkbU0dEj7DgSz2WljQS41ZquPDyM7QYksmcTq8HRsW1Q1TSarrg 1gAjHjW+VYLTaKdwdj7RZUq7tsh1S9E= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C89DCB82159; Thu, 21 Sep 2023 16:30:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DD95C611AA; Thu, 21 Sep 2023 16:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695313828; bh=Snl0TDHOoq+PcJkslOz6yzyz3jV/ILGMNVGDPT3ALVI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sy+EhpEKmklRoXizWavrDSv+mOOfZ2nUh7nbNkMhlDLbnh4hSgBtM2DfmKEv4UzUL Pv6q7E7wnTnnSz2jaiJSSK97ktzV1tSKKpfyQ3VEqmLQ/I+fVqkhoc6rt2Al+4iGM9 C9VSqdRkP4rrRuEL9YXgvk8jJTKJGqA4Ygoc1IFE= Date: Thu, 21 Sep 2023 09:30:26 -0700 From: Andrew Morton To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64 Message-Id: <20230921093026.230b2991be551093e397f462@linux-foundation.org> In-Reply-To: <20230921162007.1630149-1-ryan.roberts@arm.com> References: <20230921162007.1630149-1-ryan.roberts@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: bqufsz9qyithknr79r7pwmmpz75hgofi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AA20916002F X-HE-Tag: 1695313831-852596 X-HE-Meta: U2FsdGVkX18sqXwiIeqIjJ8Rg86lOZ+oZW9p+6iobnCaVme1S/745pesVfZDTw9z3sMrbjRRHallwPLGTsS86CMWLFX8yGfg3NMFbL7O4a+PP6+GweMIVHE0++eQO9q/PYfYH5XRBHYnOkrjkhhT7lJ14KrVX//wvFdhtivL5+lbp/EAtHcZKXJovgclYRETQIqRZXvSaU1hGwCVedWIpmBSOnbqa2YCzgaUp7XuVVasbXnnKTXtzD+qXU+mUJbMorVZ7hBQWHzgBCzLHfKVnDMeKKlYOdd0ZwuYm3q8fxDaq0CPoQ+AiQmHg1hffDJ5iKowoPjAjTFuWnVZc78mHOJYFz/wvGifUiDRcGgYHAIAypiWt0HGmu8nbD1H30Ej3UPF+WXMDDiasFgZBt4NaS09a/WhlqO800k1k6TgLcZzKFnRMj5vkQf4SsmNR/M3HDTcYK3WmdVJ7cG9EChcnhgaoqh6C2dz0lXfvrCVIfUlLhYjZgzXiTuHwwEvR3DwgEKqe/zlSdYZoJ2LovkX+TUeHI78jXp35tJiybCnPdgDex1dbw7C8hOqJZdI07Yr2Jg+onSmwH7FIUXe5Pipf5+54cFW9MJXxAIUJXLq/3qhCy2+94a3IKN5tXNYfC706dMnjcxRsZBeFZUflBNzgMAWBc/kJcPzdlfJfil9xa6o78LWtWcU3Bkqlj61/de+GBcdpZtDt6BP+fn7m4B0D4hp5s9nZEZm1fqYJYbFiMs2X3yF6Cg5fyEXamEQtOxwfdVI72wBQJZ3iXkoYObKOujHwyWLmLD/JfiSLA2XzT1B2tde/R8GUKa8qQrzszprm4U0KzmKoKHKL6hrjEkFWJiochxB0EInH2OUmS9KCLG9N2BkLctKuNk7qSBT+haxEd0k+CUk7JYLUA4uhbMXZWEXQ32+Mr0uuJtf1Vl86BQuxIAYPdsrLg2PboMBtOY3PjFVzL+1o6Sf53145GR KRzvkmZm 7nUPCWJ6EGSn2TklIIL1bbFY4qnw89kotk4If0jc6u1nPMTB0UIzw3GghwoWLTdfG1Oc/my1qpE+leWqXthyvPQlf6JRJJnVkYFvXJeXs5bXnpmEh51Pd2WeyxNZTrKHvv7DD/oV2MB+RkbVVymJQ6hcjRJ8KikDyVWMqmMguaYYy8x8EUR4OntrhY7QtXjJfBJPd1wXvq13bagqJ0W8ue10zcfezrAtK75UG7pkuyfvjE2f4JpTOlpUBeu/k7Cckv5drCXU44BAW2fzdOiD6SxbTjQw0AnOfyY7TyPY/vIjiYdWgRh8kW/Z0iLkdGJANPyPTsBsIqcb/x7wB9bpcOCGMMnnBEFfYs7j/xlbZ+V83K+TrM8jqNNkcNqS79TbBvTcebEtNjJu6txRt4w6Ydt4mY+SLiT24UkpsH5zMGM3k8pr8jO9Q6TNCxIhrx/NNwGHjW0PGRQweENsyrx86u1BAkkPsksYc3rTsM2mgDLSAPka3S5wtQ5vX7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 21 Sep 2023 17:19:59 +0100 Ryan Roberts wrote: > Hi All, > > This series fixes a bug in arm64's implementation of set_huge_pte_at(), which > can result in an unprivileged user causing a kernel panic. The problem was > triggered when running the new uffd poison mm selftest for HUGETLB memory. This > test (and the uffd poison feature) was merged for v6.6-rc1. However, upon > inspection there are multiple other pre-existing paths that can trigger this > bug. > > Ideally, I'd like to get this fix in for v6.6 if possible? And I guess it should > be backported too, given there are call sites where this can theoretically > happen that pre-date v6.6-rc1 (I've cc'ed stable@vger.kernel.org). This gets you a naggygram from Greg. The way to request a backport is to add cc:stable to all the changelogs. I'll make that change to my copy. > Ryan Roberts (8): > parisc: hugetlb: Convert set_huge_pte_at() to take vma > powerpc: hugetlb: Convert set_huge_pte_at() to take vma > riscv: hugetlb: Convert set_huge_pte_at() to take vma > s390: hugetlb: Convert set_huge_pte_at() to take vma > sparc: hugetlb: Convert set_huge_pte_at() to take vma > mm: hugetlb: Convert set_huge_pte_at() to take vma > arm64: hugetlb: Convert set_huge_pte_at() to take vma > arm64: hugetlb: Fix set_huge_pte_at() to work with all swap entries > > arch/arm64/include/asm/hugetlb.h | 2 +- > arch/arm64/mm/hugetlbpage.c | 22 ++++---------- > arch/parisc/include/asm/hugetlb.h | 2 +- > arch/parisc/mm/hugetlbpage.c | 4 +-- > .../include/asm/nohash/32/hugetlb-8xx.h | 3 +- > arch/powerpc/mm/book3s64/hugetlbpage.c | 2 +- > arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 2 +- > arch/powerpc/mm/nohash/8xx.c | 2 +- > arch/powerpc/mm/pgtable.c | 7 ++++- > arch/riscv/include/asm/hugetlb.h | 2 +- > arch/riscv/mm/hugetlbpage.c | 3 +- > arch/s390/include/asm/hugetlb.h | 8 +++-- > arch/s390/mm/hugetlbpage.c | 8 ++++- > arch/sparc/include/asm/hugetlb.h | 8 +++-- > arch/sparc/mm/hugetlbpage.c | 8 ++++- > include/asm-generic/hugetlb.h | 6 ++-- > include/linux/hugetlb.h | 6 ++-- > mm/damon/vaddr.c | 2 +- > mm/hugetlb.c | 30 +++++++++---------- > mm/migrate.c | 2 +- > mm/rmap.c | 10 +++---- > mm/vmalloc.c | 5 +++- > 22 files changed, 80 insertions(+), 64 deletions(-) Looks scary but it's actually a fairly modest patchset. It could easily be all rolled into a single patch for ease of backporting. Maybe Greg has an opinion?