From: Steven Rostedt <rostedt@goodmis.org>
To: "T.J. Mercier" <tjmercier@google.com>
Cc: Jaewon Kim <jaewon31.kim@samsung.com>,
yuzhao@google.com, kaleshsingh@google.com,
akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-mm@kvack.org, jaewon31.kim@gmail.com
Subject: Re: [PATCH v2] vmscan: add trace events for lru_gen
Date: Thu, 21 Sep 2023 12:22:44 -0400 [thread overview]
Message-ID: <20230921122244.1cbf2d57@gandalf.local.home> (raw)
In-Reply-To: <CABdmKX1V-yPF260gORh-0LFkL+bDfPhOJteiwBjg1v6rYgrvgg@mail.gmail.com>
On Thu, 21 Sep 2023 09:12:30 -0700
"T.J. Mercier" <tjmercier@google.com> wrote:
> > + TP_fast_assign(
> > + __entry->nid = nid;
> > + __entry->nr_reclaimed = nr_reclaimed;
> > + __entry->nr_dirty = stat->nr_dirty;
> > + __entry->nr_writeback = stat->nr_writeback;
> > + __entry->nr_congested = stat->nr_congested;
> > + __entry->nr_immediate = stat->nr_immediate;
> > + __entry->nr_activate0 = stat->nr_activate[0];
> > + __entry->nr_activate1 = stat->nr_activate[1];
> > + __entry->nr_ref_keep = stat->nr_ref_keep;
> > + __entry->nr_unmap_fail = stat->nr_unmap_fail;
> > + __entry->priority = priority;
> > + __entry->reclaim_flags = trace_reclaim_flags(file);
> > + ),
> > +
> > + TP_printk("nid=%d nr_reclaimed=%ld nr_dirty=%ld nr_writeback=%ld nr_congested=%ld nr_immediate=%ld nr_activate_anon=%d nr_activate_file=%d nr_ref_keep=%ld nr_unmap_fail=%ld priority=%d flags=%s",
>
> Many of these values are unsigned so I think many of these format
> specifiers should be %lu instead of %ld.
Other than this, from the tracing POV:
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2023-09-21 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230921061944epcas1p2f8a022282709da12840b33c0f5898b5f@epcas1p2.samsung.com>
2023-09-21 6:22 ` [PATCH v2] vmscan: add trace events for lru_gen Jaewon Kim
2023-09-21 16:12 ` T.J. Mercier
2023-09-21 16:22 ` Steven Rostedt [this message]
[not found] ` <CGME20230921061944epcas1p2f8a022282709da12840b33c0f5898b5f@epcms1p3>
2023-09-22 2:27 ` 김재원
2023-09-23 15:26 ` T.J. Mercier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921122244.1cbf2d57@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jaewon31.kim@gmail.com \
--cc=jaewon31.kim@samsung.com \
--cc=kaleshsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=tjmercier@google.com \
--cc=vbabka@suse.cz \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).