From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C811E71090 for ; Thu, 21 Sep 2023 16:22:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 388F16B0186; Thu, 21 Sep 2023 12:22:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 339186B01B1; Thu, 21 Sep 2023 12:22:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2278D6B0207; Thu, 21 Sep 2023 12:22:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 129826B0186 for ; Thu, 21 Sep 2023 12:22:13 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DC1011CAB74 for ; Thu, 21 Sep 2023 16:22:12 +0000 (UTC) X-FDA: 81261121704.05.EB24B6E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf07.hostedemail.com (Postfix) with ESMTP id 0D5B240023 for ; Thu, 21 Sep 2023 16:22:10 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=qnPZ=FF=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=qnPZ=FF=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695313331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWj1FhXdi/Y0f0UF+VfQSJ5yEqnj91ecs//KLvPtWJg=; b=puFv+PyAjRYP0dJ7o740BMk3czi/ag4mXhPY3CAh4hFhOA1fVkIAOqZNIac9D3VRXMkquy tmpVnQ0JN7OyrwDgMlcoATDyU0aGSH7KeZpC1vluVBGd0y+T4zwKs869Ad1CAtUOlZdJRM NnnKyAF09EysO9r9Zw/Cet4y2n5N0HU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695313331; a=rsa-sha256; cv=none; b=IjpIvpyoAlVVmq5qDDYDYhQG5b8CB9mC+R9Yvcv0AB9FMOEUacpCxUnRctF1zMPLOUuHEk oypl1Owx9UiItGl3YB9pz2ptDzhuP0gKil+qYwHvV09rl+rRHdpSlzI2fXR5p2m5Ag12J+ pwsmQoNVDAIXFR+3bsLYKCbgU/nR9fo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=qnPZ=FF=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=qnPZ=FF=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8E353B8214E; Thu, 21 Sep 2023 16:22:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01FDBC61187; Thu, 21 Sep 2023 16:22:06 +0000 (UTC) Date: Thu, 21 Sep 2023 12:22:44 -0400 From: Steven Rostedt To: "T.J. Mercier" Cc: Jaewon Kim , yuzhao@google.com, kaleshsingh@google.com, akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, jaewon31.kim@gmail.com Subject: Re: [PATCH v2] vmscan: add trace events for lru_gen Message-ID: <20230921122244.1cbf2d57@gandalf.local.home> In-Reply-To: References: <20230921062206.14429-1-jaewon31.kim@samsung.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: zokwmisptonzczzqke31rch8cayqz5gf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0D5B240023 X-Rspam-User: X-HE-Tag: 1695313330-647567 X-HE-Meta: U2FsdGVkX1/AIx7xYLl6oDNqk6nuB774siE2GIfA/M7IWtKDwptfjTvEcj+R5nTBsWWwBBTA56aYCcj8VxEllJUGNX/dz310ZZV/3UHuSfpI8ftmf7hpWeuWOZMSd4GNfFo8BmiVdg4yNjjS7aoW/1tV3NRenLCqib3I3DhDQs1FG62sB+AZ8xtzSQArSOJVGuBrBqIGMfOXY0nrzKgNvZPmMckNo5uidBsNsBM2LmU4rx9ezH5gO9MK+UtEoHd9R4ExCoOBDyKpRl398CPwmzEix3DDkytollB03aNPNVBffSrn4eQa5UuhqDT/LYmSEh5DKt4Ub57UD6j94qXwbCHtLdUlhSuzWWLGE29sz6IqLOsON//bv/VTVnOvdS8m70jEHjzUd97xnPFPI3hQkdxHdkCVOeh7Jj8NZmdXWHwnHzPeDq//PA5d+lfXJNMy3Z+Xd0v0e4gYECdyCyUDAUZbamDvf6QEgpmpB0uX950bvKSyK9k+NT85YZ7u3uAa0fRJqbIrWcZhnBpMWoEVY8+QqgzRAumgYefqrPTern3TgvHlcN6Aodzi9FODYahygef5LSR46mONLQ7Kfd6eIO7JFYk+LL7G3/NQSHSH7zC/Tkp/H5s3ZG+0ivZThcVs92+Ns/Qd1HYCZZgtrHA05nNTMT09GifboV8cTaZUil+MtodSqf6OEiPJGQjUpRluiekSTbhwywM2AIuaEcA8iFi/kf1e55+f6NofmuexShzop4h5p/v3X83sZUC1tGjz6OiYa1kqJBK9c7WNuHZ9eQzyUWofPrTZrEP+PAnRCorR6j3u4jQGaxmUd/Cmi+oXGRWPAn9g0BZSemkyCse6udbLAhVe8kPXhNBwFenNYcACd62jy6zYO37YnpOkwoukC1PlG+9FAf5VhuCdOf+8cvE4PKwm2XobAkTw/xfz89UwZYfNJIYJ1ZozsSlg47rVrUC8EyQAOBamDQwR1A+ y02sDH4h zB7hgSvVYmkozLlI/EwofNEKo+D4v/Rkso3HDlv7hTNtRISGcDa/m1vRxyvLNrt/ZDl5pM3QCo2v+kpNBc6riYLZF7tju+r2FiZT0hZpGFKhhns02JsE6AvinHSke6pWU+Nmskc+HO/TGkp9lkOe7/pVL3eDB7m2G8ryqVwPjGPPV0FKC4NUNicOsG0ittS4NKfMtq565u2nXLeW2Zko/Y7yWrl6b4M+IPgq+HPvI6POzmMqghilEfrrchiQ5n3dz7HZVQj+gLI1XJhxhnR+hRYL3PYj+3MYPAX442ZXm0Ek6dYVE0VhDWG8O/XoGFXWFxPtK64hysOr4RD7wKFU63YkulQJZzPcNUMYGfw7ZOO+yjA2yPHbXtbhjRUmIdcREn86Xtw5YkgcCLcGGnc0PAsucxuvXeS8ZuVErkM46wQFJi0JqxIfTT9QecSKscUiB5f+8nC9MNG9++vtHigQW200GmOpGNgPxhqr8BxXx5Db1TqXP/K6YO0wsXFOEGiRq7p+P2842lkKstBgLtUCLncBj8Pvs+Dixk73iQSS8HyGE4CA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 21 Sep 2023 09:12:30 -0700 "T.J. Mercier" wrote: > > + TP_fast_assign( > > + __entry->nid = nid; > > + __entry->nr_reclaimed = nr_reclaimed; > > + __entry->nr_dirty = stat->nr_dirty; > > + __entry->nr_writeback = stat->nr_writeback; > > + __entry->nr_congested = stat->nr_congested; > > + __entry->nr_immediate = stat->nr_immediate; > > + __entry->nr_activate0 = stat->nr_activate[0]; > > + __entry->nr_activate1 = stat->nr_activate[1]; > > + __entry->nr_ref_keep = stat->nr_ref_keep; > > + __entry->nr_unmap_fail = stat->nr_unmap_fail; > > + __entry->priority = priority; > > + __entry->reclaim_flags = trace_reclaim_flags(file); > > + ), > > + > > + TP_printk("nid=%d nr_reclaimed=%ld nr_dirty=%ld nr_writeback=%ld nr_congested=%ld nr_immediate=%ld nr_activate_anon=%d nr_activate_file=%d nr_ref_keep=%ld nr_unmap_fail=%ld priority=%d flags=%s", > > Many of these values are unsigned so I think many of these format > specifiers should be %lu instead of %ld. Other than this, from the tracing POV: Reviewed-by: Steven Rostedt (Google) -- Steve