From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D696DCD4F3B for ; Fri, 22 Sep 2023 09:23:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49FA66B0172; Fri, 22 Sep 2023 05:23:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4760E6B029F; Fri, 22 Sep 2023 05:23:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 365216B02A6; Fri, 22 Sep 2023 05:23:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 27FFD6B0172 for ; Fri, 22 Sep 2023 05:23:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EC5DF1CAD7E for ; Fri, 22 Sep 2023 09:23:16 +0000 (UTC) X-FDA: 81263694792.19.8B3C72C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 3DE7240013 for ; Fri, 22 Sep 2023 09:23:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=HC7A5qwR; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695374595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f2VIZd8yvq2saPXDeXi2dlb45kvjwAdJW8USfYyQdzI=; b=CDP2psWc6MDLdjAwPQRcRhWsjsZD1JUMd9xmoNCtYchDU3q/rPjwxt8/E/DJ5TgdkS1UL4 cwyq5RFgScyZf1E14yyg16pWgr1JAuPIm1XCgEb0G7Ko2R99BQLVyrXADZIEnxGaqzJe7q rosLWWCvtWx715DHsuYvKjcgI1vORvo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=HC7A5qwR; spf=pass (imf04.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695374595; a=rsa-sha256; cv=none; b=7fdorA5EGNheYH0oD6ppxolu/qzo0+x4nlA90KvncnD92P35bY3qRREb0YyRLmg+sAa1+X FhgIQoWvw6kkP3Cg30O62PzSvdGBf06TPM6LQPDx73IBT+WqmXAFRuma+oASh6XBgiUofX JA9HRrp+1sbrpIDqxjJgTdvs5qHRvYw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C159621B4; Fri, 22 Sep 2023 09:23:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32460C433C7; Fri, 22 Sep 2023 09:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1695374593; bh=dXskQX5Hl5xkPtfaxV8tcYegxNU8vst41m8wxd6lccM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HC7A5qwRYefrtsRKDVgbV8LB3GlGNnwCiuzuBjBf//079Vr5pHlHx7w33piVwkMSg KdakR66MrSNSkYJO3jbZwCr/w2VTw33wUH/TvBJA0dAAYl+WQ5Z5GVudGyrcU4/vOf 0KADD+v5vZCFHY1cz6sqX/igDr/hO6uHWrXxgxmY= Date: Fri, 22 Sep 2023 11:23:12 +0200 From: Greg Kroah-Hartman To: Ryan Roberts Cc: Andrew Morton , Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64 Message-ID: <2023092208-sitcom-playpen-b62d@gregkh> References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921093026.230b2991be551093e397f462@linux-foundation.org> <7c5c2c00-d657-44fd-b478-743b43c57e8a@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c5c2c00-d657-44fd-b478-743b43c57e8a@arm.com> X-Rspamd-Queue-Id: 3DE7240013 X-Rspam-User: X-Stat-Signature: wwkzimgtnapjcs84wnoerhwuuwr4uaxu X-Rspamd-Server: rspam01 X-HE-Tag: 1695374595-374213 X-HE-Meta: U2FsdGVkX18k86AgiqvF9Ra0RwvcZvVe4piPbYfGaEWkdDFX+v37ezlABltPID9Z2icu1ixHg2KKwrTL0OqklHdRdmCw6HBroBXHp46tsZlPGIXZFytVeW+FogHuGlol9wBn13YxLFLjj7Nm2DfgyG4MN3rLUgkbamCTWYblGuO8cXzm+ao8ny6n4A76gPXW95SLIe2hX8LRh8vlXREnxIkCGAFPqeTnPI4KviNp4LL8SLtnSycozgg4JUIJFVTGeF6Dj5qjv+En0aAOwGYOOtQU0yjQ0gU+T+DOcPjoGCIMaN35y4wXeujpY5jNk4l4a8cfs56yH6F5nQYtGFa6bXEpTLtUfmi6sAEIXK1wrcHO8HjW1PK5asHlEQ5wYXMsF3pYf19yfbJcU2vIUkFGQNhZ9W2a2ojpiNW78n2MRuzXTndDvxUP86D9p33cHinKH3jpVzvlMavP6nitW2fL5bZ0Tc6+168jEgFbAZ9Qs+E0hocehOUmuYcdKZrOcdp2/LdwHMErmnJ1/PwbbHXUJ+AJzSCBWFgEnoWz39gxK/+bPqMkiR2oAm8Oxk1UFJPoOOVC3Iefd+0CUcwyhb64qZCFgESqWDsHdh+0ISOTg2C8w9U+DxfsFngkKOOHQSdliLt2IWCqNtuV+VhiDJcvlUmtYQjD1mJooPdNshPwGaq2xkV/Xi0qbRtiNpfmnrXo4isp74qkAdXIFUSeS+Dh4goMiHqGEw0AX5GzMHltkd3y9bdWutTsWzTUHe/83LwL0LKCu+0F1QJio+ud/W5QorhRppZ/8n12dJuWPAOFMuLGpZNAGwfZRskfVYbfxd3gnRcvwdbq5GdFSLrJ1p8Punqa4HcQ4QYMcJcNzEOM+588oyruFAlPoC3X8SJFs2zF+9Nkbm7Y0F4tNAddrseqLWHSo5E13fu0rqBy3JSBTdKRiAObSEKtRCGBIBOiM58Gc6/no3BudUPMas/698r qd66vNbW eeBlX2F54cM9gICl/XHWbOtE2DGmzEIc9Gm+ZbCI1idzNIEYLfulmYs3v3eG946NwklJyPtNdAm+0cKggYOK1JgBuP8VZshO2i3EOmcoH7YRIl+EdPZ18j74SzUkc+fHyLkT3hp7cpRB1/U/flRR9qWePkLK7mfb26HDq5K8GE/T6XitZQNF8YAhSsJ3KSR9Ar2Qx9itJwVYYC26QLfijFHjgd9uhwN+xGuqa9TUoJKLtU6SOai9Ag/5IKCQa14RADxXUkXNgzgfbDUly/3z48Yy9878KCvvRslhaBc40bgzSNZPHxEujtBd54FZa4d9Um4ICvUPh7gNvH/OiTHX/hBx7xY7Ec7ZWDdYmVZiNygV0Ugt8b1OYioe2AaySVHEoE0i9156G3QdqdoOVvN0ubDfh8teCvikocYzeWJLes0/RK7DBIFQ5k1kkTaDu+1XAybplNfoN3W0A0c8YF7FHimGmZAe3GJxiZFSc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023 at 05:35:54PM +0100, Ryan Roberts wrote: > On 21/09/2023 17:30, Andrew Morton wrote: > > On Thu, 21 Sep 2023 17:19:59 +0100 Ryan Roberts wrote: > > > >> Hi All, > >> > >> This series fixes a bug in arm64's implementation of set_huge_pte_at(), which > >> can result in an unprivileged user causing a kernel panic. The problem was > >> triggered when running the new uffd poison mm selftest for HUGETLB memory. This > >> test (and the uffd poison feature) was merged for v6.6-rc1. However, upon > >> inspection there are multiple other pre-existing paths that can trigger this > >> bug. > >> > >> Ideally, I'd like to get this fix in for v6.6 if possible? And I guess it should > >> be backported too, given there are call sites where this can theoretically > >> happen that pre-date v6.6-rc1 (I've cc'ed stable@vger.kernel.org). > > > > This gets you a naggygram from Greg. The way to request a backport is > > to add cc:stable to all the changelogs. I'll make that change to my copy. > > Ahh, sorry about that... I just got the same moan from the kernel test robot too. > > > > > > >> Ryan Roberts (8): > >> parisc: hugetlb: Convert set_huge_pte_at() to take vma > >> powerpc: hugetlb: Convert set_huge_pte_at() to take vma > >> riscv: hugetlb: Convert set_huge_pte_at() to take vma > >> s390: hugetlb: Convert set_huge_pte_at() to take vma > >> sparc: hugetlb: Convert set_huge_pte_at() to take vma > >> mm: hugetlb: Convert set_huge_pte_at() to take vma > >> arm64: hugetlb: Convert set_huge_pte_at() to take vma > >> arm64: hugetlb: Fix set_huge_pte_at() to work with all swap entries > >> > >> arch/arm64/include/asm/hugetlb.h | 2 +- > >> arch/arm64/mm/hugetlbpage.c | 22 ++++---------- > >> arch/parisc/include/asm/hugetlb.h | 2 +- > >> arch/parisc/mm/hugetlbpage.c | 4 +-- > >> .../include/asm/nohash/32/hugetlb-8xx.h | 3 +- > >> arch/powerpc/mm/book3s64/hugetlbpage.c | 2 +- > >> arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 2 +- > >> arch/powerpc/mm/nohash/8xx.c | 2 +- > >> arch/powerpc/mm/pgtable.c | 7 ++++- > >> arch/riscv/include/asm/hugetlb.h | 2 +- > >> arch/riscv/mm/hugetlbpage.c | 3 +- > >> arch/s390/include/asm/hugetlb.h | 8 +++-- > >> arch/s390/mm/hugetlbpage.c | 8 ++++- > >> arch/sparc/include/asm/hugetlb.h | 8 +++-- > >> arch/sparc/mm/hugetlbpage.c | 8 ++++- > >> include/asm-generic/hugetlb.h | 6 ++-- > >> include/linux/hugetlb.h | 6 ++-- > >> mm/damon/vaddr.c | 2 +- > >> mm/hugetlb.c | 30 +++++++++---------- > >> mm/migrate.c | 2 +- > >> mm/rmap.c | 10 +++---- > >> mm/vmalloc.c | 5 +++- > >> 22 files changed, 80 insertions(+), 64 deletions(-) > > > > Looks scary but it's actually a fairly modest patchset. It could > > easily be all rolled into a single patch for ease of backporting. > > Maybe Greg has an opinion? > > Yes, I thought about doing that; or perhaps 2 patches - one for the interface > change across all arches and core code, and one for the actual bug fix? I have no issues with taking patch series, or one big patch, into stable trees, they just have to match up with what is in Linus's tree. so if it makes more sense to have this as a series (like you did here), wonderful, make it a patch series. Do not go out of your way to do things differently just for stable kernels, that is not necessary or needed at all. thanks, greg k-h