From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6040ACD4846 for ; Fri, 22 Sep 2023 17:20:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFAD06B02EC; Fri, 22 Sep 2023 13:20:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C83F46B02ED; Fri, 22 Sep 2023 13:20:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFE6D6B02F6; Fri, 22 Sep 2023 13:20:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9E2D76B02EC for ; Fri, 22 Sep 2023 13:20:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4ED061CA4E2 for ; Fri, 22 Sep 2023 17:20:24 +0000 (UTC) X-FDA: 81264897168.27.7FBCEE6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf14.hostedemail.com (Postfix) with ESMTP id 18ABE10000D for ; Fri, 22 Sep 2023 17:20:21 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SdX6tRI4; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695403222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PPHFLbzbu9ybEyhND16lIWSNA3s9x9LVTO8n/V1wcvE=; b=GksetoxZkOd7udy/ss8lUqGzFwvlGkaO6+OMkXDo4FS0dQyZIvNe4wSUlbP5Ivt/RfKqzH /I7hVjBw4icdHy8Hn57y2Ks9WggoF9tMpQ+dbBMKtXkNwyxlIRUqq+7ndCbE2X3rz9woZM EFdCsWohdXozIJjDpquPI5vJYLO4eBE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SdX6tRI4; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695403222; a=rsa-sha256; cv=none; b=FmLUrEVQtcASvf3fmcAG8gx6rEQ89mDW9b7lQbr3LetbUfLXw9/i5SB9Tr4Sy1Fedo5kJQ tCEw33lqUCv1EacCeqYgpURLbIJCA9LQqKTxJIBrOArYWVpB5nTaOCKy/ItP4YEMh/x+EK W91SzBBUyqolJD7asLj2ZzkqMGJFnLc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id AF513CE243F; Fri, 22 Sep 2023 17:20:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DC67C433C7; Fri, 22 Sep 2023 17:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695403218; bh=IRau8b5XGe3qEYgJQvRo4yzSY5zEVQssEPPROArtjug=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SdX6tRI4jMHI7b7K67i9g314zNNszN6vEJLecg9UFiF+cebpsKDyHIsQrhvfjBQX0 ky6HdGeB74v+yS+mYqEe0HJyTJzY6Imvxt3ZexpbbSQPfZowZhxVOVf7tquOmjTbgJ tQ8PkASq2Vb+F0t7Nm0KIO9RjyGhZBmZkYaCaObQ= Date: Fri, 22 Sep 2023 10:20:16 -0700 From: Andrew Morton To: "Zach O'Keefe" Cc: Yang Shi , Saurabh Singh Sengar , David Hildenbrand , Matthew Wilcox , Saurabh Singh Sengar , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Greg KH Subject: Re: [EXTERNAL] Re: [PATCH v3] mm/thp: fix "mm: thp: kill __transhuge_page_enabled()" Message-Id: <20230922102016.95cab3640b17155a846874d9@linux-foundation.org> In-Reply-To: References: <37c2b525-5c2c-d400-552c-9ccb91f4d7bf@redhat.com> <3e08d48b-7b70-cc7f-0ec1-12ad9b1a33db@redhat.com> <3408ff54-f353-0334-0d66-c808389d2f01@redhat.com> <9f967665-2cbd-f80b-404e-ac741eab1ced@redhat.com> <20230906065817.GA27879@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20230920054454.GA26860@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 18ABE10000D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ip4gt9r1wp3zfp376eqkscpzc6k4qjm5 X-HE-Tag: 1695403221-251561 X-HE-Meta: U2FsdGVkX1+2IxKScHBHaBgcH7BWWJJIlPHbJ0V+7IdX953214d2uBdnsyEnsQn/HARSEGVl9fVvMQuH7fd5LXte/LVYNv1TzBoAnDRCkZ6sYYESoUNjzSytSC4ebEJseldn44OdUGFA2ppItewz4p8nmq2JGhmaGIm6daF7XDSRUGDN/58MCoyh5oeOpFWccQDq3vluRHzK9/hFtDmcBGZAxTFNXICCh9gQDVxQaBrTcvHS5lBq+ISdoyQOwnGBD3OOxNbxGGwdohmxQcPVnDtzi+fC6oxTXYhEEH1f/2/EWRamosm8LPO0M5qv1QGpkcgqjwWUOFBKMfOvcamvP+GNFSFAKpMA4a+BrHZsiY0UTErG3z1RtqdxZBfcEUMdEYApuLgt9jImguy6AJ7UVuCpFicLV7dba/bQAZRgAA0PJml0QwdRQ83jXAlRF8FUzADgwZ+icz2T3qfPy/TkF9cLh54JCWprrV0VBJHG/u6H6kDnYaH0WlQGfv2E3n1EZgBRk8S4YKdeQrqanK4FmWkrXnFkfZ2vb4H6Auba0hBwfhKe0yj2tCDwUfRwEbmlTdEMGqhsdX66JjjrbVkP9rj4Iyyf4mOO+L9xBe8AmxVZnur87WsgqT9JgEqWoUm70IQ4xGvQpvmyIi0afRnT6Mq1pf6uXufThVFB6oVXrW4aTz+VMaZoVNwGAVfnY/fIiMxg3k4mAzP9MKnlrKhVhHrxiuKRMZqJX3PRmK3zFdu4DLHbCkfa8Rnc5001+o4WHSakHLyetRZsBb6JivueJsIsZJKpAvIDKWJk5bQwo/j4adnMGml7vnARwu69TvpdsulOBGLoF5LxDMR5aEnRoB1BAloB7qceYEUMj4ZEnQCk1NgGQwp9zPdYLvpYBE/G8nl+LNWnAUlE9nJbmsfmbLPLuIdY4v6Fis3HhUEd2bcbQpMreoY7iwzm3bJpHY75Ad8Gbz0vA5/ZxBYoLte GZMwSDeb CooMNmSDNAV2tgtSUxhQaUT4jhUfDGMTLHu5tbDwptqAbYJDxIC7gE4zCUIuFQW0JfqjZaFtEmDQrUeiJVelx365n3JGT7x+Cfnq0D79CGroxzjnjmVIAG2MRWywgH6bhAGWM/qyKfgLnPuu/I72p35dc4rlCWSRmCwyXGV0+EXu1Jkk4mzPeawGOzAZJYS4NkQR4GRLHw8aACMyKST4UdKs1TYbwOLZ1KD5cz3F/xmcvq+/h6SaR8+nCR9AuDZtxtCh1V/5VtybLNvBWupjen8pRmyMDcrczbyF2ENqgDYbil/E9zA2YqOUa8XZTy4MN7mmVaQKTx3XITfFNReOiGz5p7+Pt1EdB2i8+mu6SzuwyXQVzz2Ebbh/eog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Sep 2023 09:56:21 -0700 "Zach O'Keefe" wrote: > >From this back/forth with David/Matthew, seems like we're OK saying, > "this was a mistake", and that we can take the patch (need some form > of Ack or Reviewed-by from them first, to confirm) Yup. And please let's update the changelog to reflect the details which have been discussed thus far. If the change *makes sense* for the current kernel then let's proceed, regardless of the broken driver issue. But adding a cc:stable would require extra argumentation, which I will be interested to read ;)