From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A7BCE7A90 for ; Sat, 23 Sep 2023 15:42:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 709E26B025F; Sat, 23 Sep 2023 11:42:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69C916B0260; Sat, 23 Sep 2023 11:42:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55A106B026B; Sat, 23 Sep 2023 11:42:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 42E096B025F for ; Sat, 23 Sep 2023 11:42:01 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 15F4AA0AE6 for ; Sat, 23 Sep 2023 15:42:01 +0000 (UTC) X-FDA: 81268278042.22.1458351 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf11.hostedemail.com (Postfix) with ESMTP id 3C0D940004 for ; Sat, 23 Sep 2023 15:41:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bKxK0sfn; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695483719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QvCbhRPZ/l0zi2A2tbQGAtOh73iXOwvjqhx56r8fjaI=; b=e0g8K4O6WCJZbSgkS+jv7GwJvapCN1w/APhL+PWpe4pe4Mp56Li/XmiCOvJm5jjAK6Y/bk NzxubgD+xEnZ2UN99bAFgHvstyCHUFYaAOadJsbB5SRa2Ox0sfbPQti9USHhYOY1lYVv3l 5EkK2Gd0cMLgM+qwiMRhjwq1zPhh5gE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bKxK0sfn; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695483719; a=rsa-sha256; cv=none; b=jjfXH0fcvNqsTNjKs8EP2y4pXu6R5eZvDUutsJmtLkn8eCGcZWhsRkqibMoD8UDZswdSej 6NPf/JhuFNf1ysgGJnO9PoMfroAsq+zzuT4ZusawI0RLZASLvY9UTs+p+7Wn1gl0XhmFQ/ hvLib9DDiW7LkYxvSATofnOrvhxUUM0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id AA562B8068F; Sat, 23 Sep 2023 15:41:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78B41C433C7; Sat, 23 Sep 2023 15:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695483716; bh=vXbqktT7b0Qri8xOnKmQsZG7jQ4zimMSvWYPtuArZ7U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bKxK0sfnvR6Mn54iFskJjz+iqQzT7d+5NzV6O/KDvtN3lXtUe/L3iPwKCcy9RJgP3 mbD8bMb58MYWC7Tl7U7Pm9c2CxFIZly2LFF5bwScXgaoAZuVMJ1eJZhU6ecWVwTfEE r2oNyeJK2AahVHVr99AtDOSv5pGe23KHFoafNeDpxxm0mmvwtmbI1d6kPT0nWu68z/ VE6hznLFs1/tWZv4nZKOvDCd21ai8PHSne6FmcZ1g1J53YE3NQHUgtGoEfJtdU67X3 wLZ8mTH2uPqXeKbDrNozy3tf88DdS8OExFmk2KljS0ivcPxrGjBb2Vj5e645SQEJ/u hwwLepGJAxXyg== Date: Sat, 23 Sep 2023 18:40:59 +0300 From: Mike Rapoport To: Song Liu Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 02/13] mm: introduce execmem_text_alloc() and execmem_free() Message-ID: <20230923154059.GJ3303@kernel.org> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: 5e8bwq6kbxa7f1u6o8ytt8yrcses61qb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3C0D940004 X-HE-Tag: 1695483718-951235 X-HE-Meta: U2FsdGVkX18cykOfFROS510e/j9Lb6WhYs//Krs5L5Cq5AnWUXJUAqX70adRYD7NFcqfQMnP3x23jmvWAox8q3QlEYWTMh1WIIvjoDVjKAlkeR4gyCEIkxm0/C4leMuUDST9G5xy6sCVU5EOJ4kR02ONw+jlMTlEauDuMPsDbkrB2W3XR75GRZP6SEJ0OkRZ+laT8lq5YCWFSP6GsPutYpXQW3rhMdrHrF5Uktned6TywqRtHPrnmPci37HdazuPRfaZOBSWUDmX9OrKKBeVZWWE83MA2y9mndK+YiRX4nQbkZuRH/xQTO0qa4Ohw4Vszx7viRuzIMBWX8pjKzQ+X/e3Kt2bNcElSEj2FHUlTMAzlte5OTbbVuftR/CPqaUBh1r783VZk0k7p8mUTKxvT6DOKXLdGE+tO5MorS45/hs6lmojRG6TSXasNEPdqo349yx9WxpkF/o1rm/3m4Ev7WTbywvlIKzM9cnq5aGLX5QJRRUWSto+ZHCCQShZQN1tWVkCMQJEZgNWZ3mY4usPo8Rh+yZEv53D77RhP3TcvkN/ZF5iGbmbAbO6eHTfiW3uqgdxZXNR62SY1MT2tyJUiENvNzDBkfupw8PZmKHzyezwk2OvKy+cGU1yoFjr5f+H797faPRqFTbKx8RKcPZvuioAoEtaPUUp27Cyz5it9eM8ZEYYFcU+Dod8sTX9bNP6T5Q8kpj9RXc9wfTo2FnIuXBo8b1RbbvYcfUZllxd58Bkf5o55u9G5eXt7aDOC3DM/mxPHmnf0LpH5uMWuz+3bVJQvsKdPQjTSD1gAxll+M9z18t8p8ssNG8nhXj8zOXpaHhUog5Jhe3rPzPpP7ThJPfXb1iNV603aO0rX6P47Eh3QoI4MW50qhLoFmjed0G5iW6/o4KeIBPRUBI1jsYsW5enI39jjHjSQu2Dvq01EVjyrY9323GBcokiQct6pFlvZZwWCpieTrqAdJvyNOh Jmj1lwb+ d4YZkIQ8hJ8+m0BYb9bhHnTv7jjev5e9jjxq58w6jMjSzAYD2FXUZoDSrq9Qc08pLJnVSbAqneOHwdLTJ5I6uSe/zVeVOa+pFn+QkONYuB1WPU3w0yYRGK8aShAHfC4IrHzdOZVA2kivqaTpnfP5kFSiV0XElV4eJwDhT1naVxgrd8XC3b4O4s1QwsABQoQicvCT84R0CXaLA0yy4xC4YOEEs5HuBJvzAb5v8yRtDY9nD1NCqt7cBXJrjCLT1Ml2HeXRMgH1G1CS4c1oKBZrza5kujkiJRETENyfLBp+FUjBDi3YoJ3GQWa8XPNnfXQYDmIcFUt91PT8mNbv45cbtBEibT+Y7/AcBXVNOc0yCa63xcgRItOlDmQFd9A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023 at 03:14:54PM -0700, Song Liu wrote: > On Mon, Sep 18, 2023 at 12:30 AM Mike Rapoport wrote: > > > [...] > > + > > +/** > > + * enum execmem_type - types of executable memory ranges > > + * > > + * There are several subsystems that allocate executable memory. > > + * Architectures define different restrictions on placement, > > + * permissions, alignment and other parameters for memory that can be used > > + * by these subsystems. > > + * Types in this enum identify subsystems that allocate executable memory > > + * and let architectures define parameters for ranges suitable for > > + * allocations by each subsystem. > > + * > > + * @EXECMEM_DEFAULT: default parameters that would be used for types that > > + * are not explcitly defined. > > + * @EXECMEM_MODULE_TEXT: parameters for module text sections > > + * @EXECMEM_KPROBES: parameters for kprobes > > + * @EXECMEM_FTRACE: parameters for ftrace > > + * @EXECMEM_BPF: parameters for BPF > > + * @EXECMEM_TYPE_MAX: > > + */ > > +enum execmem_type { > > + EXECMEM_DEFAULT, > > I found EXECMEM_DEFAULT more confusing than helpful. I hesitated a lot about that, but in the end decided to have EXECMEM_DEFAULT and alias EXECMEM_MODULE_TEXT to it because this is what we essentially have now for the most architectures. If you'll take a look at arch-specific patches, in many cases there is only EXECMEM_DEFAULT that an architecture defines and that default is used by all the subsystems. > Song > > > + EXECMEM_MODULE_TEXT = EXECMEM_DEFAULT, > > + EXECMEM_KPROBES, > > + EXECMEM_FTRACE, > > + EXECMEM_BPF, > > + EXECMEM_TYPE_MAX, > > +}; > > + > [...] -- Sincerely yours, Mike.