From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76DE8CE7A90 for ; Sat, 23 Sep 2023 16:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B98536B0277; Sat, 23 Sep 2023 12:26:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B48606B0279; Sat, 23 Sep 2023 12:26:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0F906B027A; Sat, 23 Sep 2023 12:26:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9160A6B0277 for ; Sat, 23 Sep 2023 12:26:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6A2A8A0375 for ; Sat, 23 Sep 2023 16:26:48 +0000 (UTC) X-FDA: 81268390896.03.27CBC00 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id A18DB100002 for ; Sat, 23 Sep 2023 16:26:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q1TXhCaO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695486406; a=rsa-sha256; cv=none; b=4RoimBU5zs9NU0rxqLoYPqo/847Oh5C5rYOfxorfPBojR61Vc8kRsf3w29jj6lXR7Z69nH YBtsXTpGHGhEm9IAfkRheeegeqSWVoqWgsqYnfyec3sz9M9duYsv3Rl+v7LsudrHRddzik v9ff+LBq5RS7o7Kaw9yM1anAoNYRdAI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q1TXhCaO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695486406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8oUCCfTnSUsP+XHZHorrbXh5EmIVs+NRFK1AJQaIa40=; b=uYeNENFR16asLmIhxFXFQDeVCEH1eRL5kH4BH2cq6BP5AcGsbSHC5U31Ig8Fs014hbdMR6 ZVOzIADoKkwCKG3Iwfm2xZ2+AqwJTcWfBBX6UgAVhegmMMpTEMSHy9neyYFAHNvkYi4lmN jCWxRCuyQOdpiNT1oE/sCLvyO+wPG5c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 345E5B8047E; Sat, 23 Sep 2023 16:26:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE71FC433C7; Sat, 23 Sep 2023 16:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695486404; bh=2piJOAc4UtCWCg8jsg4cD2ZIAtKbobPaZdza3lM1trU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q1TXhCaOUKwD4i9ywBsaA7fqhllTiUUEop2bqUBzfEeLiBK0GMJal6TZCH02gcByL 753jvJ06wYTsHa9bNjwSyI/D53kLiYdlB1AiITQEZl13j1+ufZspu8eHeVKiSfnDPa Xnzc94p2Es7bJABHatU5GnvCNtXzBwLW/ClIG+R90OCKZCTnz4sBwhPKehiv0ITJJM +UjHKGlf0w5d8TT9nGbQtF1BeBR/tDz6eSth+IHkKyRVTlF1gKubvNuOjqYZN8sC6v yInZcSWBoyftCQIH5y4EX0l+ogMUchapNByEIoCoBWaItl9SpqS6bxW8Fm8jrgT5Hv hjgDbZyqE8rAA== Date: Sat, 23 Sep 2023 19:25:47 +0300 From: Mike Rapoport To: Song Liu Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 09/13] powerpc: extend execmem_params for kprobes allocations Message-ID: <20230923162547.GN3303@kernel.org> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-10-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A18DB100002 X-Stat-Signature: eip6azdkfgsbmeb8osk17ue3od115tza X-HE-Tag: 1695486406-49347 X-HE-Meta: U2FsdGVkX18hC5GNH8qP63ENgkJv7zCC0HuWEybomHZiiuv4h1RMkJqKOWc55HJbdoQnJ0JIFOcIB3EVtuL+d7W4bv6+hNyEM9YADaA35kgSktT7tjg0u2cx32E6XqAyhJcyxPdF24Qi7tq98sOnoi+7yKhXBIEn1HWc8XU6wNde/YydlUtr4IUYGrHqO2635rUltt9iIKBYYEtxNdqB3oPgL+mq1oIUWeb/gzzuPJBFIhGjl0Q3ajkkEvm7TI9gtpKAB7wu4tAm7C5eihgA/X3Xotzbo/cna8+xu12Wu66swxniKdD9nak2gqRDsdqXvXuDQAUwiZjUQXAqIfJe8rXbjdkDP6xjwuYHT8rTt84bkIGSwM33B4soGUH1t/1Izj4Og7os9eTOtucnYNEl8zxRrigdE0XIJdbk6jYYDJaqBa7Y6o2kBesP8LPN7pJR5e/aF1TiXAyd3n63kFnRWNwzNPjcJRzYV+6OIsd1FG9JJNZv+EQXlUONZidp/GZ2yVDoB7paf4nsb8kumgKU01GeoxYJSyALOZEohjtXv/HP41VL/lIeI3rqMDsEEmU2xlhtrRMNZtaEc8NOaoNl32nmkQVqyQ5aMFQuINPOLV+sSjd0DIhiaTkZH1CdDmURh6fuBL1IP4hkC18Vhr4njMiSyknxtqTfvVZhL1o8/Cc/JNKsqTb86+YBS5XKycEMlITwAcvupfdZvk4qO9z9fjn+PseRkwvuTpEQG7jJ9T8CPfqV36nXZiy1sxfNIxuq8QGCKeBBcnyr91HpBSoPJde+c2dfZmQXi1OmUreb+53jeOv1LAkoyyfYrNCXDaKD6G4s3JrMROuA0WU1nFx1OefyR4zo6/4+dYgIcBrYbpQpLOv9T79za8O1c8Js0lKdSCuC8tjjIdPLReJrL800wa1Iwmd/59BF9PeKA68YaOxe5gpMtL3o9pCrdlbA76qP/xQLE5n8aOxxqQgl+5D sSAqhuFm FV9aad3aeGuClMDydgxNUPm+m8Du/5zEE6aGLNTmN/MAE1zR5dLB8zUWhm4XIBIBGVH9irAQXxS9zG4okV5VkWCsnda4Jk+CnsRyTZ/fwU9fp8MLXK27umrhW5yhQbxRwZYJGCBRH/wQwIjCkH9/r9yUhDO6p8+hude1YcHkZD5k7C/Acgr9X033yKZkWTpxHcRhwHXmVeCWwi7u497f9yGRfVT6WFanVQNC/7QEOMETHO2IieYHBrdyc+ssxzJq+2XEq8YARVorXNgSc8ULgZ+PnFNzSztf6W/yLEGd1O2yXDVQg/MGrIZSZef6hMguVF0uIZYXc9Sp+62gNxE2va81+p4IKFPy1NQ4dl5Q66t+nWhbs1SMb00IGkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023 at 03:30:46PM -0700, Song Liu wrote: > On Mon, Sep 18, 2023 at 12:31 AM Mike Rapoport wrote: > > > [...] > > @@ -135,5 +138,13 @@ struct execmem_params __init *execmem_arch_params(void) > > > > range->pgprot = prot; > > > > + execmem_params.ranges[EXECMEM_KPROBES].start = VMALLOC_START; > > + execmem_params.ranges[EXECMEM_KPROBES].start = VMALLOC_END; > > .end = VMALLOC_END. Thanks, this should have been execmem_params.ranges[EXECMEM_KPROBES].start = range->start; execmem_params.ranges[EXECMEM_KPROBES].end = range->end; where range points to the same range as EXECMEM_MODULE_TEXT. > Thanks, > Song > > > + > > + if (strict_module_rwx_enabled()) > > + execmem_params.ranges[EXECMEM_KPROBES].pgprot = PAGE_KERNEL_ROX; > > + else > > + execmem_params.ranges[EXECMEM_KPROBES].pgprot = PAGE_KERNEL_EXEC; > > + > > return &execmem_params; > > } > > -- > > 2.39.2 > > > > -- Sincerely yours, Mike.