From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06386E728D5 for ; Fri, 29 Sep 2023 17:58:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84DE48D00C9; Fri, 29 Sep 2023 13:58:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D6CF8D002B; Fri, 29 Sep 2023 13:58:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6512D8D00C9; Fri, 29 Sep 2023 13:58:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4EF418D002B for ; Fri, 29 Sep 2023 13:58:14 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 265A680FF8 for ; Fri, 29 Sep 2023 17:58:14 +0000 (UTC) X-FDA: 81290394108.29.9BC5658 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 3CEA88001F for ; Fri, 29 Sep 2023 17:58:11 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XnoqVixZ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf30.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696010291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aC5cjqNqRJMxYKokdjVvuutOF44kRshAAYS87I+O62E=; b=Z4/l0kHXrvvd1/3rGXL0yYI2gjZS7urmPD/IlahBpze9dBRpuVn/Nr2moTtz7vb3M7YAW8 eCR84WrrPg01tkHQozxSX30E6OapEYT7SeM7ecxE5Th3p0fUTZkXdnjumGYdmJdAa5c+G4 NK3JXCxfuyN38HNCtel6OmYOUmIc5Ho= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XnoqVixZ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf30.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.172 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696010291; a=rsa-sha256; cv=none; b=QTPRrRaY8nQP3YglVHerUznA8XHdq1dCrBeraRy2AlOIl0u6Hi7oZ4nrki2DPNyhvOqKIf 86GmTU2Ys/5TM51hTQY+NJg1etF02s4G4tPUqJ+0UJmnfrs3sSqcYKHI02AMsIpSx9n8su TU0EYTr7czSE+7z4aZ2UFKdNXgKPrTY= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1c60f1a2652so7434445ad.0 for ; Fri, 29 Sep 2023 10:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696010290; x=1696615090; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=aC5cjqNqRJMxYKokdjVvuutOF44kRshAAYS87I+O62E=; b=XnoqVixZV3+cughrR0tSJUSgmZXY2sYq4kPI/7aaYwUPaCPknFZLF0vWxZMDcV8jDt bjZoWOr8oAkAv2gF+l3unv92W0Pv+kFHENetIenLkhLBYdVBPawRRNYmeCm14ifgd+WZ QeCLT6vYHPzCrJp91zAqMfZ8UURqRXyShm0UI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696010290; x=1696615090; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aC5cjqNqRJMxYKokdjVvuutOF44kRshAAYS87I+O62E=; b=R9IBucK61UqrgC+uX/8/kZyT+m2wdiQiPvQ9iy+2ftBaA+k2Eqc0WBzgzqSCEF7+gJ 5B68li19OsPIFlIWerVfG3u39XmPMl4ggs59HKk86yvm5M1S6H/L+mAWPkmpSKHclNK7 QVtqfwS8qlpIF5CLeNlSppYAme+1nkVdUWdCnctm3cJc3d1Y2hM58FWO5g1i8qVbP305 Cscg0UQQILJkXWT7K+2vEpL5NX5imjPVOwifGiy3xlcioZ9ci1jQ1jzBsnGEARc8NiAF Q71JSp1psbET5O43tE2/fXDHlzItRnrIz7Xrs7/SEKiaRSbn+tzfja/6Mdegm9tu+s5F LniA== X-Gm-Message-State: AOJu0YwFc65yRBi+pO/UJKbk6UjXN/fKtZ0BQXQ4tXlXzgIUJ6dxiYIk Uo0+AHa8dKpfjbPnl7mKYl4ufA== X-Google-Smtp-Source: AGHT+IHTIjg4MTnthyGSXNTf2walb3iE8iYvnRDi6RgHJI+jmXwtGUsNBG2O4G4ZKvRYL0FJ4zprVQ== X-Received: by 2002:a17:902:e5d1:b0:1c3:e5bf:a9fe with SMTP id u17-20020a170902e5d100b001c3e5bfa9femr8315131plf.30.1696010290068; Fri, 29 Sep 2023 10:58:10 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j24-20020a170902759800b001c5f0fe64c2sm1628550pll.56.2023.09.29.10.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 10:58:09 -0700 (PDT) Date: Fri, 29 Sep 2023 10:58:09 -0700 From: Kees Cook To: Greg Ungerer Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, palmer@rivosinc.com, ebiederm@xmission.com, brauner@kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] binfmt_elf_fdpic: clean up debug warnings Message-ID: <202309291057.6D4993BA@keescook> References: <20230927132933.3290734-1-gerg@kernel.org> <202309270858.680FCD9A85@keescook> <9e4cf2c9-a1a9-43a8-3f72-2824301bbc98@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9e4cf2c9-a1a9-43a8-3f72-2824301bbc98@kernel.org> X-Rspamd-Queue-Id: 3CEA88001F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: k9qdyzx7kctudubwhwoix6uzwactuj8z X-HE-Tag: 1696010291-323802 X-HE-Meta: U2FsdGVkX1+UEm/tYCBQb9KhWVxToNvxh0QZRTXWp+0EzLrvXTDM2qZkJmi1HBhYuQ/icPzN874Aw65EffJBF3UnVX04xtOJf7ZSld3fLmqobjGMIXBbSzD2zUNmv5vYeKp6tXc0VicEtqyHfHMVqd8sID3dJEIRreVLH1igv94O8g2QyVL/kKmXbNld5vtVeZnJdRxLWjNob/qk1krOrOZyTN01UlLim4zWzvrJgul4DNX0zI8FdEY2wqOnwZi/PGfO6E79T7k4ir+H2Ma6NKMVAzpbOMsBGMK5LteJxVzoE+FHxW3SyoXlx1grti96Zvyf21n6oUoPlczVQzagvgLzTVct/GBsCDYjznmy5JxPUsZkbF/WuFVrsZRWunXhtqrCa6k8esS/xWExuun929URr3D/D2eg3VWmdEYB+djJYLsazggxTNgwlGbWe8VRF+13SrymBtU3rbe2nYAk3yGAHVUdfw7ZQPnpjBFYYkiQw+fVD6597KVoR/N39l2fHoZD5fJN/X8UYRHTvf00dDgX6MqCqwWkww2+dpk0eXbRnKFz+WcpV5yUhF7SoT3i12NLHiiLooY8q9jfOMRfZHBfa1NTESV4yOWbO6gpGw/obOQvtWjxj2i0Q55pTM0z7aqEU9fuBaOfauNYRrhXopVRhQCG79kVzifjhsMNSFIkRLc/Jiud/V5MTt1OZE3eYwIw6S4gl/S2vMqWpcOdGYrWnGfebjziAJp7dxpJT+aKaYjlbdirUIRzI/BnYVo+ym0d2FW2v/l/d4MYP4lMg0hCE8x46LZzYC+f0K4zjNBTocKLdgxzyeOFQXs1Kz4XO+LGRDMrkA3+GvSyCHcASH8tKrGsgy6Qk9+kQvGgcwbLfK5VMJGSyj6uDN/J0BSr6LcKjks/TMPepKNlK/YtzD4FODN9FlwcxA3IYR07fg+FXQlHMz1cKNSuSqrA+CeekpFQ0FfLn0JhHmqTSTM VoDuCyOJ Io49Be4B5s93wNUvPJ191eGbi1DstK4IVD4Hqhik37eSNAs+jy4IqlLtth0IEhgUaqNC77j5Mxn5ofpUUqqNGIFU7oQFjJ2lH9RMjGtZ5Q2JGEESmvSdbtBcqIhHjUP+WfGv43v1hcEYcwuxQJPOdNiBIH9AemogF6+gVVsWG04lJSmO3UG2eDEgKYKSt/edr/yJzw/TYEDLBVlg5bpyOj263DbL6iDPaZcT9mB8RGu5Z39mcwvvQLcb/en1cLVt9iXjmm8Y8JY6MXOVThzgoB4uA3iRePeqRTG5MZBKnZDiYi4iglT56rWqymS2CQEOB1IP/LEa6Dki17VSWHhbHfTyoMYXvxCm4aFwjxnUzOnVwtXitCMtD0bl9GnV3x9/7UINfE2rZPl27KFAHz+HTLm4T/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 28, 2023 at 02:53:09PM +1000, Greg Ungerer wrote: > Hi Kees, > > On 28/9/23 01:59, Kees Cook wrote: > > On Wed, Sep 27, 2023 at 11:29:33PM +1000, Greg Ungerer wrote: > > > The binfmt_elf_fdpic loader has some debug trace that can be enabled at > > > build time. The recent 64-bit additions cause some warnings if that > > > debug is enabled, such as: > > > > > > fs/binfmt_elf_fdpic.c: In function ‘elf_fdpic_map_file’: > > > fs/binfmt_elf_fdpic.c:46:33: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘Elf64_Addr’ {aka ‘long long unsigned int’} [-Wformat=] > > > 46 | #define kdebug(fmt, ...) printk("FDPIC "fmt"\n" ,##__VA_ARGS__ ) > > > | ^~~~~~~~ > > > ./include/linux/printk.h:427:25: note: in definition of macro ‘printk_index_wrap’ > > > 427 | _p_func(_fmt, ##__VA_ARGS__); \ > > > | ^~~~ > > > > > > Cast values to the largest possible type (which is equivilent to unsigned > > > long long in this case) and use appropriate format specifiers to match. > > > > It seems like these should all just be "unsigned long", yes? > > Some of them yes, but not all. > For example trying to use unsigned long in the last chunk of this patch: > > fs/binfmt_elf_fdpic.c: In function ‘elf_fdpic_map_file_by_direct_mmap’: > fs/binfmt_elf_fdpic.c:46:33: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘long long unsigned int’ [-Wformat=] Oh, something is actually using "long long" already. :P Gotcha. Thanks! -Kees -- Kees Cook