From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A15E81815 for ; Fri, 29 Sep 2023 21:55:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DAFA8D0103; Fri, 29 Sep 2023 17:55:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 863248D00ED; Fri, 29 Sep 2023 17:55:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DD448D0103; Fri, 29 Sep 2023 17:55:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 574F58D00ED for ; Fri, 29 Sep 2023 17:55:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2EC0FB3797 for ; Fri, 29 Sep 2023 21:55:05 +0000 (UTC) X-FDA: 81290990970.02.D1E174B Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf24.hostedemail.com (Postfix) with ESMTP id 5561D18000E for ; Fri, 29 Sep 2023 21:55:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=P6QnFkjS; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696024503; a=rsa-sha256; cv=none; b=2XsW2ldTH7gIUFfqnkyeNf1qqbtaTSDAUAhe/icwYTvb7gDJo/X2ZCH36bXp4KlqTlEPzN Tgj+TalgpMoYK+sgvf98eGnCMrIja2Aj96SHVIejKaJrKp+HYDL4re0k024DRsEILUW6x9 mQfMSiEJwqpuBC3DSjjIQabuk8zxmlg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=P6QnFkjS; spf=pass (imf24.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696024503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8kFisjx+D089Bl0n+c9sa0dcFrh55Nv3CjkrAPKvHaQ=; b=jV3nBTfVgHy/hWhcvqj/iVAOFSOmEuyxxQnVI1uQ4RROCRdj7k7g5ZFnm4kqK3cCJKWD55 +pyts03jcOMbVHMLoWl6JOQQ+nHVRuKZL+994Zfxl7g2xksauiA6c7iwhYfq6AOQoD2Vo0 vozP9tcTNGhmGxwO5wLEFevfdjJiutA= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1c5ff5f858dso85968165ad.2 for ; Fri, 29 Sep 2023 14:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696024502; x=1696629302; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8kFisjx+D089Bl0n+c9sa0dcFrh55Nv3CjkrAPKvHaQ=; b=P6QnFkjSckRACWk5Lfpt4u9UAHQVVu59Jf+PztJQIVxulaLX25x2aayGEMZONEj8yz YPo60kQCzfQF4R/QBqsLAGeDWMhUXgV3ZxxCb2XdhHCEvzfaMY6ySyk/6o5+YJOEkHM5 54SDiMr3fs7oztM6AcmjE2yRXYAziPdzUzVwc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696024502; x=1696629302; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8kFisjx+D089Bl0n+c9sa0dcFrh55Nv3CjkrAPKvHaQ=; b=iTkqp3fwV+k/YbPKzzvFjfqKma5XNNR8EasDjXTlxjwlgxL865tbL/FsaVchQuof8N glulfiypicGrIn9Nn3yofyKxP4YCC/qBIX6XMCxXSC1jAGkZ6wcJRPAd+kxAfHk1vNGB MZVrDxas64QpRECkaCID/0wTahS73s8I6b5AKTEKg1dazTMSd/+GQYcMeyQYz0S4a64k ctErChabW/VAJmUWESqg2rRT3l1VUilNJPUBl84UMn4DNDh9R4EdCq6bzul+Wj9293qN QgAnXG2fT8napcHpYKc4tkNxA/JdyBz4U+Y1/PqJjuux7qfIPE0Mnbac7JD23Ca25sSG 9xdw== X-Gm-Message-State: AOJu0YxADHF8HaJplcknRUqVCjl42ofqWu4Df29nAXL+M6S+GDTfEqs1 vFzMyoXQ2QXJIN/skAV4wP2snQ== X-Google-Smtp-Source: AGHT+IGnbAGwryCCvO6jabCBmevCmJ/0eVxJN4Y82GDsZjB3QfXDLV1KZNYrwCXcUGHGoTsq/uDbWQ== X-Received: by 2002:a17:902:ecd0:b0:1c0:c86a:5425 with SMTP id a16-20020a170902ecd000b001c0c86a5425mr6564288plh.19.1696024501806; Fri, 29 Sep 2023 14:55:01 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id l13-20020a170902f68d00b001b54d064a4bsm17338377plg.259.2023.09.29.14.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Sep 2023 14:55:01 -0700 (PDT) Date: Fri, 29 Sep 2023 14:55:00 -0700 From: Kees Cook To: Sami Tolvanen Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , linux-mm@kvack.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: Change mmap_rnd_bits_max to __ro_after_init Message-ID: <202309291454.436E19663@keescook> References: <20230929211155.3910949-4-samitolvanen@google.com> <20230929211155.3910949-5-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929211155.3910949-5-samitolvanen@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5561D18000E X-Stat-Signature: i6x79mopibkwsp78pxkqyh46yirgx3fn X-Rspam-User: X-HE-Tag: 1696024503-90638 X-HE-Meta: U2FsdGVkX19bQALU1la0ji1/fyFCBRuMa6EqPMek/umDk3FZrJ3h8CkkHSl6a/6iTSqjHOxcvWS+5XJABUWXMc9vmobYhwWMOONSkhFqfM4N3RFrIWKmZuogkGN1laZyPgf+ObYtGtoTjmN/kU5zMCGQNxzId/szEcO6dCcap7KGzAqoyzUHIZ3z8T5z9BhxJsc+Jy+0//B7Va9gSwlHrKNtpW71QNVPFzvc21TRBDWoNbQ4WXvII3bhmskN6Fc2yOkbU9xcZmX26n9+AUCmKmB0pKD2fVQpyM2DJ0iYIi7PfFGmDZwJZsmYZLlUKFITlZfq0wUvRy1Up10g+folc2yGYuH2Ls62zX/pXNY0PDS4oqXRep6Txppru2hTRyi+v5Tt3ekjEVgFrmB/g1qQdULUZ5s/OcuN/NMwIbU+qJzQOB5V2RfjG3yA7auj6j/D3xrmxQb6FNQPDEZNLKe9Flflw+cLJdVjmQ/3y4KK62sEAewP5zQktcmBLo5qZFAE7VcQrJ2VH70BtGbvfi5qXeeU8Fj+eI3MfR3E+ekV754if7/MC/2hD7vHPo2Afekptixi5xa3n4W/XtLhol89MGEza5I93YULRjxqu6+SODpvTW2EiKOSzIP1ntTD4xZl6AieuFUxKjYtBarEbkhklPMI/2J+D+LJLRScokWgNYM7OlFYKyJkew6M700wpkke2lTLyGPLGJc8myf9QWIbmhqNhmbcDboUDanS0LV/C6kSCNXImGRlGDv0Wp4yXTy1Qst8cW2HpXVpGbNW094bKTV64g3fY8Eo8AEv0H4UA4njCk4cg3MnMMZ4ZpKLeXW4WTNetYx5E83tgXkAuZCJXnRkd269tNomYwPth+czW+EBrzKIUkvxzb1RRY5sz8I+q+ozZ7P7DbQqX8yjL9tUfx+oiaLkhF9/BlgltmUb/XlUvRETECe8SJblSxtBnHooJQQwwefwHrs/MyszclD //+HsBvl 1Dv53r3+YiRG5yprGcyhsOj/gRtZ+WnxknjbwyngGJuPLcLugMNpluJFvktQuKY1jk2VKcI6mWSwUuvpGOiHv14Jz0H95ssZ7UTN+Mv5i+coZwblQTpyk76gWvRtYEkPI15tdLHJ+50S6Z8dwnKcUpT2CdmgNpqcdmunp9mM/uPQATSwtFZ1r/yEsaIquYuGM41BfxKX3gdpt5pwaANqUS8N2PF3LxtY7wCovwMttwv4gMoc3XtzTZv0YNyJU6hpGQBvMw/Z9mQQvRjykDZ5zJB9Qhym6c12TRHZxq72wvIMS1+hTcQ31hEhyioI1d5Ez9DWWCMfiLB+L8XjwpbqvYTt1atc7Ctr5Q21znis8V+eUxl5aRLMqJ+ZqZOdpw4A1q8ZcAILAb4N6RGBnv3guLWKhKqG6NdFHLt9wc208FrAoPBKBKTgJBIymKn663uiIKDs3ZO9XdkuAIGBuS4NV6jmbXc1hRGTfznTq X-Bogosity: Ham, tests=bogofilter, spamicity=0.010325, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 29, 2023 at 09:11:57PM +0000, Sami Tolvanen wrote: > Allow mmap_rnd_bits_max to be updated on architectures that > determine virtual address space size at runtime instead of relying > on Kconfig options by changing it from const to __ro_after_init. > > Signed-off-by: Sami Tolvanen Just the kind of thing __ro_after_init was made for. :) Reviewed-by: Kees Cook -- Kees Cook