From: Mike Rapoport <rppt@kernel.org>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"deller@gmx.de" <deller@gmx.de>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"bjorn@kernel.org" <bjorn@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"nadav.amit@gmail.com" <nadav.amit@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"hca@linux.ibm.com" <hca@linux.ibm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"kent.overstreet@linux.dev" <kent.overstreet@linux.dev>,
"puranjay12@gmail.com" <puranjay12@gmail.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"chenhuacai@kernel.org" <chenhuacai@kernel.org>,
"tsbogend@alpha.franken.de" <tsbogend@alpha.franken.de>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"linux-parisc@vger.kernel.org" <linux-parisc@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"will@kernel.org" <will@kernel.org>,
"dinguyen@kernel.org" <dinguyen@kernel.org>,
"naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"song@kernel.org" <song@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 03/13] mm/execmem, arch: convert simple overrides of module_alloc to execmem
Date: Thu, 5 Oct 2023 08:26:22 +0300 [thread overview]
Message-ID: <20231005052622.GD3303@kernel.org> (raw)
In-Reply-To: <00277a3acb36d2309156264c7e8484071bc91614.camel@intel.com>
On Wed, Oct 04, 2023 at 03:39:26PM +0000, Edgecombe, Rick P wrote:
> On Tue, 2023-10-03 at 17:29 -0700, Rick Edgecombe wrote:
> > It seems a bit weird to copy all of this. Is it trying to be faster
> > or
> > something?
> >
> > Couldn't it just check r->start in execmem_text/data_alloc() path and
> > switch to EXECMEM_DEFAULT if needed then? The execmem_range_is_data()
> > part that comes later could be added to the logic there too. So this
> > seems like unnecessary complexity to me or I don't see the reason.
>
> I guess this is a bad idea because if you have the full size array
> sitting around anyway you might as well use it and reduce the
> exec_mem_alloc() logic.
That's was the idea, indeed. :)
> Just looking at it from the x86 side (and
> similar) though, where there is actually only one execmem_range and it
> building this whole array with identical data and it seems weird.
Right, most architectures have only one range, but to support all variants
that we have, execmem has to maintain the whole array.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2023-10-05 5:27 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 7:29 [PATCH v3 00/13] mm: jit/text allocator Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 01/13] nios2: define virtual address space for modules Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 02/13] mm: introduce execmem_text_alloc() and execmem_free() Mike Rapoport
2023-09-21 22:10 ` Song Liu
2023-09-23 15:42 ` Mike Rapoport
2023-09-21 22:14 ` Song Liu
2023-09-23 15:40 ` Mike Rapoport
2023-09-21 22:34 ` Song Liu
2023-09-23 15:38 ` Mike Rapoport
2023-09-23 22:36 ` Song Liu
2023-09-26 8:04 ` Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 03/13] mm/execmem, arch: convert simple overrides of module_alloc to execmem Mike Rapoport
2023-10-04 0:29 ` Edgecombe, Rick P
2023-10-04 15:39 ` Edgecombe, Rick P
2023-10-05 5:26 ` Mike Rapoport [this message]
2023-10-05 18:09 ` Edgecombe, Rick P
2023-10-26 8:40 ` Mike Rapoport
2023-10-05 18:11 ` Edgecombe, Rick P
2023-09-18 7:29 ` [PATCH v3 04/13] mm/execmem, arch: convert remaining " Mike Rapoport
2023-10-04 0:29 ` Edgecombe, Rick P
2023-10-05 5:28 ` Mike Rapoport
2023-10-23 17:14 ` Will Deacon
2023-10-26 8:58 ` Mike Rapoport
2023-10-26 10:24 ` Will Deacon
2023-10-30 7:00 ` Mike Rapoport
2023-11-07 10:44 ` Will Deacon
2023-09-18 7:29 ` [PATCH v3 05/13] modules, execmem: drop module_alloc Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 06/13] mm/execmem: introduce execmem_data_alloc() Mike Rapoport
2023-09-21 22:52 ` Song Liu
2023-09-22 7:16 ` Christophe Leroy
2023-09-22 8:55 ` Song Liu
2023-09-22 10:13 ` Christophe Leroy
2023-09-23 16:20 ` Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 07/13] arm64, execmem: extend execmem_params for generated code allocations Mike Rapoport
2023-10-23 17:21 ` Will Deacon
2023-09-18 7:29 ` [PATCH v3 08/13] riscv: " Mike Rapoport
2023-09-22 10:37 ` Alexandre Ghiti
2023-09-23 16:23 ` Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 09/13] powerpc: extend execmem_params for kprobes allocations Mike Rapoport
2023-09-21 22:30 ` Song Liu
2023-09-23 16:25 ` Mike Rapoport
2023-09-22 10:32 ` Christophe Leroy
2023-09-23 16:27 ` Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 10/13] arch: make execmem setup available regardless of CONFIG_MODULES Mike Rapoport
2023-09-26 7:33 ` Arnd Bergmann
2023-09-26 8:32 ` Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 11/13] x86/ftrace: enable dynamic ftrace without CONFIG_MODULES Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 12/13] kprobes: remove dependency on CONFIG_MODULES Mike Rapoport
2023-09-18 7:29 ` [PATCH v3 13/13] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005052622.GD3303@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=hca@linux.ibm.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nadav.amit@gmail.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=puranjay12@gmail.com \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).