From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA813CDB484 for ; Tue, 17 Oct 2023 06:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2120880008; Tue, 17 Oct 2023 02:12:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C24380007; Tue, 17 Oct 2023 02:12:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 089E180008; Tue, 17 Oct 2023 02:12:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EA34D80007 for ; Tue, 17 Oct 2023 02:12:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B8CA140EB7 for ; Tue, 17 Oct 2023 06:12:27 +0000 (UTC) X-FDA: 81353933934.07.0D1D185 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 18BC7C0012 for ; Tue, 17 Oct 2023 06:12:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ubNVksdD; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697523146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I3KsIjtBlSXw75NBOjob9Li+AiNu+WGFKi7J5hgkT1Q=; b=4AJEECz2RnbKpCiyTpG+1yMw2QGQpsMwfYgujPzzxfGtbMPJqHziGShz4rgvV8QWNaDmX7 7IEbK3FOnxQXSQGO8VruOeCN0RQUX1QJhVm6RUQH0tFBpTQYFTLIEEPdxWIU9RO8UN2Yg+ rHVKBsVATRMjUt+VUW1uepi+Ky+0swg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697523146; a=rsa-sha256; cv=none; b=7UxgeufPNQUeiwrZTZwK8/l+3LvCR4g3qnXgy/Pal9NcJoGydqw8PaJqeceP9HJEFp9v9t ohbpYwJuoMTLS7oZZuAWwVtMzciSMFZ5nmTZ9r3XBFAzEmhqx1yM6EmYY0+Sp3MrF187/R BvpICWAxhYS39WXQqFCPrYNdqiN7I8I= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ubNVksdD; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1202B612A5; Tue, 17 Oct 2023 06:12:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E60F4C433C9; Tue, 17 Oct 2023 06:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697523144; bh=WZL7RMv9Zq/flTstARyomtZeBjuP+jl2Fbh947mNZjg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ubNVksdDjR5U3wRRg8jlP3jRY5F+VUPiIcGj/yOxk94jF9xgeqvFFQyW3zvfLXuAa aRMuD2bNnylMN8NGUI6n/Xoq3N3aw5sQarV/zxO5FvmtRDqHXyfMlceBF+85NFoHDJ ToellsOzqWjn7M8SzB3hEr6EgBR9pO2MK+JR+N5tq/bBvCjHRoyupp1fPxmKsRlkD6 YaKN/igqRKWuSuTkPE8CH6iet0DIosIcwR4Bm1d6M5i4TRmH4LbeshglfGnnra/OK7 fWKlyqxFmz/rbfCr3ZzJHXZKeA1lGJMyNd4iFaS8ll5YOovN07Wb1pn2AmY4wpUvWJ xALE0IYqDaiaw== Date: Tue, 17 Oct 2023 09:12:10 +0300 From: Mike Rapoport To: Qi Zheng Cc: Michal Hocko , David Hildenbrand , Qi Zheng , Vlastimil Babka , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Teng Hu , Matthew Wilcox , Mel Gorman , Oscar Salvador , Muchun Song , x86@kernel.org Subject: Re: [PATCH] mm: page_alloc: don't allocate page from memoryless nodes Message-ID: <20231017061210.GW3303@kernel.org> References: <67240e55-af49-f20a-2b4b-b7d574cd910d@gmail.com> <22f0e262-982e-ea80-e52a-a3c924b31d58@redhat.com> <4386151c-0328-d207-9a71-933ef61817f9@redhat.com> <8f506561-44f7-a243-f0cc-59543f487e4d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f506561-44f7-a243-f0cc-59543f487e4d@gmail.com> X-Rspamd-Queue-Id: 18BC7C0012 X-Rspam-User: X-Stat-Signature: 9siupx74snnd7kn7yroia5t6u1nyfu74 X-Rspamd-Server: rspam03 X-HE-Tag: 1697523145-891737 X-HE-Meta: U2FsdGVkX19JFU9HzRxx0ttglchzt8ptzru3yT1K9uAcs0RmABS/U2ps9VenraXP/G4pZzYMgQlqSieUgw8VNKtTAx1lgmINoAx/7RZuqFfXm0m9jGZ6KXpp7Xb8tV0IJbqgAw6z6cuRObAOzMCl6HGq88Gm25TpExO9aXhRI62oNJGScm5Ij7y62fht+Gq1/7ZtTuM22TXzJbgxRbmYw3yILaWo8GdLU2Qd/pwaI3Fp0GlDZrUQMBdBSh3smQ18N8nB9dTJUaDDBeRZ5ZKySi3NJhE06Nx3p1I05ryUG2eprBeNH6gJchi1HI4c+yIKxyQ5NcPQ1FMEOX7rn1lgB8wRJLYi7BkBRY1VhQAhP2w4490ddVzKZU9r/TMOCaJQeCOFXjTeXk44D6cwx+Nj/N99w5ouFYwhW2LryAuYtWb2smZanWtffENRx+acDT8lWQdA/xTPzw3pepW2Bkh6KR6GZB/weycDEqiXMEf6UxI5+MewT7XrJ1KaYmycDKaRI7MpZ3/WIb5QaLfBblbSE7ys2dru8lFjsfQN3z7IRDVk4s2wQ1MCMFJMeZHUkOyoi396kIbauKAI9+XiZ+Hrs9glkO8F9wUbkAml3dbjvHAMtes84+gsn/1HQoTYmMZVHambFuN9b7HNn+fqUps51yq+km95JSHOKt2Ntz2ZdtmCL4XPKQOMkuFLRVrhfffdxGluEarC08mJzVnGfwdAxfYBe1dKM2SLtmykVjJSX97VpP46174byhYNSe6wE2j6fEu71CQ6A4RrSIL56jE+neyMlFAqIHmV33tgJNdisflDyEoo+9zZiALuLFQFd5DxA3NrJlp9zkr6sGrn+ZbCoVlexwmtUm+83ndQJFnHihUDxgBDbNR4BtOGfMWX77Fw5j76tgcDqXry1SnhBn07HBen+KwwPL8/lY1xVvwkXnVeBrQ9nIKwN/2MxEE3Z3/+BohlkOUAKnGTl4py4x0 IzFOxzI3 yny/qm5cspWNY81vF0mXBmTK5UBRDNZVZPQxwrsx5AU7mlZyX/Zy+vmdLnQpsyLYnBQnYAAFpILDkKSkvGBr++CCIs250vEMrPQyi6hB6UiGbHinqGPQ5dkZ11bcrKZuEhEdxHywPOMc4Y73SAyjqPAgngzZnFjqswO1W1ngoxWx7DaQTnVvxtZgApOI65SoRJ4N0FeVL0jeaRJrGkO46AFyvUMWIIsg+vMApptuROB8i8Y+NNd2nvz533Npfrn/NiF3p+BaxXNH0NdyPQeLzKdckegvgaQWKge675q+iPc4s8xv/Hy+S9bQFjpj1IaR8FzDLdD+JNXocqApsqmX61Q65VVtCFyd5bB8AMfaU+BnxFBAFbGAciDuSzTz0Yx6nZ7l3BSmYEJE9oRi5vbp2Em4puVUFBd0CfTyA5sxMrFVUBg0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 16, 2023 at 12:09:42PM +0800, Qi Zheng wrote: > Hi Mike, > > On 2023/2/15 17:30, Mike Rapoport wrote: > [...] > > > > How about we try this: > > > > From b670120bcacd3fe34a40d7179c70ca2ab69279e0 Mon Sep 17 00:00:00 2001 > > From: "Mike Rapoport (IBM)" > > Date: Wed, 15 Feb 2023 11:12:18 +0200 > > Subject: [PATCH] x86/mm: drop 4MB restriction on minimal NUMA node size > > > > Qi Zheng reports crashes in a production environment and provides a > > simplified example as a reproducer: > > > > For example, if we use qemu to start a two NUMA node kernel, > > one of the nodes has 2M memory (less than NODE_MIN_SIZE), > > and the other node has 2G, then we will encounter the > > following panic: > > > > [ 0.149844] BUG: kernel NULL pointer dereference, address: 0000000000000000 > > [ 0.150783] #PF: supervisor write access in kernel mode > > [ 0.151488] #PF: error_code(0x0002) - not-present page > > <...> > > [ 0.156056] RIP: 0010:_raw_spin_lock_irqsave+0x22/0x40 > > <...> > > [ 0.169781] Call Trace: > > [ 0.170159] > > [ 0.170448] deactivate_slab+0x187/0x3c0 > > [ 0.171031] ? bootstrap+0x1b/0x10e > > [ 0.171559] ? preempt_count_sub+0x9/0xa0 > > [ 0.172145] ? kmem_cache_alloc+0x12c/0x440 > > [ 0.172735] ? bootstrap+0x1b/0x10e > > [ 0.173236] bootstrap+0x6b/0x10e > > [ 0.173720] kmem_cache_init+0x10a/0x188 > > [ 0.174240] start_kernel+0x415/0x6ac > > [ 0.174738] secondary_startup_64_no_verify+0xe0/0xeb > > [ 0.175417] > > [ 0.175713] Modules linked in: > > [ 0.176117] CR2: 0000000000000000 > > > > The crashes happen because of inconsistency between nodemask that has > > nodes with less than 4MB as memoryless and the actual memory fed into > > core mm. > > > > The commit 9391a3f9c7f1 ("[PATCH] x86_64: Clear more state when ignoring > > empty node in SRAT parsing") that introduced minimal size of a NUMA node > > does not explain why a node size cannot be less than 4MB and what boot > > failures this restriction might fix. > > > > Since then a lot has changed and core mm won't confuse badly about small > > node sizes. > > > > Drop the limitation for the minimal node size. > > > > Link: https://lore.kernel.org/all/20230212110305.93670-1-zhengqi.arch@bytedance.com/ > > Signed-off-by: Mike Rapoport (IBM) > > --- > > arch/x86/include/asm/numa.h | 7 ------- > > arch/x86/mm/numa.c | 7 ------- > > 2 files changed, 14 deletions(-) > > What's the current progress on this patch? This patch doesn't seem to be > merged into any trees. Did I miss something? Looks like it fell between the cracks. I'll resend. > Thanks, > Qi > -- Sincerely yours, Mike.