From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4524C001DF for ; Fri, 20 Oct 2023 16:34:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7763F8D01A4; Fri, 20 Oct 2023 12:34:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 725F98D0003; Fri, 20 Oct 2023 12:34:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 614F88D01A4; Fri, 20 Oct 2023 12:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4FDB88D0003 for ; Fri, 20 Oct 2023 12:34:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E0A7FB4A29 for ; Fri, 20 Oct 2023 16:34:16 +0000 (UTC) X-FDA: 81366387312.19.A86B902 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf01.hostedemail.com (Postfix) with ESMTP id B6E8840005 for ; Fri, 20 Oct 2023 16:34:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zPs2WckD; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697819654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pxRrGsTnk7bAUtTGNuc+bb98U53XtWB6SZm2H7CZEtM=; b=rb3fuw7zYGHB2hDCLI0g93uSagWm1ykgJmIZYZTGOCMfcvFO3MlZntU+kVChyr6DRejx1B MFgtEti+YtHd4EzwPDBj6UkPV9OTRrgE5bTn2s9Hmyd601QZyXJr/f7+ljDfc7CtH2Jr3t UEi6v2Mw1uIVkAC+gng/aEj1ztM2Eiw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zPs2WckD; dmarc=none; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697819654; a=rsa-sha256; cv=none; b=DSRVwE8zXK+oFQJKH+7RitAOn8X+qdz3NjeHEAgGV1VZXBX89lCOLxicyGkxh75Dk5dnvD qsQgIIhcVcCk6pCvs0ym+d2l4mQoRqDxrmJJXnPadZIPyT4VhL6fYaZ0Q52a2avar7nQ0O JiXEISEuk7XbWCQW+XQDenp2FxBc1Tc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7B022CE39FD; Fri, 20 Oct 2023 16:34:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75C26C433C7; Fri, 20 Oct 2023 16:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697819648; bh=dKYd/12MjaWQfmGSj1V3kcKO/BZ3aLW0Ffk7QfWNPBg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zPs2WckD1f1dvmFYwwvemYD6GDE5M8HkbjSPYVlx/K4R0WRe0vBlqvn4prb+p3SCR qmT70LEpvgWad7VaRpyqoULmHnnxk4/m0Ok1UYAtXO/RgGk9kIXNWdLhOx3pFEDxIZ 3kIjPeMBxpcguF9j9ZCr/5f8vynAFi2Edos8Xqwo= Date: Fri, 20 Oct 2023 09:34:07 -0700 From: Andrew Morton To: Dan Carpenter Cc: Zach O'Keefe , Yang Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Zach O'Keefe Subject: Re: [PATCH 1/2] mm/khugepaged: Fix an uninitialized variable bug Message-Id: <20231020093407.02be8ef4984ce31a7222f69f@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B6E8840005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 98jfsy9f94zisfhiosdooxdgxq839o5s X-HE-Tag: 1697819653-980027 X-HE-Meta: U2FsdGVkX1+t2LnqhBZcn4mNs7Hisz/SoTTfU5BlwFlS1nHByNJPwne4Y1etBYxui3foWVxT28AZL1iIm1WoBjE5r0xG601fPA2IXj5ZJmlzH+VVOGcMvXILxL7/CUs8z4YhxcF+c8Unm4stnSggKnH8yP7ruxYmy/Zv+/s1yel7lWthtjpZvjNU6qMJZirZYKtOrxByYInk+TL7kuSbh1J4JYTKuZfwRg+lmXudF7A9DDX7nlJyCyjVmrcLOK2QF/nfdVx9IAe0aKFUcW8ava8UTmcywGpQeNhDrymJJQcuxpdbbDqmwjcyQbsYZOrAXRlEooweeXSILNfezdHSNRzb8JQ0TsagGcM6Vn0yiTuLHRotipbD2s6+qxXjJbqCUX5jFwiusJ4R85piU6JYoaKdIF+eMKpw5udn/ZOYciw8ubXMpjX8FyJFobBEsMLuLFfZVQaeMzGjnnAijAIKbHQZ57F+LwSqR+ovFBzGdgFw1817KoLs6GQcoospmjl4FE+cNgluvQsQHjODSTIPoAzbqLAEJ8aPtVV5xqzC2+OqrX4QVw82n6L55N7Px/eDmMXkHjFCvCeyZSMHSTp9ysy0+l6ljAavOMuGhlTckLsKhPrtqp65z2j6uCqY9+g334bvaFbvXs6w+fqBIOQeA0hEC5TtB8KSHWCzEpTL08BPPjPHhOczjird7+1bErZkqsHJo/FR6JuIQTJ7uR6/9ca6QCxNnaUCS5nCJlYm3CIJuGb82CQFWZIDmupKkwwcwKK01f+hD7lrcmwTOLh3AvRY3mK/9i++tKGuy10ccGw7H5KOnC3W8nar7pZyMwAiA7QMsbbRjCraFN5EV8UsDlI35WhydLWU9PCSQtZvEbM8avwc+SYUMzP25DMlTzQHwMc0Vkyspj3djtgjEz8seeCjiAdviUcrocI/qUV/c0gLpxNAkAW1T8wgRGx7fb+OebO/qvJx34V8Wim+cYT qUQF7bys UCgRwQEJ+wrjU+vcsMSDODpYnIpxlooXPhM7KgoHuVuZHMlMRLgXvPLjIujM22ZvQJAF+xSPetHiZSGQoJ6LOLTZxS7EPXRADAmN3jDft8F6QvHCEYya3DNlR5zBVtyF1eo7FYagvHnS4mmjSHXevf5DcwbDH5O7fVGyNrRCl+5OcaY3+ZP+MzW7AuTNtKNgltT8y+puxvWhAX3zxvFRrJxM/LWeWKayGt7QwSHmmz93YicVfeblDUjyLWJfOGuVNOZUchmK4zAp+K9+yCMTAOemw//r1FC36uyHsYiq36TXoeGSVGZcIJfcz1UVkeZWm00BlMI1OIAZDC5rzCbGV5Gg/js4hQoROA95USfFkkT4BOCU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 20 Oct 2023 17:13:32 +0300 Dan Carpenter wrote: > Smatch complains that "hpage" can be used uninitialized: > > mm/khugepaged.c:1234 collapse_huge_page() > error: uninitialized symbol 'hpage'. > > Initialized it on this path. > > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1062,8 +1062,10 @@ static int alloc_charge_hpage(struct page **hpage, struct mm_struct *mm, > int node = hpage_collapse_find_target_node(cc); > struct folio *folio; > > - if (!hpage_collapse_alloc_folio(&folio, gfp, node, &cc->alloc_nmask)) > + if (!hpage_collapse_alloc_folio(&folio, gfp, node, &cc->alloc_nmask)) { > + *hpage = NULL; > return SCAN_ALLOC_HUGE_PAGE_FAIL; > + } > > if (unlikely(mem_cgroup_charge(folio, mm, gfp))) { > folio_put(folio); Thanks. Seems this was accidentally fixed by Author: Peter Xu AuthorDate: Wed Feb 22 14:52:47 2023 -0500 Commit: Andrew Morton CommitDate: Tue Mar 28 16:20:06 2023 -0700 mm/khugepaged: alloc_charge_hpage() take care of mem charge errors Which was quite a long time ago. Are you scanning old kernel versions?