From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897D0CDB474 for ; Fri, 20 Oct 2023 17:31:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2121F6B00C3; Fri, 20 Oct 2023 13:31:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C13F6B00C4; Fri, 20 Oct 2023 13:31:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03B296B00C8; Fri, 20 Oct 2023 13:31:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E1B796B00C3 for ; Fri, 20 Oct 2023 13:31:26 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BA597A050A for ; Fri, 20 Oct 2023 17:31:26 +0000 (UTC) X-FDA: 81366531372.23.32B678C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf11.hostedemail.com (Postfix) with ESMTP id 0AF004000A for ; Fri, 20 Oct 2023 17:31:24 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FlgDo8lI; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697823085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ibUiEBH4doneqJ/+vxB+RQ7/bqoKMwECkVRT3Z/kxfw=; b=vusB5rvs4z2hfqgLDSXj74JVXJ0nQ3A5eP4IRGt/wkTWtTl/3GjFJ27lwrLDuSpBfuFuze kzkgVWVTlomWCCVyY4RvwdNgrGvLAjYJv8YP83lFq7LT5nU6z1c2Z1TxkIk/k87TDgHhY0 /RjS+6toERJVGZbsjlzuh+VXLYe1OpU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697823085; a=rsa-sha256; cv=none; b=xG14tRthVL4Ji+7+pjWqZY2EgXcqqn0hBn1sG6AhwiE/ocomuHL3ysFoFOuhjt85XxF/nQ jwVSHEvthe9pHBLTPsh5dW76U92haMUb+5Z38GfJ0h5tO1Gzzpqt9oGGSTj/jE50kD4aWz pNgMyfp7EGlpFrqEKry01Lh/f6qvDaQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FlgDo8lI; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 70B67B8330B; Fri, 20 Oct 2023 17:31:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 578F7C433C7; Fri, 20 Oct 2023 17:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697823082; bh=oljrLmjEHyjWNMK611/7HLPN620cBkukdqqw9gAc6OQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FlgDo8lImAgwGfJ0VCESmLVYH/IR9aoCqYKgaLCh2qXYogJJQ7yy0bIhWU/EnCsuf 5SV+I3PF2qpFnJ9FHqYwYrUknXyMzNfLO0/0bm5lKc2x365MF5pSpthEzH4M3PTnr7 4H6TIeaiDG7zqV4TbB5VbL94lNjRzmveTk8BHJ2zZ631LiwVtvPIv7c4e1RG2zS7Pd JY+lyUXOTcfl3XA+8yjFEvXebDKueNuOYguyXoFOtFHCXEe7sBQR3P52xcPIm+AAik LOaw00oqbSHEzSOBTbX+dj8OytQ2HdgKFg+zjs8+tP5c7Bfw8lSHkXTCMZunwkLmks F3tyWiJ25SzFw== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, acsjakub@amazon.de Subject: Re: [PATCH 0/5] avoid divide-by-zero due to max_nr_accesses overflow Date: Fri, 20 Oct 2023 17:31:20 +0000 Message-Id: <20231020173120.64224-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231020171901.63994-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: omqk17ujt3koz7hpynpboqc3pn5sj5kg X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0AF004000A X-Rspam-User: X-HE-Tag: 1697823084-928753 X-HE-Meta: U2FsdGVkX1/wpQvYCwKjB3I1ucjfrzVrasrxxduu5GZsoKdpOYuTHv1GLDeAjkLH/kp1nadrwMVfYuYIcMwxux7ao5YisRkMyEoTsHsBdwHzxEKxTceJWpe/hfIE+KCveQWAmtuSCtJgSoq3u1OY+z3qMY33ovWdCykHHodwKkgCr0DBIC2kbpQGsp0M6IjH+zY4ULEhyTlHzYFTKukPWq2q4ub8rv3p6LHV26ndueCjQdSp/twaCjy/aOpSAfXa3RzzGsDpKGGmcgEhHdQPamcWOdXZh60GDOFBVVXFxQq/hXo6FGEFecbibDsKdEl6eVnUIJNyjuNAnEB4hRC6Xf5nXesZqASFLYjDgI+TGXJmqpIQwgcd6K2bzFaPgLcJxEUNHtg3dnpQO4q5flEQdqb7IigpGM/b40b5WW07tLwZa71cELcbZonbTj5g8J3ImK0MDzinVmFp9WVZOxuSPFZ1wtDPfx5RPXtY7C4G+RYwq3AdpHMoIHoQN0SNNGr401Oh2ajhr6ZMl5kQIKOhV+IX5l55VHoHB+0SwaBWFoKhctASf0PueXMznI527qNW4oRVjzp1SWYD1c12JagToPk9YxsX+TJ/EdMa5u4WTtaidqYDRCNPOjXl43b8yXeKstgE0dK1iijbZImAepN5rc9r6pdbZWFgoLXNtAAejevJW5KAA6/HXocilCRcAIcdSZXXNzvj+7aOfHeQd/exmYGYHxheohN1eZiiuCYk1TMlOgFR/919dgSDdcYneEkCeQKtCmMZ8DMx1QrhlXq7eVoNUykBBvjsX8z53IfYLlXlBG5EA9ZMSwYs62xMs7xsDkYJUPWFx+FWEanuAmc0lMEAFJgENCzTAnGclQnPQtG0ajAK9ySUF7Y9n1avF7Oz/MY3190moz4WYISA+PhHU0ceBxSbvuhHHWXzl6gMtUpUPTBYSH7PeM+oC/S9zp/G51ZNEoVwvtreaPOmZj3 QPTg5RUu DWk276LRa3Jwc4IsLk3w1sb8KSgV77QI+MhW2eQDvbU4/CKImi/45UzJ2+URQGl2Dr459FKx8tNUq2g86rmBIrlZPXOyvrFFlpRH58CRVpU6oHU4SAf6FwyyNOzntbspZXBmNNfE6+74oVXWVMXGrZP5IHi/26iewpytufI/8XmgO8D1B+D/SkI6V9+OIRhNSpk1k+n3JQlJ0qEU4/3zVjIqZ6YP1v31Zku4eMKzmo7sM77JzagG7oNkhRHhKBQ7NOd/uvDDcBItSY8IVnSHl8hfpKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 20 Oct 2023 17:19:01 +0000 SeongJae Park wrote: > On Thu, 19 Oct 2023 19:49:19 +0000 SeongJae Park wrote: > > > The maximum nr_accesses of given DAMON context can be calculated by > > dividing the aggregation interval by the sampling interval. Some logics > > in DAMON uses the maximum nr_accesses as a divisor. Hence, the value > > shouldn't be zero. Such case is avoided since DAMON avoids setting the > > agregation interval as samller than the sampling interval. However, > > since nr_accesses is unsigned int while the intervals are unsigned long, > > the maximum nr_accesses could be zero while casting. > > Actually, the issue was reported by Jakub, and I didn't add 'Reported-by:' tags > for him. I sure Andrew could add that on his own, but I want to minimize > Andrew's load, so will send v2 of this patchset. Andrew, please let me know if > that doesn't help but only increasing your load. So sent the second version[1] with the "Reported-by: akub Acs " line, but then I noticed the patch is already added to mm queue[2]. Somehow the notification mails delivered bit later than usual. Sorry for making this noise, Andrew. Please add "Reported-by: akub Acs " to already added patches, or replace those with the v2 if possible. Also, please let me know if there's anything I could help. [1] https://lore.kernel.org/damon/20231020172317.64192-1-sj@kernel.org/ [2] https://lore.kernel.org/mm-commits/20231020171847.C6EEAC433C7@smtp.kernel.org/ Thanks, SJ > > > Thanks, > SJ >